From patchwork Fri Aug 22 23:54:48 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kevin Hilman X-Patchwork-Id: 4767581 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 4DE3FC0338 for ; Fri, 22 Aug 2014 23:57:54 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 42B6720138 for ; Fri, 22 Aug 2014 23:57:53 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5AEA92012F for ; Fri, 22 Aug 2014 23:57:52 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1XKyft-0001wC-0D; Fri, 22 Aug 2014 23:55:17 +0000 Received: from mail-pd0-f171.google.com ([209.85.192.171]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1XKyfo-00080z-Qr for linux-arm-kernel@lists.infradead.org; Fri, 22 Aug 2014 23:55:13 +0000 Received: by mail-pd0-f171.google.com with SMTP id z10so16715458pdj.30 for ; Fri, 22 Aug 2014 16:54:50 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-type; bh=/bA+WTDm6r4lh9V+Kcv+KavuR/QCJulTQTjdkycOL8I=; b=apoK6s/k650msn6PcPbMHxa9GqWUk/X/GZ1A2DhdKJoQKXD/MOJLY2/hOrPQSwL/Xk QJYoF1+US8Zc7YVTycVNNZeGRWGmxRmTMJd1IHJ8OR+lPnFFlsZg8pIUNGCtHHW6kTu6 u7MpW8Ljt7xnK2ccGGq1qaYQ9IZeCtpO/UjoPM127f919GdBbUGhxfiEnMLriYeZIFe6 1gf2xeNGqYnsUKRvZvIYDwVXJlaKCMk0UBejiHumC2SLqMXpJwgbV39T3ETt9nDb2muZ 9/RY4KynI23MNgYCGleqXqsmb85Z2ul+owrZWrt1Tk/8+A5rwKWsVJ1qC0My4LStx97i AN/g== X-Gm-Message-State: ALoCoQmYx3hGXsCZZne1f4AzGI1peRQobUAnK3nnt9TBcglmVAzPsoutye9Zi9XJaPNTseJAEUYG X-Received: by 10.67.15.172 with SMTP id fp12mr10546337pad.4.1408751690514; Fri, 22 Aug 2014 16:54:50 -0700 (PDT) Received: from localhost (c-67-183-17-239.hsd1.wa.comcast.net. [67.183.17.239]) by mx.google.com with ESMTPSA id zv3sm3262036pac.16.2014.08.22.16.54.49 for (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Fri, 22 Aug 2014 16:54:49 -0700 (PDT) From: Kevin Hilman To: Tomasz Figa Subject: Re: [PATCH v9 4/6] ARM: Exynos: switch to using generic cpufreq driver for Exynos4210/5250/5420 References: <1406707663-16656-1-git-send-email-thomas.ab@samsung.com> <1406707663-16656-5-git-send-email-thomas.ab@samsung.com> <53DA8BB9.6020702@samsung.com> <53DA8D85.3050106@gmail.com> Date: Fri, 22 Aug 2014 16:54:48 -0700 In-Reply-To: <53DA8D85.3050106@gmail.com> (Tomasz Figa's message of "Thu, 31 Jul 2014 20:40:05 +0200") Message-ID: <7hbnrc6px3.fsf@paris.lan> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20140822_165512_901650_EF845BD5 X-CRM114-Status: GOOD ( 20.99 ) X-Spam-Score: -1.4 (-) Cc: l.majewski@samsung.com, Kukjin Kim , mturquette@linaro.org, heiko@sntech.de, linux-pm@vger.kernel.org, viresh.kumar@linaro.org, t.figa@samsung.com, amit.kucheria@linaro.org, cw00.choi@samsung.com, Thomas Abraham , linux-samsung-soc@vger.kernel.org, linaro-kernel@lists.linaro.org, linux-arm-kernel@lists.infradead.org X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_NONE, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Tomasz Figa writes: > Kukjin, > > On 31.07.2014 20:32, Kukjin Kim wrote: >> On 07/30/14 17:07, Thomas Abraham wrote: >>> The new CPU clock type allows the use of generic CPUfreq drivers. So for >>> Exynos4210/5250, switch to using generic cpufreq driver. For Exynos5420, >>> which did not have CPUfreq driver support, enable the use of generic >>> CPUfreq driver. >>> >>> Suggested-by: Tomasz Figa >>> Cc: Kukjin Kim >> >> Looks good to me, >> >> Acked-by: Kukjin Kim >> >> BTW, who will handle this series? I hope see this series in 3.17. > > This series consists mostly of clock changes and it likely depends on > patches already in my for-next, so I would be inclined toward taking it > through samsung-clk tree. So has this series been picked up anywhere? I don't see it in your samsung-clk tree, nor in Kukjin's for-next. Also, I'm curious whether or how this is has been tested on big.LITTLE SoCs. I'm trying it on the 5800/Chromebook2 and it's not terribly stable. I'm testing along with CPUidle, so there may be some untested interactions there as it seems a bit more stable without CPUidle enabled. I'd love to hear from anyone else that's testing CPUidle and CPUfreq together big.LITTLE 5420/5800, with or without the switcher. Also, the patch below[2] is needed for 5800. FWIW, I have a temporary branch[1] based on the v3.17-rc branch of the exynos-reference tree where I've added the DT patch needed for CPUidle, this series (and it's dependencies) which is what I'm using for testing. Kevin [1] git://git.kernel.org/pub/scm/linux/kernel/git/khilman/linux.git wip/exynos/integ [2] From 72ee00246c0fbdcf5dbb0bf910b8a427da4ac002 Mon Sep 17 00:00:00 2001 From: Kevin Hilman Date: Fri, 22 Aug 2014 16:04:11 -0700 Subject: [PATCH] ARM: Exynos: use generic cpufreq driver for Exynos5800 As a derivative of the 5420, the 5800 SoC should use the generic big.LITTLE driver for Exynos5800 as well. Signed-off-by: Kevin Hilman --- arch/arm/mach-exynos/exynos.c | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/mach-exynos/exynos.c b/arch/arm/mach-exynos/exynos.c index 8923d37c3e85..debe50bf736a 100644 --- a/arch/arm/mach-exynos/exynos.c +++ b/arch/arm/mach-exynos/exynos.c @@ -283,6 +283,7 @@ static void __init exynos_init_irq(void) static const struct of_device_id exynos_cpufreq_matches[] = { { .compatible = "samsung,exynos5420", .data = "arm-bL-cpufreq-dt" }, + { .compatible = "samsung,exynos5800", .data = "arm-bL-cpufreq-dt" }, { .compatible = "samsung,exynos5250", .data = "cpufreq-cpu0" }, { .compatible = "samsung,exynos4210", .data = "cpufreq-cpu0" }, { .compatible = "samsung,exynos5440", .data = "exynos5440-cpufreq" },