From patchwork Fri Jun 6 00:15:42 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kevin Hilman X-Patchwork-Id: 4309281 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id B5AA8BEEAA for ; Fri, 6 Jun 2014 00:18:50 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id DCDE320222 for ; Fri, 6 Jun 2014 00:18:49 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 00D89201F7 for ; Fri, 6 Jun 2014 00:18:49 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1WshpK-0006dk-Fq; Fri, 06 Jun 2014 00:16:10 +0000 Received: from mail-pd0-f171.google.com ([209.85.192.171]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1WshpH-0006d8-V7 for linux-arm-kernel@lists.infradead.org; Fri, 06 Jun 2014 00:16:08 +0000 Received: by mail-pd0-f171.google.com with SMTP id y13so1775557pdi.16 for ; Thu, 05 Jun 2014 17:15:45 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :mime-version:content-type; bh=dyLnEyqG5IIFVZFyL/mTm+Wn/KAQPqiLsWC51jjVsio=; b=W+w08VfeS2nsmMek5tmSHK5cyABbZ0+6ZyhRJNNH6Xl3TwT+6KRIzem9gBdYYdnfqV nKGaesd5PxibSFG+YwCZ4otv1B6SGi5JYcFissnZIRhz937c+hiJCd8DInXzo5Y+mkQU 74mcg2/G0PW0LBLE2bd2rBB113F4Sx6++4H0AVavEXTNvDX026tWE/47LxVUtwcoOzF5 C1pRHDF6aPR5ACnDQeTX7IXQ7Dn8Ai+VBU1w/90N+FKWjr2yh1dyYBkbW1VseATJXeGW tJP1UCAdmNQ1XIq26P49bX3/XhZTXTYJnvjy5zoreFXPiwgFaJtKnjaLY30O7DFnp7n4 W2Zg== X-Gm-Message-State: ALoCoQmJQezkGou16OhPeRs34J5bLv1IkVabHTqqzxSb6dNoaYSgx9SqWMXzob/WC4GJMN601SUg X-Received: by 10.68.133.163 with SMTP id pd3mr1998778pbb.166.1402013744970; Thu, 05 Jun 2014 17:15:44 -0700 (PDT) Received: from localhost (c-67-183-17-239.hsd1.wa.comcast.net. [67.183.17.239]) by mx.google.com with ESMTPSA id fx5sm28125274pbb.62.2014.06.05.17.15.43 for (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Thu, 05 Jun 2014 17:15:44 -0700 (PDT) From: Kevin Hilman To: linux-samsung-soc@vger.kernel.org Subject: exynos5420-peach-pi: linux-next boot fails unless mau_epll left enabled? Date: Thu, 05 Jun 2014 17:15:42 -0700 Message-ID: <7hoay6sxjl.fsf@paris.lan> User-Agent: Gnus/5.130008 (Ma Gnus v0.8) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20140605_171608_048757_5144CE2B X-CRM114-Status: UNSURE ( 9.84 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -0.0 (/) Cc: Olof Johansson , "Turquette, Mike" , javier.martinez@collabora.co.uk, linux-arm-kernel , dianders@google.com X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-2.5 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Hello, I'm trying to boot next-20140605[1] on my recently arrived Chromebook2 (peach-pi) and was not getting to userspace. Comparing notes with Doug Anderson, his was booting just fine, so after some debugging and adding 'clk_ignore_unused' to the command-line, it started booting fine. So then, I tracked it down to which clock was causing the problems and found that it's the mau_epll clock gating that's causing the problem, and leaving it enabled[1] allows me to boot again. Any ideas what's going on here? And in particular, any ideas why it would affect my board and not other boards like Doug's? Thanks, Kevin [1] Using this defconfig: https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/master/eclass/cros-kernel/exynos5_defconfig [2] GATE(CLK_SCLK_UART0, "sclk_uart0", "dout_uart0", diff --git a/drivers/clk/samsung/clk-exynos5420.c b/drivers/clk/samsung/clk-exynos5420.c index 61eccf0dd72f..ed175088ee7e 100644 --- a/drivers/clk/samsung/clk-exynos5420.c +++ b/drivers/clk/samsung/clk-exynos5420.c @@ -911,7 +911,7 @@ static struct samsung_gate_clock exynos5x_gate_clks[] __initdata = { SRC_MASK_TOP2, 24, 0, 0), GATE(CLK_MAU_EPLL, "mau_epll", "mout_mau_epll_clk", - SRC_MASK_TOP7, 20, 0, 0), + SRC_MASK_TOP7, 20, CLK_IGNORE_UNUSED, 0), /* sclk */