From patchwork Tue May 28 22:15:09 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Arnaud Ebalard X-Patchwork-Id: 2627191 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork1.kernel.org Received: from casper.infradead.org (casper.infradead.org [85.118.1.10]) by patchwork1.kernel.org (Postfix) with ESMTP id F286940077 for ; Tue, 28 May 2013 22:14:27 +0000 (UTC) Received: from merlin.infradead.org ([2001:4978:20e::2]) by casper.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1UhS9x-0008I1-7F; Tue, 28 May 2013 22:14:25 +0000 Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1UhS9u-00087T-LW; Tue, 28 May 2013 22:14:22 +0000 Received: from mic92-1-81-57-185-249.fbx.proxad.net ([81.57.185.249] helo=smtp.natisbad.org) by merlin.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1UhS9r-00086h-LW for linux-arm-kernel@lists.infradead.org; Tue, 28 May 2013 22:14:21 +0000 Received: by smtp.natisbad.org (Postfix, from userid 5001) id 0239D2C0786; Wed, 29 May 2013 00:13:55 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=natisbad.org; s=mail; t=1369779236; bh=oNkiVhf2lneChY3PMem5qS85mzgLknrp2GYHMdxVFqY=; h=From:To:Cc:Subject:Date; b=b39mD0nL6xf8D1uQSeFLE5DU9eXInoX85Pq1KMWP+S2av/4z7MAozRESsuPejgDkO eCFcRmogEn8qgEndA4RZExMPERsKUjf1Kx3vBYWufR6bBaLxD5UQtbU+UtgEEXy3KM 7y0u1A72O1HJPgu2U9qaRW94A5ppD0fhktCSICvk= X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on petit X-Spam-Level: X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED, T_DKIM_INVALID autolearn=unavailable version=3.3.2 Received: from small (localhost [127.0.0.1]) by smtp.natisbad.org (Postfix) with ESMTP id 6B7632C035B; Wed, 29 May 2013 00:13:46 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=natisbad.org; s=mail; t=1369779226; bh=oNkiVhf2lneChY3PMem5qS85mzgLknrp2GYHMdxVFqY=; h=From:To:Cc:Subject:Date; b=Sqw8wz8G3DPwuIl8caNOEdtrSYwvsY8I5YwBaaEgwEbGZzjq9eLyIjs8oMCPemeMA KToPDwyQ1p48nusTpaXxnZzy8g94wX+zVZOrRgQ40To1Z+Q5f4OxuqI6+lJq/DimAF hZQ7Zu9H19l6EgAi20lrE8oEhDaR3h6DYoIvnE3E= X-Hashcash: 1:20:130528:jason@lakedaemon.net::FstmQ+hny18rmOgo:000000000000000000000000000000000000000001792 X-Hashcash: 1:20:130528:thomas.petazzoni@free-electrons.com::8jMG4ODq7+Be1m8o:0000000000000000000000000005Ux X-Hashcash: 1:20:130528:andrew@lunn.ch::oQCrszvrxjiUW4RV:0000JF4 X-Hashcash: 1:20:130528:linux@arm.linux.org.uk::wZ7H/eU9S3ZANDc9:0000000000000000000000000000000000000006B+E X-Hashcash: 1:20:130528:linux-arm-kernel@lists.infradead.org::JbBBGviykspwftcy:0000000000000000000000000283t From: arno@natisbad.org (Arnaud Ebalard) To: Jason Cooper , Thomas Petazzoni Subject: [PATCH] arm: kirkwood: convert NETGEAR ReadyNAS Duo v2 to use DT for the PCIe interface X-PGP-Key-URL: http://natisbad.org/arno@natisbad.org.asc X-Fingerprint: D3A5 B68A 839B 38A5 815A 781B B77C 0748 A7AE 341B Date: Wed, 29 May 2013 00:15:09 +0200 Message-ID: <8738t6ycnm.fsf@natisbad.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20130528_181419_995228_A11AA4E7 X-CRM114-Status: GOOD ( 17.54 ) X-Spam-Score: -1.0 (-) X-Spam-Report: SpamAssassin version 3.3.2 on merlin.infradead.org summary: Content analysis details: (-1.0 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 SPF_PASS SPF: sender matches SPF record -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 1.0 RDNS_DYNAMIC Delivered to internal network by host with dynamic-looking rDNS Cc: Andrew Lunn , Russell King , linux-arm-kernel@lists.infradead.org X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org Hi Jason and Thomas, Thomas, I am following your work on PCIe support for a .dts file I am working on for (Armada 370-based) Netgear ReadyNAS 102 and noticed your set of patches to convert kirkwood-based boards to use it in order to simplify/remove board specific code. Jason, I gave your associated branch (jcooper/mvebu-next/pcie) a try with following patch applied and can confirm USB 3.0 host controller (connected to PCIe bus) is usable on Netgear ReadyNAS *Duo v2* (88f6282-based brother of the 102). Note that I had to s/of_pci_range_parser()/of_pci_range_parser_init()/ in drivers/pci/host/pci-mvebu.c to compile the kernel (this may already have been fixed already): CHK kernel/config_data.h drivers/pci/host/pci-mvebu.c: In function ‘mvebu_pcie_probe’: drivers/pci/host/pci-mvebu.c:742:2: error: implicit declaration of function ‘of_pci_range_parser’ [-Werror=implicit-function-declaration] cc1: some warnings being treated as errors make[3]: *** [drivers/pci/host/pci-mvebu.o] Error 1 make[2]: *** [drivers/pci/host] Error 2 make[1]: *** [drivers/pci] Error 2 make[1]: *** Waiting for unfinished jobs.... Can one of you take the patch below into account? Or Cheers, a+ Signed-off-by: Arnaud Ebalard --- arch/arm/boot/dts/kirkwood-netgear_readynas_duo_v2.dts | 8 ++++++++ arch/arm/mach-kirkwood/board-readynas.c | 1 - 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/kirkwood-netgear_readynas_duo_v2.dts b/arch/arm/boot/dts/kirkwood-netgear_readynas_duo_v2.dts index 1ca66ab..f9706da 100644 --- a/arch/arm/boot/dts/kirkwood-netgear_readynas_duo_v2.dts +++ b/arch/arm/boot/dts/kirkwood-netgear_readynas_duo_v2.dts @@ -111,6 +111,14 @@ status = "okay"; nr-ports = <2>; }; + + pcie-controller { + status = "okay"; + + pcie@1,0 { + status = "okay"; + }; + }; }; gpio-leds { diff --git a/arch/arm/mach-kirkwood/board-readynas.c b/arch/arm/mach-kirkwood/board-readynas.c index fb42c20..341b82d 100644 --- a/arch/arm/mach-kirkwood/board-readynas.c +++ b/arch/arm/mach-kirkwood/board-readynas.c @@ -24,5 +24,4 @@ static struct mv643xx_eth_platform_data netgear_readynas_ge00_data = { void __init netgear_readynas_init(void) { kirkwood_ge00_init(&netgear_readynas_ge00_data); - kirkwood_pcie_init(KW_PCIE0); }