From patchwork Sat Nov 8 21:01:37 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Robert Jarzmik X-Patchwork-Id: 5259121 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 61CB2C11AC for ; Sat, 8 Nov 2014 21:04:34 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 8D6E92012E for ; Sat, 8 Nov 2014 21:04:33 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8B68320122 for ; Sat, 8 Nov 2014 21:04:32 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1XnD92-0003NN-P1; Sat, 08 Nov 2014 21:02:04 +0000 Received: from smtp01.smtpout.orange.fr ([80.12.242.123] helo=smtp.smtpout.orange.fr) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1XnD8z-0003MJ-VC for linux-arm-kernel@lists.infradead.org; Sat, 08 Nov 2014 21:02:03 +0000 Received: from beldin ([109.222.82.103]) by mwinf5d01 with ME id D91d1p0062DlPNM0391ded; Sat, 08 Nov 2014 22:01:39 +0100 X-ME-Helo: beldin X-ME-Date: Sat, 08 Nov 2014 22:01:39 +0100 X-ME-IP: 109.222.82.103 From: Robert Jarzmik To: Dmitry Eremin-Solenikov Subject: Re: [PATCH v1 0/3] Transition pxa25x clock to common clocks References: <1414941415-13146-1-git-send-email-robert.jarzmik@free.fr> <87lhnlwqm4.fsf@free.fr> X-URL: http://belgarath.falguerolles.org/ Date: Sat, 08 Nov 2014 22:01:37 +0100 In-Reply-To: (Dmitry Eremin-Solenikov's message of "Sat, 8 Nov 2014 23:55:49 +0400") Message-ID: <8761epwgni.fsf@free.fr> User-Agent: Gnus/5.130008 (Ma Gnus v0.8) Emacs/24.3.92 (gnu/linux) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20141108_130202_391106_85746BE0 X-CRM114-Status: GOOD ( 19.78 ) X-Spam-Score: -0.0 (/) Cc: Mike Turquette , kernel list , Haojian Zhuang , Daniel Mack , Marek Vasut , Ian Molton , linux-arm-kernel X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-2.5 required=5.0 tests=BAYES_00,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Dmitry Eremin-Solenikov writes: > 2014-11-08 20:26 GMT+03:00 Robert Jarzmik : >> Dmitry Eremin-Solenikov writes: >> >>> Hello, >>> Tested in qemu (pxa25x target). >>> >>> 2) sa1100-rtc could not find a clock and thus failed to be probed. >>> 4) Got an issue with IrDA driver - it gets -ENODEV for UARTCLK clock >> >> Hi Dmitry, >> >> Would you mind retesting with the patch in [1] applied to see if points 2 and 4 >> are fixed ? Alternatively you can refetch from the github tree, I included that >> incremental patch there too. >> >> If it works correctly for you, could I have your Tested-by ? If not, tell me and >> I'll try to figure out what's wrong. > > Tested in qemu, everything works fine. I will test on the real hardware > tomorow. Aha, the test. Would you at that time do a "cat /sys/kernel/debug/clk/clk_summary" and send it to me please ? > > BTW: It looks like pxa27x also shows the same behaviour wrt. sa1100-rtc and > pxa2xx-ir (after reverting a revert). Ah yes, you're very right about that. Same as before, github updated and patch included in this mail. Cheers. Tested-by: Dmitry Eremin-Solenikov From c36803b312621c1a69d2d6aed000ae7ee11da588 Mon Sep 17 00:00:00 2001 From: Robert Jarzmik Date: Sat, 8 Nov 2014 21:46:51 +0100 Subject: [PATCH] clk: pxa: add missing clocks for Irda and sa1100-rtc Add 2 clocks which were erronously forgotten by the clock framework port, namely : - sa1100-rtc - irda for pxa2xx-ir:UARTCLK Signed-off-by: Robert Jarzmik --- drivers/clk/pxa/clk-pxa27x.c | 28 ++++++++++++++++++++++++++++ 1 file changed, 28 insertions(+) diff --git a/drivers/clk/pxa/clk-pxa27x.c b/drivers/clk/pxa/clk-pxa27x.c index 2b8343a..611879b 100644 --- a/drivers/clk/pxa/clk-pxa27x.c +++ b/drivers/clk/pxa/clk-pxa27x.c @@ -353,6 +353,33 @@ static u8 clk_pxa27x_memory_get_parent(struct clk_hw *hw) PARENTS(clk_pxa27x_memory) = { "osc_13mhz", "system_bus", "run" }; MUX_RO_RATE_RO_OPS(clk_pxa27x_memory, "memory"); +#define DUMMY_CLK(_con_id, _dev_id, _parent) \ + { .con_id = _con_id, .dev_id = _dev_id, .parent = _parent } +struct dummy_clk { + const char *con_id; + const char *dev_id; + const char *parent; +}; +static struct dummy_clk dummy_clks[] __initdata = { + DUMMY_CLK(NULL, "sa1100-rtc", "osc_32_768khz"), + DUMMY_CLK("UARTCLK", "pxa2xx-ir", "STUART"), +}; + +static void __init pxa27x_dummy_clocks_init(void) +{ + struct clk *clk; + struct dummy_clk *d; + const char *name; + int i; + + for (i = 0; i < ARRAY_SIZE(dummy_clks); i++) { + d = &dummy_clks[i]; + name = d->dev_id ? d->dev_id : d->con_id; + clk = clk_register_fixed_factor(NULL, name, d->parent, 0, 1, 1); + clk_register_clkdev(clk, d->con_id, d->dev_id); + } +} + static void __init pxa27x_base_clocks_init(void) { pxa27x_register_plls(); @@ -365,6 +392,7 @@ static void __init pxa27x_base_clocks_init(void) int __init pxa27x_clocks_init(void) { pxa27x_base_clocks_init(); + pxa27x_dummy_clocks_init(); return clk_pxa_cken_init(pxa27x_clocks, ARRAY_SIZE(pxa27x_clocks)); } -- 2.1.0