From patchwork Mon Apr 15 22:06:33 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kevin Hilman X-Patchwork-Id: 2447061 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork2.kernel.org Received: from casper.infradead.org (casper.infradead.org [85.118.1.10]) by patchwork2.kernel.org (Postfix) with ESMTP id 2A761DF2E5 for ; Mon, 15 Apr 2013 22:06:55 +0000 (UTC) Received: from merlin.infradead.org ([2001:4978:20e::2]) by casper.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1URrXy-0003HU-Eg; Mon, 15 Apr 2013 22:06:46 +0000 Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1URrXw-0007c5-5I; Mon, 15 Apr 2013 22:06:44 +0000 Received: from mail-pd0-f175.google.com ([209.85.192.175]) by merlin.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1URrXr-0007bl-Po for linux-arm-kernel@lists.infradead.org; Mon, 15 Apr 2013 22:06:41 +0000 Received: by mail-pd0-f175.google.com with SMTP id g10so2726987pdj.6 for ; Mon, 15 Apr 2013 15:06:36 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=x-received:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-type:x-gm-message-state; bh=3BiVnmdURkJEeVbUoCaIlIBEmxRDeSiCO2G9GZOg4iA=; b=SWbA0Xf+Nj5NfsULwUabYrRSQM/s8fmg5x7NQ3IBNygJ8MaCq7CHz76Iin60UGBi8g YBML4wKvjV5HQCZOsXV9obq/ORrokfcrpgAStOa1f7ZX1YUeZ8e2dVUqCUP55N5KKy2G M3q+91QtPa7iaxD6sRWbN3AncedZExhtWfA+NObpkn0qX0CGbPWsotOLgQBDtWI8+xDU v6vSxdi0Kcjtyvq8h8SNJGRI7zZnYox3wCiXGE7M4//ZllRhxrtWkYrdrptEBh3BH9a6 cZ26mq9YGx7tOL+zbovxFcBOZEuvWWrc0s7RYbwAkcyCKAld+hakPq545r7WOxi76z4E cKKw== X-Received: by 10.66.147.38 with SMTP id th6mr227532pab.56.1366063596877; Mon, 15 Apr 2013 15:06:36 -0700 (PDT) Received: from localhost (c-24-19-7-36.hsd1.wa.comcast.net. [24.19.7.36]) by mx.google.com with ESMTPS id gi10sm21738010pbc.40.2013.04.15.15.06.34 (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Mon, 15 Apr 2013 15:06:35 -0700 (PDT) From: Kevin Hilman To: Jon Hunter Subject: Re: [PATCH 1/5] gpio/omap: free irq domain in probe() failure paths References: <1365106576-31816-1-git-send-email-jon-hunter@ti.com> <1365106576-31816-2-git-send-email-jon-hunter@ti.com> <5165C201.8010500@ti.com> Date: Mon, 15 Apr 2013 15:06:33 -0700 In-Reply-To: <5165C201.8010500@ti.com> (Jon Hunter's message of "Wed, 10 Apr 2013 14:48:17 -0500") Message-ID: <87a9ozbg9i.fsf@linaro.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.1 (gnu/linux) MIME-Version: 1.0 X-Gm-Message-State: ALoCoQn4Sj7ibZQ5gdkmzvzVs7AFcqfTgKh/gsRLQgPAcw0rLS0BmHup2yb6v/nHR75Hnp/mRQ+n X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20130415_180639_953207_AD664DEA X-CRM114-Status: GOOD ( 17.48 ) X-Spam-Score: -1.9 (-) X-Spam-Report: SpamAssassin version 3.3.2 on merlin.infradead.org summary: Content analysis details: (-1.9 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no trust [209.85.192.175 listed in list.dnswl.org] -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] Cc: Linus Walleij , Grant Likely , Santosh Shilimkar , linux-omap , device-tree , linux-arm X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org Jon Hunter writes: > On 04/10/2013 02:33 PM, Linus Walleij wrote: >> On Thu, Apr 4, 2013 at 10:16 PM, Jon Hunter wrote: >> >>> Currently the IRQ domain is not freed once allocated, in the case where >>> omap_gpio_probe() fails. Therefore, ensure we free the domain if the >>> probe does fail. Furthermore, the local variable "ret" is not needed >>> and so remove this. >>> >>> Signed-off-by: Jon Hunter >> >> Hm Kevin is still listed as maintainer on this driver but on a mail >> address that bounces, can you send a patch replacing him in MAINTAINERS >> with yourself if you're willing to pick it up? >> >> Anyway, patch applied. > > Thanks. There is a patch to fix this queued for v3.10 [1]. Yeah, but you've already been doing the heavly lifting here and should be the maintainer going forward, IMO. Patch below. Linus, do you want to queue this up? Kevin From 00d19c10c02c3a3aa99ca7ae75bc88a932437abd Mon Sep 17 00:00:00 2001 From: Kevin Hilman Date: Mon, 15 Apr 2013 15:02:26 -0700 Subject: [PATCH] MAINTAINERS: update OMAP GPIO driver: Jon Hunter taking over Jon has already been doing most of maintenance of this driver, so make it official. Cc: Linus Walleij Cc: Grant Likely Signed-off-by: Kevin Hilman --- Applies on v3.9-rc7 MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index 8bdd7a7..a18cacb 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -5789,7 +5789,7 @@ F: arch/arm/*omap*/usb* OMAP GPIO DRIVER M: Santosh Shilimkar -M: Kevin Hilman +M: Jon Hunter L: linux-omap@vger.kernel.org S: Maintained F: drivers/gpio/gpio-omap.c