[v1,0/3] Transition pxa25x clock to common clocks

Commit Message

Robert Jarzmik Nov. 8, 2014, 5:26 p.m. UTC

Dmitry Eremin-Solenikov <[e-mail]> writes:

> Hello,
> Tested in qemu (pxa25x target).
>
> 2) sa1100-rtc could not find a clock and thus failed to be probed.
> 4) Got an issue with IrDA driver - it gets -ENODEV for UARTCLK clock

Hi Dmitry,

Would you mind retesting with the patch in [1] applied to see if points 2 and 4
are fixed ? Alternatively you can refetch from the github tree, I included that
incremental patch there too.

If it works correctly for you, could I have your Tested-by ? If not, tell me and
I'll try to figure out what's wrong.

Cheers.

Comments

Dmitry Baryshkov Nov. 8, 2014, 7:55 p.m. UTC | #1

2014-11-08 20:26 GMT+03:00 Robert Jarzmik <[e-mail]>:
> Dmitry Eremin-Solenikov <[e-mail]> writes:
>
>> Hello,
>> Tested in qemu (pxa25x target).
>>
>> 2) sa1100-rtc could not find a clock and thus failed to be probed.
>> 4) Got an issue with IrDA driver - it gets -ENODEV for UARTCLK clock
>
> Hi Dmitry,
>
> Would you mind retesting with the patch in [1] applied to see if points 2 and 4
> are fixed ? Alternatively you can refetch from the github tree, I included that
> incremental patch there too.
>
> If it works correctly for you, could I have your Tested-by ? If not, tell me and
> I'll try to figure out what's wrong.

Tested in qemu, everything works fine. I will test on the real hardware tomorow.

BTW: It looks like pxa27x also shows the same behaviour wrt. sa1100-rtc and
pxa2xx-ir (after reverting a revert).

Patch

From 7f43d2f9c9d415b8bc1ed7e2f3e422de349d6957 Mon Sep 17 00:00:00 2001
From: Robert Jarzmik <[e-mail]>
Date: Sat, 8 Nov 2014 18:20:18 +0100
Subject: [PATCH] fixup! clk: add pxa25x clock drivers

---
 drivers/clk/pxa/clk-pxa25x.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/clk/pxa/clk-pxa25x.c b/drivers/clk/pxa/clk-pxa25x.c
index db07d4b..fb73e58 100644
--- a/drivers/clk/pxa/clk-pxa25x.c
+++ b/drivers/clk/pxa/clk-pxa25x.c
@@ -127,7 +127,6 @@  static struct desc_clk_cken pxa25x_clocks[] __initdata = {
 	PXA25X_PBUS147_CKEN("pxa2xx-uart.1", NULL, BTUART, 1, 10, 1),
 	PXA25X_PBUS147_CKEN("pxa2xx-uart.2", NULL, STUART, 1, 10, 1),
 	PXA25X_PBUS147_CKEN("pxa2xx-uart.3", NULL, HWUART, 1, 10, 1),
-	PXA25X_PBUS147_CKEN("pxa2xx-ir", "UARTCLK", STUART, 1, 10, 1),
 	PXA25X_PBUS147_CKEN("pxa2xx-i2s", NULL, I2S, 1, 1, 0),
 	PXA25X_PBUS147_CKEN(NULL, "AC97CLK", AC97, 1, 12, 0),
 	PXA25X_OSC3_CKEN("pxa25x-ssp.0", NULL, SSP, 1, 1, 0),
@@ -233,8 +232,9 @@  static struct dummy_clk dummy_clks[] __initdata = {
 	DUMMY_CLK(NULL, "pxa26x-gpio", "osc_32_768khz"),
 	DUMMY_CLK("GPIO11_CLK", NULL, "osc_3_6864mhz"),
 	DUMMY_CLK("GPIO12_CLK", NULL, "osc_32_768khz"),
-	DUMMY_CLK("sa1100-rtc", NULL, "osc_32_768khz"),
+	DUMMY_CLK(NULL, "sa1100-rtc", "osc_32_768khz"),
 	DUMMY_CLK("OSTIMER0", NULL, "osc_32_768khz"),
+	DUMMY_CLK("UARTCLK", "pxa2xx-ir", "STUART"),
 };
 
 static void __init pxa25x_dummy_clocks_init(void)
-- 
2.1.0