From patchwork Sat Nov 8 17:26:27 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Robert Jarzmik X-Patchwork-Id: 5257341 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id EAAFF9F39B for ; Sat, 8 Nov 2014 17:28:50 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 3097120138 for ; Sat, 8 Nov 2014 17:28:50 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 55C1120122 for ; Sat, 8 Nov 2014 17:28:49 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1Xn9mw-0004wO-GL; Sat, 08 Nov 2014 17:27:02 +0000 Received: from smtp05.smtpout.orange.fr ([80.12.242.127] helo=smtp.smtpout.orange.fr) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1Xn9mq-0004lN-0I for linux-arm-kernel@lists.infradead.org; Sat, 08 Nov 2014 17:26:57 +0000 Received: from beldin ([109.222.82.103]) by mwinf5d40 with ME id D5ST1p0032DlPNM035STt4; Sat, 08 Nov 2014 18:26:33 +0100 X-ME-Helo: beldin X-ME-Date: Sat, 08 Nov 2014 18:26:33 +0100 X-ME-IP: 109.222.82.103 From: Robert Jarzmik To: Dmitry Eremin-Solenikov Subject: Re: [PATCH v1 0/3] Transition pxa25x clock to common clocks References: <1414941415-13146-1-git-send-email-robert.jarzmik@free.fr> X-URL: http://belgarath.falguerolles.org/ Date: Sat, 08 Nov 2014 18:26:27 +0100 In-Reply-To: (Dmitry Eremin-Solenikov's message of "Thu, 6 Nov 2014 12:45:02 +0400") Message-ID: <87lhnlwqm4.fsf@free.fr> User-Agent: Gnus/5.130008 (Ma Gnus v0.8) Emacs/24.3.92 (gnu/linux) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20141108_092656_389642_FEDEF2CF X-CRM114-Status: GOOD ( 14.62 ) X-Spam-Score: -0.0 (/) Cc: Mike Turquette , kernel list , Haojian Zhuang , Daniel Mack , Marek Vasut , Ian Molton , linux-arm-kernel X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-2.5 required=5.0 tests=BAYES_00,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Dmitry Eremin-Solenikov writes: > Hello, > Tested in qemu (pxa25x target). > > 2) sa1100-rtc could not find a clock and thus failed to be probed. > 4) Got an issue with IrDA driver - it gets -ENODEV for UARTCLK clock Hi Dmitry, Would you mind retesting with the patch in [1] applied to see if points 2 and 4 are fixed ? Alternatively you can refetch from the github tree, I included that incremental patch there too. If it works correctly for you, could I have your Tested-by ? If not, tell me and I'll try to figure out what's wrong. Cheers. From 7f43d2f9c9d415b8bc1ed7e2f3e422de349d6957 Mon Sep 17 00:00:00 2001 From: Robert Jarzmik Date: Sat, 8 Nov 2014 18:20:18 +0100 Subject: [PATCH] fixup! clk: add pxa25x clock drivers --- drivers/clk/pxa/clk-pxa25x.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/clk/pxa/clk-pxa25x.c b/drivers/clk/pxa/clk-pxa25x.c index db07d4b..fb73e58 100644 --- a/drivers/clk/pxa/clk-pxa25x.c +++ b/drivers/clk/pxa/clk-pxa25x.c @@ -127,7 +127,6 @@ static struct desc_clk_cken pxa25x_clocks[] __initdata = { PXA25X_PBUS147_CKEN("pxa2xx-uart.1", NULL, BTUART, 1, 10, 1), PXA25X_PBUS147_CKEN("pxa2xx-uart.2", NULL, STUART, 1, 10, 1), PXA25X_PBUS147_CKEN("pxa2xx-uart.3", NULL, HWUART, 1, 10, 1), - PXA25X_PBUS147_CKEN("pxa2xx-ir", "UARTCLK", STUART, 1, 10, 1), PXA25X_PBUS147_CKEN("pxa2xx-i2s", NULL, I2S, 1, 1, 0), PXA25X_PBUS147_CKEN(NULL, "AC97CLK", AC97, 1, 12, 0), PXA25X_OSC3_CKEN("pxa25x-ssp.0", NULL, SSP, 1, 1, 0), @@ -233,8 +232,9 @@ static struct dummy_clk dummy_clks[] __initdata = { DUMMY_CLK(NULL, "pxa26x-gpio", "osc_32_768khz"), DUMMY_CLK("GPIO11_CLK", NULL, "osc_3_6864mhz"), DUMMY_CLK("GPIO12_CLK", NULL, "osc_32_768khz"), - DUMMY_CLK("sa1100-rtc", NULL, "osc_32_768khz"), + DUMMY_CLK(NULL, "sa1100-rtc", "osc_32_768khz"), DUMMY_CLK("OSTIMER0", NULL, "osc_32_768khz"), + DUMMY_CLK("UARTCLK", "pxa2xx-ir", "STUART"), }; static void __init pxa25x_dummy_clocks_init(void) -- 2.1.0