| Message ID | 87obfl60x7.fsf@linaro.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hi, On Fri, Feb 15, 2013 at 07:40:04AM -0800, Kevin Hilman wrote: > Felipe Balbi <balbi@ti.com> writes: > > > Currently the omap-serial driver will not > > work properly if booted via DT with CPUIDLE > > enabled because it depends on function pointers > > provided by hwmod to change its own SYSCONFIG > > register. > > > > Remove that relyance on hwmod by moving SYSCONFIG > > handling to driver itself. Note that this also > > fixes a possible corner case bug where we could > > be putting UART in Force Idle mode if we called > > omap_serial_enable_wakeup(up, false) after setting > > NOIDLE to the idle mode. This is because hwmod > > has no protection against that situation. > > > > NYET-Signed-off-by: Felipe Balbi <balbi@ti.com> > > Here's another approach to getting rid of the sysconfig twiddling in the > driver. I wrote this some time ago at my former company ;) but don't > think I ever got around to posting it. > > It doesn't solve the whole problem (e.g. doesn't address the > context_loss or enable_wakeup func pointers), but at least gets rid of > the need for any SYSCONFIG access in the driver for the idle modes. wakeup is still done by setting smart_idle_wakeup right, at least to some IPs. Following omap_serial_enable_wakeup() calls, I can see that it turns out to fiddle with sysconfig ;-) > @@ -229,8 +209,6 @@ static void serial_omap_stop_tx(struct uart_port *port) > serial_out(up, UART_IER, up->ier); > } > > - serial_omap_set_forceidle(up); > - > pm_runtime_mark_last_busy(up->dev); > pm_runtime_put_autosuspend(up->dev); > } > @@ -298,7 +276,6 @@ static void serial_omap_start_tx(struct uart_port *port) > > pm_runtime_get_sync(up->dev); > serial_omap_enable_ier_thri(up); > - serial_omap_set_noidle(up); this is no different then the patches Santosh has sent just a few minutes ago, what gives ? It's exactly the same patch... Anyway, I have exposed a problem with this aproach.
On Friday 15 February 2013 09:10 PM, Kevin Hilman wrote: > Felipe Balbi <balbi@ti.com> writes: > >> Currently the omap-serial driver will not >> work properly if booted via DT with CPUIDLE >> enabled because it depends on function pointers >> provided by hwmod to change its own SYSCONFIG >> register. >> >> Remove that relyance on hwmod by moving SYSCONFIG >> handling to driver itself. Note that this also >> fixes a possible corner case bug where we could >> be putting UART in Force Idle mode if we called >> omap_serial_enable_wakeup(up, false) after setting >> NOIDLE to the idle mode. This is because hwmod >> has no protection against that situation. >> >> NYET-Signed-off-by: Felipe Balbi <balbi@ti.com> > > Here's another approach to getting rid of the sysconfig twiddling in the > driver. I wrote this some time ago at my former company ;) but don't > think I ever got around to posting it. > > It doesn't solve the whole problem (e.g. doesn't address the > context_loss or enable_wakeup func pointers), but at least gets rid of > the need for any SYSCONFIG access in the driver for the idle modes. > > Needs more thorough testing. > I posted similar patch series[1] yesterday after testing it on OMAP4/5 devices. OMAP3 testing seems to be ok as well. AM3XXX and OMAP2 test results is what am waiting for. Good to know that you had similar idea in mind to get rid of UART sysc hackery. Regards, Santosh [1] http://www.mail-archive.com/linux-omap@vger.kernel.org/msg85177.html
Santosh Shilimkar <santosh.shilimkar@ti.com> writes: > On Friday 15 February 2013 09:10 PM, Kevin Hilman wrote: >> Felipe Balbi <balbi@ti.com> writes: >> >>> Currently the omap-serial driver will not >>> work properly if booted via DT with CPUIDLE >>> enabled because it depends on function pointers >>> provided by hwmod to change its own SYSCONFIG >>> register. >>> >>> Remove that relyance on hwmod by moving SYSCONFIG >>> handling to driver itself. Note that this also >>> fixes a possible corner case bug where we could >>> be putting UART in Force Idle mode if we called >>> omap_serial_enable_wakeup(up, false) after setting >>> NOIDLE to the idle mode. This is because hwmod >>> has no protection against that situation. >>> >>> NYET-Signed-off-by: Felipe Balbi <balbi@ti.com> >> >> Here's another approach to getting rid of the sysconfig twiddling in the >> driver. I wrote this some time ago at my former company ;) but don't >> think I ever got around to posting it. >> >> It doesn't solve the whole problem (e.g. doesn't address the >> context_loss or enable_wakeup func pointers), but at least gets rid of >> the need for any SYSCONFIG access in the driver for the idle modes. >> >> Needs more thorough testing. >> > I posted similar patch series[1] yesterday after testing it on OMAP4/5 > devices. OMAP3 testing seems to be ok as well. AM3XXX and OMAP2 test > results is what am waiting for. Yeah, I saw yours after I posted mine. Just continue with yours, I'll be glad to have someone else take this on. > Good to know that you had similar idea in mind to get rid of > UART sysc hackery. Likewise. Kevin
diff --git a/arch/arm/mach-omap2/omap_hwmod_2xxx_ipblock_data.c b/arch/arm/mach-omap2/omap_hwmod_2xxx_ipblock_data.c index bd9220e..0d3c1a6 100644 --- a/arch/arm/mach-omap2/omap_hwmod_2xxx_ipblock_data.c +++ b/arch/arm/mach-omap2/omap_hwmod_2xxx_ipblock_data.c @@ -509,6 +509,7 @@ struct omap_hwmod omap2xxx_uart1_hwmod = { }, }, .class = &omap2_uart_class, + .flags = HWMOD_SWSUP_SIDLE, }; /* UART2 */ @@ -528,6 +529,7 @@ struct omap_hwmod omap2xxx_uart2_hwmod = { }, }, .class = &omap2_uart_class, + .flags = HWMOD_SWSUP_SIDLE, }; /* UART3 */ @@ -547,6 +549,7 @@ struct omap_hwmod omap2xxx_uart3_hwmod = { }, }, .class = &omap2_uart_class, + .flags = HWMOD_SWSUP_SIDLE, }; /* dss */ diff --git a/arch/arm/mach-omap2/omap_hwmod_33xx_data.c b/arch/arm/mach-omap2/omap_hwmod_33xx_data.c index 59d5c1c..1a41f93 100644 --- a/arch/arm/mach-omap2/omap_hwmod_33xx_data.c +++ b/arch/arm/mach-omap2/omap_hwmod_33xx_data.c @@ -1903,6 +1903,7 @@ static struct omap_hwmod am33xx_uart1_hwmod = { .modulemode = MODULEMODE_SWCTRL, }, }, + .flags = HWMOD_SWSUP_SIDLE, }; static struct omap_hwmod_irq_info am33xx_uart2_irqs[] = { @@ -1923,6 +1924,7 @@ static struct omap_hwmod am33xx_uart2_hwmod = { .modulemode = MODULEMODE_SWCTRL, }, }, + .flags = HWMOD_SWSUP_SIDLE, }; /* uart3 */ @@ -1950,6 +1952,7 @@ static struct omap_hwmod am33xx_uart3_hwmod = { .modulemode = MODULEMODE_SWCTRL, }, }, + .flags = HWMOD_SWSUP_SIDLE, }; static struct omap_hwmod_irq_info am33xx_uart4_irqs[] = { @@ -1970,6 +1973,7 @@ static struct omap_hwmod am33xx_uart4_hwmod = { .modulemode = MODULEMODE_SWCTRL, }, }, + .flags = HWMOD_SWSUP_SIDLE, }; static struct omap_hwmod_irq_info am33xx_uart5_irqs[] = { diff --git a/arch/arm/mach-omap2/omap_hwmod_3xxx_data.c b/arch/arm/mach-omap2/omap_hwmod_3xxx_data.c index f67b7ee..99ada6a 100644 --- a/arch/arm/mach-omap2/omap_hwmod_3xxx_data.c +++ b/arch/arm/mach-omap2/omap_hwmod_3xxx_data.c @@ -497,6 +497,7 @@ static struct omap_hwmod omap3xxx_uart1_hwmod = { }, }, .class = &omap2_uart_class, + .flags = HWMOD_SWSUP_SIDLE, }; /* UART2 */ @@ -515,6 +516,7 @@ static struct omap_hwmod omap3xxx_uart2_hwmod = { }, }, .class = &omap2_uart_class, + .flags = HWMOD_SWSUP_SIDLE, }; /* UART3 */ @@ -533,6 +535,7 @@ static struct omap_hwmod omap3xxx_uart3_hwmod = { }, }, .class = &omap2_uart_class, + .flags = HWMOD_SWSUP_SIDLE, }; /* UART4 */ @@ -562,6 +565,7 @@ static struct omap_hwmod omap36xx_uart4_hwmod = { }, }, .class = &omap2_uart_class, + .flags = HWMOD_SWSUP_SIDLE, }; static struct omap_hwmod_irq_info am35xx_uart4_mpu_irqs[] = { diff --git a/arch/arm/mach-omap2/omap_hwmod_44xx_data.c b/arch/arm/mach-omap2/omap_hwmod_44xx_data.c index 652d028..5373e58 100644 --- a/arch/arm/mach-omap2/omap_hwmod_44xx_data.c +++ b/arch/arm/mach-omap2/omap_hwmod_44xx_data.c @@ -3397,6 +3397,7 @@ static struct omap_hwmod omap44xx_uart1_hwmod = { .modulemode = MODULEMODE_SWCTRL, }, }, + .flags = HWMOD_SWSUP_SIDLE, }; /* uart2 */ @@ -3425,6 +3426,7 @@ static struct omap_hwmod omap44xx_uart2_hwmod = { .modulemode = MODULEMODE_SWCTRL, }, }, + .flags = HWMOD_SWSUP_SIDLE, }; /* uart3 */ @@ -3454,6 +3456,7 @@ static struct omap_hwmod omap44xx_uart3_hwmod = { .modulemode = MODULEMODE_SWCTRL, }, }, + .flags = HWMOD_SWSUP_SIDLE, }; /* uart4 */ @@ -3482,6 +3485,7 @@ static struct omap_hwmod omap44xx_uart4_hwmod = { .modulemode = MODULEMODE_SWCTRL, }, }, + .flags = HWMOD_SWSUP_SIDLE, }; /* diff --git a/arch/arm/mach-omap2/serial.c b/arch/arm/mach-omap2/serial.c index a507cd6..e9d69a9 100644 --- a/arch/arm/mach-omap2/serial.c +++ b/arch/arm/mach-omap2/serial.c @@ -94,39 +94,6 @@ static void omap_uart_enable_wakeup(struct device *dev, bool enable) else omap_hwmod_disable_wakeup(od->hwmods[0]); } - -/* - * Errata i291: [UART]:Cannot Acknowledge Idle Requests - * in Smartidle Mode When Configured for DMA Operations. - * WA: configure uart in force idle mode. - */ -static void omap_uart_set_noidle(struct device *dev) -{ - struct platform_device *pdev = to_platform_device(dev); - struct omap_device *od = to_omap_device(pdev); - - omap_hwmod_set_slave_idlemode(od->hwmods[0], HWMOD_IDLEMODE_NO); -} - -static void omap_uart_set_smartidle(struct device *dev) -{ - struct platform_device *pdev = to_platform_device(dev); - struct omap_device *od = to_omap_device(pdev); - u8 idlemode; - - if (od->hwmods[0]->class->sysc->idlemodes & SIDLE_SMART_WKUP) - idlemode = HWMOD_IDLEMODE_SMART_WKUP; - else - idlemode = HWMOD_IDLEMODE_SMART; - - omap_hwmod_set_slave_idlemode(od->hwmods[0], idlemode); -} - -#else -static void omap_uart_enable_wakeup(struct device *dev, bool enable) -{} -static void omap_uart_set_noidle(struct device *dev) {} -static void omap_uart_set_smartidle(struct device *dev) {} #endif /* CONFIG_PM */ #ifdef CONFIG_OMAP_MUX @@ -299,8 +266,6 @@ void __init omap_serial_init_port(struct omap_board_data *bdata, omap_up.uartclk = OMAP24XX_BASE_BAUD * 16; omap_up.flags = UPF_BOOT_AUTOCONF; omap_up.get_context_loss_count = omap_pm_get_dev_context_loss_count; - omap_up.set_forceidle = omap_uart_set_smartidle; - omap_up.set_noidle = omap_uart_set_noidle; omap_up.enable_wakeup = omap_uart_enable_wakeup; omap_up.dma_rx_buf_size = info->dma_rx_buf_size; omap_up.dma_rx_timeout = info->dma_rx_timeout; diff --git a/arch/arm/plat-omap/include/plat/omap-serial.h b/arch/arm/plat-omap/include/plat/omap-serial.h index 1957a85..b9a712c 100644 --- a/arch/arm/plat-omap/include/plat/omap-serial.h +++ b/arch/arm/plat-omap/include/plat/omap-serial.h @@ -72,8 +72,6 @@ struct omap_uart_port_info { int DTR_present; int (*get_context_loss_count)(struct device *); - void (*set_forceidle)(struct device *); - void (*set_noidle)(struct device *); void (*enable_wakeup)(struct device *, bool); }; diff --git a/drivers/tty/serial/omap-serial.c b/drivers/tty/serial/omap-serial.c index 6d3d26a..8e4e39f 100644 --- a/drivers/tty/serial/omap-serial.c +++ b/drivers/tty/serial/omap-serial.c @@ -151,26 +151,6 @@ static int serial_omap_get_context_loss_count(struct uart_omap_port *up) return pdata->get_context_loss_count(up->dev); } -static void serial_omap_set_forceidle(struct uart_omap_port *up) -{ - struct omap_uart_port_info *pdata = up->dev->platform_data; - - if (!pdata || !pdata->set_forceidle) - return; - - pdata->set_forceidle(up->dev); -} - -static void serial_omap_set_noidle(struct uart_omap_port *up) -{ - struct omap_uart_port_info *pdata = up->dev->platform_data; - - if (!pdata || !pdata->set_noidle) - return; - - pdata->set_noidle(up->dev); -} - static void serial_omap_enable_wakeup(struct uart_omap_port *up, bool enable) { struct omap_uart_port_info *pdata = up->dev->platform_data; @@ -229,8 +209,6 @@ static void serial_omap_stop_tx(struct uart_port *port) serial_out(up, UART_IER, up->ier); } - serial_omap_set_forceidle(up); - pm_runtime_mark_last_busy(up->dev); pm_runtime_put_autosuspend(up->dev); } @@ -298,7 +276,6 @@ static void serial_omap_start_tx(struct uart_port *port) pm_runtime_get_sync(up->dev); serial_omap_enable_ier_thri(up); - serial_omap_set_noidle(up); pm_runtime_mark_last_busy(up->dev); pm_runtime_put_autosuspend(up->dev); }