From patchwork Tue Oct 7 19:33:56 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Robert Jarzmik X-Patchwork-Id: 5048731 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id A5FB2C11AB for ; Tue, 7 Oct 2014 19:36:43 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id A356E201FB for ; Tue, 7 Oct 2014 19:36:42 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 84D0E201F7 for ; Tue, 7 Oct 2014 19:36:41 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1XbaWm-00035i-5H; Tue, 07 Oct 2014 19:34:32 +0000 Received: from smtp05.smtpout.orange.fr ([80.12.242.127] helo=smtp.smtpout.orange.fr) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1XbaWh-00032t-Pa for linux-arm-kernel@lists.infradead.org; Tue, 07 Oct 2014 19:34:29 +0000 Received: from beldin ([90.16.80.99]) by mwinf5d62 with ME id 0KZx1p00728ZqxW03KZxsY; Tue, 07 Oct 2014 21:34:04 +0200 X-ME-Helo: beldin X-ME-Date: Tue, 07 Oct 2014 21:34:04 +0200 X-ME-IP: 90.16.80.99 From: Robert Jarzmik To: Arnd Bergmann Subject: Re: [PATCH] Revert "ARM: pxa: call debug_ll_io_init for earlyprintk" References: <1412602320-22896-1-git-send-email-dbaryshkov@gmail.com> <6310030.SmNYckCtJ4@wuerfel> <871tqkc1pn.fsf@free.fr> <7809732.cy12qq1fce@wuerfel> X-URL: http://belgarath.falguerolles.org/ Date: Tue, 07 Oct 2014 21:33:56 +0200 In-Reply-To: <7809732.cy12qq1fce@wuerfel> (Arnd Bergmann's message of "Tue, 07 Oct 2014 11:18:32 +0200") Message-ID: <87siizad3v.fsf@free.fr> User-Agent: Gnus/5.130008 (Ma Gnus v0.8) Emacs/24.3.92 (gnu/linux) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20141007_123428_351688_5AB44C99 X-CRM114-Status: GOOD ( 22.19 ) X-Spam-Score: 0.0 (/) Cc: Eric Miao , Dmitry Eremin-Solenikov , stable@vger.kernel.org, Haojian Zhuang , Russell King , Andrew Ruder , linux-arm-kernel@lists.infradead.org X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Arnd Bergmann writes: > > Can't you just define CONFIG_DEBUG_UART_VIRT outside of the existing > mappings? It doesn't have to use the same mapping as PERIPH_PHYS. > > Arnd Yep, that looks better. Would something like that be appropriate ? I tested that on pxa27x, but not on pxa25x, even if there seems to be no reason it wouldn't work for it too ... And I have not yet thought over if there is any impact on vmalloc memory or if the double virtual mapping can trigger something bad. Cheers. Acked-by: Arnd Bergmann diff --git a/arch/arm/Kconfig.debug b/arch/arm/Kconfig.debug index b11ad54..2f78e54 100644 --- a/arch/arm/Kconfig.debug +++ b/arch/arm/Kconfig.debug @@ -1142,7 +1142,7 @@ config DEBUG_UART_VIRT default 0xf1c28000 if DEBUG_SUNXI_UART0 default 0xf1c28400 if DEBUG_SUNXI_UART1 default 0xf1f02800 if DEBUG_SUNXI_R_UART - default 0xf2100000 if DEBUG_PXA_UART1 + default 0xf6200000 if DEBUG_PXA_UART1 default 0xf4090000 if ARCH_LPC32XX default 0xf4200000 if ARCH_GEMINI default 0xf7000000 if DEBUG_S3C24XX_UART && (DEBUG_S3C_UART0 || \ diff --git a/arch/arm/mach-pxa/include/mach/addr-map.h b/arch/arm/mach-pxa/include/mach/addr-map.h index bbf9df3..d28fe29 100644 --- a/arch/arm/mach-pxa/include/mach/addr-map.h +++ b/arch/arm/mach-pxa/include/mach/addr-map.h @@ -39,6 +39,11 @@ #define DMEMC_SIZE 0x00100000 /* + * Reserved space for low level debug virtual addresses within + * 0xf6200000..0xf6201000 + */ + +/* * Internal Memory Controller (PXA27x and later) */ #define IMEMC_PHYS 0x58000000