[2/2] pwm: bcm2835: Drop open coded variant of devm_clk_rate_exclusive_get()

Commit Message

Uwe Kleine-König March 10, 2024, 1:47 p.m. UTC

Since commit b0cde62e4c54 ("clk: Add a devm variant of
clk_rate_exclusive_get()") the clk subsystem provides
devm_clk_rate_exclusive_get(). Replace the open coded implementation by
the new function.

Signed-off-by: Uwe Kleine-König <[e-mail]>
---
 drivers/pwm/pwm-bcm2835.c | 14 +-------------
 1 file changed, 1 insertion(+), 13 deletions(-)

Comments

Florian Fainelli March 12, 2024, 1:48 p.m. UTC | #1

On 3/10/2024 6:47 AM, Uwe Kleine-König wrote:
> Since commit b0cde62e4c54 ("clk: Add a devm variant of
> clk_rate_exclusive_get()") the clk subsystem provides
> devm_clk_rate_exclusive_get(). Replace the open coded implementation by
> the new function.
> 
> Signed-off-by: Uwe Kleine-König <[e-mail]>

Reviewed-by: Florian Fainelli <[e-mail]>

Patch

diff --git a/drivers/pwm/pwm-bcm2835.c b/drivers/pwm/pwm-bcm2835.c
index 3d0c089c9ef0..578e95e0296c 100644
--- a/drivers/pwm/pwm-bcm2835.c
+++ b/drivers/pwm/pwm-bcm2835.c
@@ -124,13 +124,6 @@  static const struct pwm_ops bcm2835_pwm_ops = {
 	.apply = bcm2835_pwm_apply,
 };
 
-static void devm_clk_rate_exclusive_put(void *data)
-{
-	struct clk *clk = data;
-
-	clk_rate_exclusive_put(clk);
-}
-
 static int bcm2835_pwm_probe(struct platform_device *pdev)
 {
 	struct device *dev = &pdev->dev;
@@ -152,16 +145,11 @@  static int bcm2835_pwm_probe(struct platform_device *pdev)
 		return dev_err_probe(dev, PTR_ERR(pc->clk),
 				     "clock not found\n");
 
-	ret = clk_rate_exclusive_get(pc->clk);
+	ret = devm_clk_rate_exclusive_get(dev, pc->clk);
 	if (ret)
 		return dev_err_probe(dev, ret,
 				     "fail to get exclusive rate\n");
 
-	ret = devm_add_action_or_reset(dev, devm_clk_rate_exclusive_put,
-				       pc->clk);
-	if (ret)
-		return ret;
-
 	pc->rate = clk_get_rate(pc->clk);
 	if (!pc->rate)
 		return dev_err_probe(dev, -EINVAL,