| Message ID | 925cebbe4eb73c7d0a536da204748d33c7100d8c.1624448778.git.michal.simek@xilinx.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | reset: reset-zynqmp: Fixed the argument data type | expand |
Hi Philipp, st 23. 6. 2021 v 13:46 odesÃlatel Michal Simek <michal.simek@xilinx.com> napsal: > > From: Sai Krishna Potthuri <lakshmi.sai.krishna.potthuri@xilinx.com> > > This patch changes the data type of the variable 'val' from > int to u32. > > Addresses-Coverity: argument of type "int *" is incompatible with parameter of type "u32 *" > Signed-off-by: Sai Krishna Potthuri <lakshmi.sai.krishna.potthuri@xilinx.com> > Signed-off-by: Michal Simek <michal.simek@xilinx.com> > --- > > drivers/reset/reset-zynqmp.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/reset/reset-zynqmp.c b/drivers/reset/reset-zynqmp.c > index daa425e74c96..59dc0ff9af9e 100644 > --- a/drivers/reset/reset-zynqmp.c > +++ b/drivers/reset/reset-zynqmp.c > @@ -53,7 +53,8 @@ static int zynqmp_reset_status(struct reset_controller_dev *rcdev, > unsigned long id) > { > struct zynqmp_reset_data *priv = to_zynqmp_reset_data(rcdev); > - int val, err; > + int err; > + u32 val; > > err = zynqmp_pm_reset_get_status(priv->data->reset_id + id, &val); > if (err) > -- > 2.32.0 > Can you please take a look at this patch? Thanks, Michal
On Wed, 23 Jun 2021 13:46:20 +0200, Michal Simek wrote: > From: Sai Krishna Potthuri <lakshmi.sai.krishna.potthuri@xilinx.com> > > This patch changes the data type of the variable 'val' from > int to u32. > > Signed-off-by: Sai Krishna Potthuri <lakshmi.sai.krishna.potthuri@xilinx.com> > Signed-off-by: Michal Simek <michal.simek@xilinx.com> > Addresses-Coverity: argument of type "int *" is incompatible with parameter of type "u32 *" > --- > > drivers/reset/reset-zynqmp.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/reset/reset-zynqmp.c b/drivers/reset/reset-zynqmp.c > index daa425e74c96..59dc0ff9af9e 100644 > --- a/drivers/reset/reset-zynqmp.c > +++ b/drivers/reset/reset-zynqmp.c > @@ -53,7 +53,8 @@ static int zynqmp_reset_status(struct reset_controller_dev *rcdev, > unsigned long id) > { > struct zynqmp_reset_data *priv = to_zynqmp_reset_data(rcdev); > - int val, err; > + int err; > + u32 val; The function returns val as int instead of u32. While this shouldn't be a problem in this case, maybe there should be an additional check just to be sure? Michael > > err = zynqmp_pm_reset_get_status(priv->data->reset_id + id, &val); > if (err) > -- > 2.32.0
On 8/11/21 12:36 PM, Michael Tretter wrote: > On Wed, 23 Jun 2021 13:46:20 +0200, Michal Simek wrote: >> From: Sai Krishna Potthuri <lakshmi.sai.krishna.potthuri@xilinx.com> >> >> This patch changes the data type of the variable 'val' from >> int to u32. >> >> Signed-off-by: Sai Krishna Potthuri <lakshmi.sai.krishna.potthuri@xilinx.com> >> Signed-off-by: Michal Simek <michal.simek@xilinx.com> >> Addresses-Coverity: argument of type "int *" is incompatible with parameter of type "u32 *" >> --- >> >> drivers/reset/reset-zynqmp.c | 3 ++- >> 1 file changed, 2 insertions(+), 1 deletion(-) >> >> diff --git a/drivers/reset/reset-zynqmp.c b/drivers/reset/reset-zynqmp.c >> index daa425e74c96..59dc0ff9af9e 100644 >> --- a/drivers/reset/reset-zynqmp.c >> +++ b/drivers/reset/reset-zynqmp.c >> @@ -53,7 +53,8 @@ static int zynqmp_reset_status(struct reset_controller_dev *rcdev, >> unsigned long id) >> { >> struct zynqmp_reset_data *priv = to_zynqmp_reset_data(rcdev); >> - int val, err; >> + int err; >> + u32 val; > > The function returns val as int instead of u32. While this shouldn't be a > problem in this case, maybe there should be an additional check just to be > sure? As far as I can tell coverity is not reporting any issue around it. And when I look at internal of that function in firmware this function in case of success returns only 0 or 1 that's why I don't think we need to do anything with it. Thanks, Michal
Hi Michal, On Wed, 2021-06-23 at 13:46 +0200, Michal Simek wrote: > From: Sai Krishna Potthuri <lakshmi.sai.krishna.potthuri@xilinx.com> > > This patch changes the data type of the variable 'val' from > int to u32. > > Addresses-Coverity: argument of type "int *" is incompatible with parameter of type "u32 *" > Signed-off-by: Sai Krishna Potthuri <lakshmi.sai.krishna.potthuri@xilinx.com> > Signed-off-by: Michal Simek <michal.simek@xilinx.com> > --- > > drivers/reset/reset-zynqmp.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/reset/reset-zynqmp.c b/drivers/reset/reset-zynqmp.c > index daa425e74c96..59dc0ff9af9e 100644 > --- a/drivers/reset/reset-zynqmp.c > +++ b/drivers/reset/reset-zynqmp.c > @@ -53,7 +53,8 @@ static int zynqmp_reset_status(struct reset_controller_dev *rcdev, > unsigned long id) > { > struct zynqmp_reset_data *priv = to_zynqmp_reset_data(rcdev); > - int val, err; > + int err; > + u32 val; > > err = zynqmp_pm_reset_get_status(priv->data->reset_id + id, &val); > if (err) Thank you, applied to reset/fixes. regards Philipp
diff --git a/drivers/reset/reset-zynqmp.c b/drivers/reset/reset-zynqmp.c index daa425e74c96..59dc0ff9af9e 100644 --- a/drivers/reset/reset-zynqmp.c +++ b/drivers/reset/reset-zynqmp.c @@ -53,7 +53,8 @@ static int zynqmp_reset_status(struct reset_controller_dev *rcdev, unsigned long id) { struct zynqmp_reset_data *priv = to_zynqmp_reset_data(rcdev); - int val, err; + int err; + u32 val; err = zynqmp_pm_reset_get_status(priv->data->reset_id + id, &val); if (err)