From patchwork Wed Jun 9 01:31:08 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: William Breathitt Gray X-Patchwork-Id: 12308639 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C0984C48BCD for ; Wed, 9 Jun 2021 01:44:17 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8332061182 for ; Wed, 9 Jun 2021 01:44:17 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8332061182 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=h6kkn9zLbrRoHLo16HiEhuHDTuUUNwFEWWA13/23xKE=; b=FPYGX+LPfhzsI6 cqp+f78gzyaQglK0J/QpEcrSiID6eqWljLDGufMEXvH0bM24wXpbc4Ut5EtcSN/tx2+y2RR5C8PvN hyU68lzKSS2BqjtNS88d+l4eniqvBqSXN2vh9kQV0XGGmmUnNkF5EJGPAPYtdUxeO78P4rY4ER7X0 o3nk/8gxceU/Vbb7TCjK/1K66vwvggbWnbmM508IaqCOaNHKrJrYIxIVAFVpi+R6VIbr2B3lPcilY 4LKFapbgHCACMEybY5TI+40Bvs3vRYJHXfvsP+FIRO5dInJyGNM9lGwA0jH0lQYZE7dlg4nK/Jj0Q poqiVGXwhB/WWyFNVCiQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lqnCG-00BBtT-Ls; Wed, 09 Jun 2021 01:39:57 +0000 Received: from mail-pj1-f42.google.com ([209.85.216.42]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1lqn5n-00B91P-Iv for linux-arm-kernel@lists.infradead.org; Wed, 09 Jun 2021 01:33:16 +0000 Received: by mail-pj1-f42.google.com with SMTP id md2-20020a17090b23c2b029016de4440381so417450pjb.1 for ; Tue, 08 Jun 2021 18:33:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=53F3JLy2efE/MBSv+u+hdtt2UsFBNaGfSp4/xOndCJw=; b=m8NgwwBQVj+jiOSgp/qosMdniUSNKbEihuaHW84YK4n9ISHj3p6eAH3wIijol8CUmh k3wtBdLYgwJCdaFrYTPzeEsfQEkRAAIloFRJ0Sx/vYTGIY+B/zxkUMh19sS9ieeAqE2n sj0F+OZvJC5hhI2EM6bvsroDIrY3Auoz3JZyWzpzuc+HciWeuIcXFSe7YGclcC3ESDNk pnzjomO6GPuXSgUii5ZNOBSo1wDYmz06NRFK7KEI40Lv51VGF4mhD1t624cUaenHvZrw 0GH3TSRk2/IW6oYUsVIxopQoUUKkXYvBGnNVSgFQ75Bd58+NsUu8byQp3tFnbnwYsGMz O20w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=53F3JLy2efE/MBSv+u+hdtt2UsFBNaGfSp4/xOndCJw=; b=FLTRiBXcUnhR5PxkIFuwGnxEsT0Tr9Gl1nV1YiXlOTJh0Wa3NI9g14HdMekYSWdSEZ 6ehNPGhBAchwxGJX3DruZaaT757tOK37LZpgjpKi567O2N0T7D8NzLeIb+nHvQUFo/Kb ydeVdM2On1eii27J1nhhfA/dnTP66kn+/BT3qfJokGqa5Pe7qpnsHal/UDwmmZaPV2Ii aS0whE7gP/mSccALXRSg0Pzhnzoi9vg/davZKIP4b2Gi3ZDRy6/QS8PWu4soNer6oiSg djU8Mt84oL0K695bLO8ioG4IMzOqDH8iJCBo98xTKvXQcM96E+nuV1mhc20xwJyD2aU3 RRcw== X-Gm-Message-State: AOAM532ui+g1kX08f+5yman8sUzh1aGudvfUIgMa/hZ4yzG0s76ZwqFW KOzb6I7bMyipbHM470SiW1A= X-Google-Smtp-Source: ABdhPJxlALKo8z10rInZn6MEjc+0Tt+aSv/JtpP5OOw76asrvljiGTcoZp64CRIKQeDsuyxCbelwOA== X-Received: by 2002:a17:90b:1888:: with SMTP id mn8mr8046509pjb.179.1623202334944; Tue, 08 Jun 2021 18:32:14 -0700 (PDT) Received: from localhost.localdomain ([156.146.35.76]) by smtp.gmail.com with ESMTPSA id v14sm12659815pgl.86.2021.06.08.18.32.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Jun 2021 18:32:14 -0700 (PDT) From: William Breathitt Gray To: jic23@kernel.org Cc: linux-stm32@st-md-mailman.stormreply.com, kernel@pengutronix.de, a.fatoum@pengutronix.de, kamel.bouhara@bootlin.com, gwendal@chromium.org, alexandre.belloni@bootlin.com, david@lechnology.com, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, syednwaris@gmail.com, patrick.havelange@essensium.com, fabrice.gasnier@st.com, mcoquelin.stm32@gmail.com, alexandre.torgue@st.com, o.rempel@pengutronix.de, jarkko.nikula@linux.intel.com, William Breathitt Gray Subject: [PATCH v11 05/33] counter: 104-quad-8: Annotate hardware config module parameter Date: Wed, 9 Jun 2021 10:31:08 +0900 Message-Id: <97ce79878a26809f0b15b2eac9a86ca39e0ecd74.1623201081.git.vilhelm.gray@gmail.com> X-Mailer: git-send-email 2.32.0 In-Reply-To: References: MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210608_183315_655773_41AF0063 X-CRM114-Status: GOOD ( 18.99 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org When the kernel is running in secure boot mode, we lock down the kernel to prevent userspace from modifying the running kernel image. Whilst this includes prohibiting access to things like /dev/mem, it must also prevent access by means of configuring driver modules in such a way as to cause a device to access or modify the kernel image. To this end, annotate module_param* statements that refer to hardware configuration and indicate for future reference what type of parameter they specify. The parameter parser in the core sees this information and can skip such parameters with an error message if the kernel is locked down. The module initialisation then runs as normal, but just sees whatever the default values for those parameters is. Note that we do still need to do the module initialisation because some drivers have viable defaults set in case parameters aren't specified and some drivers support automatic configuration (e.g. PNP or PCI) in addition to manually coded parameters. This patch annotates the 104-QUAD-8 driver. Acked-by: Syed Nayyar Waris Signed-off-by: William Breathitt Gray --- drivers/counter/104-quad-8.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/counter/104-quad-8.c b/drivers/counter/104-quad-8.c index 233a3acc1377..0fd61cc82d30 100644 --- a/drivers/counter/104-quad-8.c +++ b/drivers/counter/104-quad-8.c @@ -21,7 +21,7 @@ static unsigned int base[max_num_isa_dev(QUAD8_EXTENT)]; static unsigned int num_quad8; -module_param_array(base, uint, &num_quad8, 0); +module_param_hw_array(base, uint, ioport, &num_quad8, 0); MODULE_PARM_DESC(base, "ACCES 104-QUAD-8 base addresses"); #define QUAD8_NUM_COUNTERS 8