From patchwork Fri Sep 6 08:51:01 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Koen Kooi X-Patchwork-Id: 2854445 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id AD8E9C0AB5 for ; Fri, 6 Sep 2013 08:57:31 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 5970620290 for ; Fri, 6 Sep 2013 08:57:30 +0000 (UTC) Received: from casper.infradead.org (casper.infradead.org [85.118.1.10]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 283D12028D for ; Fri, 6 Sep 2013 08:57:29 +0000 (UTC) Received: from merlin.infradead.org ([2001:4978:20e::2]) by casper.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1VHrqw-0005iT-6u; Fri, 06 Sep 2013 08:57:18 +0000 Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1VHrqq-0002ZC-MC; Fri, 06 Sep 2013 08:57:12 +0000 Received: from mail-we0-f170.google.com ([74.125.82.170]) by merlin.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1VHrqo-0002Yk-Bf for linux-arm-kernel@lists.infradead.org; Fri, 06 Sep 2013 08:57:11 +0000 Received: by mail-we0-f170.google.com with SMTP id w62so1620717wes.1 for ; Fri, 06 Sep 2013 01:56:48 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:content-type:mime-version:subject:from :in-reply-to:date:cc:content-transfer-encoding:message-id:references :to; bh=J0jSqtjRSGdudrBq6mrhoE9Sko+pNk/WfT0VAqDZzMg=; b=B3oKb3J0az42vQFNCkvOdCvbAyHqRrQnogOX42/M16c/FZWTdRn2rQubvnpKiowwiO AI8PRi025BMNuOtbs9koC5zDXvL8HqG1jkaEoPCjHOcPqPMAu4kuM4p+RAs8Vje/Upld 0svviAboNVBfZyfAgCqnHLa/ITW17SwC4LxCQfbjLAMSluiGkakkC/60mUzf8MPaKOJE CzW0xyzsCLOgIsdFI3Xn0tSRkZ6FofCCybCYYgJNfcNZxSGFgmsBe+7JMFvfi1HtTejJ RZPORhcrQlRD//TAUgtlO12JijveWXo6g9bokTNqdscbGUPPn363TuOdqKhH75hwBBvD zHSg== X-Gm-Message-State: ALoCoQmpmysSm30PIetDM0pT3CaMPiTp3sfYXYPEz3HENNVO0Rni/QS6Z21TyKVE0PqlkFSX6hIq X-Received: by 10.194.22.97 with SMTP id c1mr678429wjf.43.1378457462076; Fri, 06 Sep 2013 01:51:02 -0700 (PDT) Received: from ?IPv6:2001:610:612::81be:b5b8:f0f8:396f? ([2001:610:612:0:81be:b5b8:f0f8:396f]) by mx.google.com with ESMTPSA id l9sm5424801wif.10.1969.12.31.16.00.00 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Fri, 06 Sep 2013 01:51:01 -0700 (PDT) Mime-Version: 1.0 (Mac OS X Mail 6.5 \(1508\)) Subject: Re: [PATCH] ARM: OMAP2+: am335x-bone*: add DT for BeagleBone Black From: Koen Kooi In-Reply-To: <50E637BB-5A62-477C-B943-9687BC3488BC@dominion.thruhere.net> Date: Fri, 6 Sep 2013 10:51:01 +0200 Message-Id: References: <1378449204-8601-1-git-send-email-koen@dominion.thruhere.net> <52297CCF.3090200@ti.com> <50E637BB-5A62-477C-B943-9687BC3488BC@dominion.thruhere.net> To: George Cherian X-Mailer: Apple Mail (2.1508) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20130906_045710_550160_9F44DE8F X-CRM114-Status: GOOD ( 15.25 ) X-Spam-Score: -2.6 (--) Cc: mark.rutland@arm.com, devicetree@vger.kernel.org, linux@arm.linux.org.uk, pawel.moll@arm.com, swarren@wwwdotorg.org, tony@atomide.com, ijc+devicetree@hellion.org.uk, linux-kernel@vger.kernel.org, rob.herring@calxeda.com, bcousson@baylibre.com, olof@lixom.net, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-6.6 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Op 6 sep. 2013, om 09:10 heeft Koen Kooi het volgende geschreven: > > Op 6 sep. 2013, om 08:57 heeft George Cherian het volgende geschreven: > >> On 9/6/2013 12:03 PM, Koen Kooi wrote: >>> The BeagleBone Black is basically a regular BeagleBone with eMMC and HDMI added, >>> so create a common dtsi both can use. MMC support for AM335x still isn't in, so >>> only the LDO change has been added. >>> >>> Signed-off-by: Koen Kooi >>> --- >>> .../{am335x-bone.dts => am335x-bone-common.dtsi} | 3 - >>> arch/arm/boot/dts/am335x-bone.dts | 256 +-------------------- >>> arch/arm/boot/dts/am335x-boneblack.dts | 18 ++ >>> 3 files changed, 19 insertions(+), 258 deletions(-) >>> copy arch/arm/boot/dts/{am335x-bone.dts => am335x-bone-common.dtsi} (99%) >>> create mode 100644 arch/arm/boot/dts/am335x-boneblack.dts >> How did you test am335x-boneblack.dtb? where are the Makefile changes for boneblack? > > Ah, I missed the makefile in my commit. I have a bunch of other patches on top to make more stuff work. > > [..] > >>> >>> --- /dev/null >>> +++ b/arch/arm/boot/dts/am335x-boneblack.dts >>> @@ -0,0 +1,18 @@ >>> +/* >>> + * Copyright (C) 2012 Texas Instruments Incorporated - http://www.ti.com/ >>> + * >>> + * This program is free software; you can redistribute it and/or modify >>> + * it under the terms of the GNU General Public License version 2 as >>> + * published by the Free Software Foundation. >>> + */ >>> +/dts-v1/; >>> + >>> +#include "am33xx.dtsi" >> Why cant we add am33xx.dtsi in am335x-bone-common.dtsi ? > > That didn't work when I tried it. It did work before the preprocessor changes when using /include/ > >>> +#include "am335x-bone-common.dtsi" >>> + >>> +&ldo3_reg { >>> + regulator-min-microvolt = <1800000>; >>> + regulator-max-microvolt = <1800000>; >>> + regulator-always-on; >>> +}; >>> + >> With this ldo values mmc was not working for me on Boneblack. >> got it working with >> >> &ldo3_reg { >> regulator-min-microvolt = <1800000>; >> regulator-max-microvolt = <3300000>; >> regulator-always-on; >> }; > > That LDO is shared, the other consumer will get fried if you use 3.3V. I forget if it's DDR3 or HDMI. On the black the LDOs changed, so for mmc (which (*$)@()$@) still isn't in mainline) you need: diff --git a/arch/arm/boot/dts/am335x-bone-common.dtsi b/arch/arm/boot/dts/am335x-bone-common.dtsi index e76d575..ae90a30 100644 --- a/arch/arm/boot/dts/am335x-bone-common.dtsi +++ b/arch/arm/boot/dts/am335x-bone-common.dtsi @@ -362,6 +362,13 @@ regulator-always-on; }; }; + + vmmcsd_fixed: fixedregulator@0 { + compatible = "regulator-fixed"; + regulator-name = "vmmcsd_fixed"; + regulator-min-microvolt = <3300000>; + regulator-max-microvolt = <3300000>; + }; }; &cpsw_emac0 { diff --git a/arch/arm/boot/dts/am335x-boneblack.dts b/arch/arm/boot/dts/am335x-boneblack.dts index b4237fc..e092a61 100644 --- a/arch/arm/boot/dts/am335x-boneblack.dts +++ b/arch/arm/boot/dts/am335x-boneblack.dts @@ -16,7 +16,12 @@ regulator-always-on; }; -&mmc2 { +&mmc1 { + vmmc-supply = <&vmmcsd_fixed>; +}; + +&mmc2 { + vmmc-supply = <&vmmcsd_fixed>; pinctrl-names = "default"; pinctrl-0 = <&emmc_pins>; vmmc-supply = <&ldo3_reg>;