s3c2410_udc: fix custom UDC command handling

Commit Message

Viliam Mateicka June 20, 2011, 7:05 p.m. UTC

Look. I didn't wanna spend more time with the issue because for me -
it was solved. It was just the stupid byrocratic system you've
enforced to minimize your work - which I would say its complete
non-sence if it could ever have a problem with whitespace or line
break. I understand that on the source level every character it's
important to the look of the code, but at least when you try to force
somebody to use some rules (which most of it at my copy were applied
fine just fine by myself), at least use a tool which take a care about
it (the look of the kernel code). Just look how much time it took to
upstream a little change (valid on the first look), just because of my
ignorance to some the formating rules (linebreaks and tabs namely - if
you have a proper editor which takes care about it.) and a faulty
mailer (I).

Anyway, if the Documentation/SubmittingPatches would mention git
format-patch and git send-email I would have use it and there would'nt
be any trouble using faulty mailer.  Instead as a first option there
is solution which almost everytime produces such a problems.

So many thanks, for doing your job and keeping the bad asses using
wrong tools out of the formating heaven. I could imagine that this
would be hard (to get one line into the kernel) but still haven't
thought that hard. I would like to thank you for your patience and the
exact amount of right doingness, while showing me what's wrong instead
of telling me how to do it properly.

Also liked the diff between our patches:

player tmp # diff -ur wastetime wastetime2
+                int value;

Vilo

On Mon, Jun 20, 2011 at 7:34 PM, Felipe Balbi <[e-mail]> wrote:
> Hi,
>
> On Mon, Jun 20, 2011 at 07:27:18PM +0200, Viliam Mateicka wrote:
>> I wonder then, who applies the patch first. One ass can't stop
>> progress (was there some progress afterall ?) because of one
>> line-break (which git produces by default afterall) and several
>> non-conforming whitespace conversions. I think you should stop
>> replying to me, because I'm kinda starting to like trolling afterall.
>
> Look, maybe you're just new to git/linux and that's fine. The only
> problem we had from day one is that you have been a complete dick when
> replying.
>
> If you go that road, that's what you'll get in return.
>
> Just so you see the properly formatted patch, I'm quoting below. See
> that there's no line breaks introduced by git.
>
> commit c27c9b5312f4b2a7e66ee772943355d77fc2c550
> Author: Viliam Mateicka <[e-mail]>
> Date:   Mon Jun 20 19:08:27 2011 +0300
>
>    usb: gadget: s3c2410_udc: fix custom UDC command handling
>
>    There is a bug in Samsung's UDC driver, which is
>    completely disabling the USB device when a custom
>    UDC command is used.
>
>    Following patch seems to get the right behavior
>    (e.g. enabling pull-up instead of disabling then
>    Vcc is applied).
>
>    Signed-off-by: Viliam Mateicka <[e-mail]>
>
>    [ [e-mail] : manually re-created the patch because
>        author was unable to send a proper one ]
>
>    Signed-off-by: Felipe Balbi <[e-mail]>
>
> diff --git a/drivers/usb/gadget/s3c2410_udc.c b/drivers/usb/gadget/s3c2410_udc.c
> index 100f263..b6e1ca5 100644
> --- a/drivers/usb/gadget/s3c2410_udc.c
> +++ b/drivers/usb/gadget/s3c2410_udc.c
> @@ -1567,7 +1567,7 @@ static void s3c2410_udc_command(enum s3c2410_udc_cmd_e cmd)
>                return;
>
>        if (udc_info->udc_command) {
> -               udc_info->udc_command(S3C2410_UDC_P_DISABLE);
> +               udc_info->udc_command(cmd);
>        } else if (gpio_is_valid(udc_info->pullup_pin)) {
>                int value;
>
>
> (if you see any line breaks that's your mailer, it's better to check
> from the archives [1])
>
> [1] http://marc.info/?l=linux-usb
>
> --
> balbi
>

Patch

--- wastetime	2011-06-20 20:33:25.000000000 +0200
+++ wastetime2	2011-06-20 20:30:21.000000000 +0200
@@ -2,11 +2,12 @@ 
 index 100f263..b6e1ca5 100644
 --- a/drivers/usb/gadget/s3c2410_udc.c
 +++ b/drivers/usb/gadget/s3c2410_udc.c
-@@ -1567,7 +1567,7 @@ static void s3c2410_udc_command(enum
s3c2410_udc_cmd_e cmd)
- 		return;
-
- 	if (udc_info->udc_command) {
--		udc_info->udc_command(S3C2410_UDC_P_DISABLE);
-+		udc_info->udc_command(cmd);
- 	} else if (gpio_is_valid(udc_info->pullup_pin)) {
- 		int value;
+@@ -1567,7 +1567,7 @@ static void s3c2410_udc_command(enum
+s3c2410_udc_cmd_e cmd)
+                return;
+
+        if (udc_info->udc_command) {
+-               udc_info->udc_command(S3C2410_UDC_P_DISABLE);
++               udc_info->udc_command(cmd);
+        } else if (gpio_is_valid(udc_info->pullup_pin)) {