From patchwork Tue Aug 18 16:45:44 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hartley Sweeten X-Patchwork-Id: 7032301 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 3D915C05AC for ; Tue, 18 Aug 2015 16:48:27 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 5AB7E2052A for ; Tue, 18 Aug 2015 16:48:26 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B6C00203F3 for ; Tue, 18 Aug 2015 16:48:24 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1ZRk1g-0002sn-1W; Tue, 18 Aug 2015 16:46:16 +0000 Received: from mail-by2on0148.outbound.protection.outlook.com ([207.46.100.148] helo=na01-by2-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1ZRk1d-0002nU-IF; Tue, 18 Aug 2015 16:46:14 +0000 Received: from BN3PR0101MB1057.prod.exchangelabs.com (10.160.182.21) by BN3PR0101MB1060.prod.exchangelabs.com (10.160.182.24) with Microsoft SMTP Server (TLS) id 15.1.231.21; Tue, 18 Aug 2015 16:45:45 +0000 Received: from BN3PR0101MB1057.prod.exchangelabs.com ([10.160.182.21]) by BN3PR0101MB1057.prod.exchangelabs.com ([10.160.182.21]) with mapi id 15.01.0231.024; Tue, 18 Aug 2015 16:45:44 +0000 From: Hartley Sweeten To: Pratyush Anand , "linux@roeck-us.net" Subject: RE: [PATCH V2] Watchdog: Fix parent of watchdog_devices Thread-Topic: [PATCH V2] Watchdog: Fix parent of watchdog_devices Thread-Index: AQHQ2dTCl+o9d2z1ZEuXWOBkjYCr0p4R9btg Date: Tue, 18 Aug 2015 16:45:44 +0000 Message-ID: References: <9fcc2a2cc8273f461baa13c6c9992f3ca56b508a.1439915117.git.panand@redhat.com> In-Reply-To: <9fcc2a2cc8273f461baa13c6c9992f3ca56b508a.1439915117.git.panand@redhat.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=HartleyS@visionengravers.com; x-originating-ip: [184.183.19.121] x-microsoft-exchange-diagnostics: 1; BN3PR0101MB1060; 5:VX9srtrj36N3kK9l4uLLcys3l06bTYzmlY1Xok/HsVyy2ecyhKo+shO/bla+ey+9t63e4h2inTMrGbsi+phRJDzk0aQBQs2evA6dpJ8HvzmJ1MOk/h8ydR4wNsJ9XvCg79M/rIAqD3XeXeGkbG515w==; 24:qqkdKsnQZls0kI9ZhQQLOcMi0gIO2qy1r+jSQ82mauoI6KARu3im4FajCS7ktmi35VOXDHMITENJpuKDRmlGjJ+2XMTxDUK09Mg4Dby/N9E=; 20:cR4DAXb2sDjTCmyCjLoIGm1HPaSqYHc6icyE19vGwq7D7Wayew91blmFpgRA6nuJJ0qe6CGtkkCaStY/3ebGwg== x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BN3PR0101MB1060; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8121501046)(5005006)(3002001); SRVR:BN3PR0101MB1060; BCL:0; PCL:0; RULEID:; SRVR:BN3PR0101MB1060; x-forefront-prvs: 067270ECAF x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(6009001)(24454002)(164054003)(189002)(377454003)(199003)(19580405001)(5001960100002)(77156002)(97736004)(54356999)(2900100001)(64706001)(2501003)(106356001)(10400500002)(66066001)(62966003)(87936001)(77096005)(2950100001)(5001860100001)(105586002)(81156007)(80792005)(101416001)(5001830100001)(68736005)(76176999)(102836002)(50986999)(4001540100001)(5002640100001)(189998001)(92566002)(122556002)(46102003)(106116001)(5003600100002)(5001770100001)(86362001)(2656002)(19580395003)(74316001)(33656002)(40100003); DIR:OUT; SFP:1102; SCL:1; SRVR:BN3PR0101MB1060; H:BN3PR0101MB1057.prod.exchangelabs.com; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; received-spf: None (protection.outlook.com: visionengravers.com does not designate permitted sender hosts) spamdiagnosticoutput: 1:23 spamdiagnosticmetadata: NSPM MIME-Version: 1.0 X-OriginatorOrg: visionengravers.com X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Aug 2015 16:45:44.4871 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: d698601f-af92-4269-8099-fd6f11636477 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN3PR0101MB1060 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20150818_094613_673041_5CF8D176 X-CRM114-Status: GOOD ( 12.29 ) X-Spam-Score: -1.9 (-) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Baruch Siach , Lee Jones , "open list:ARM/STI ARCHITECTURE" , Linus Walleij , Krzysztof Kozlowski , Patrice Chotard , Wim Van Sebroeck , Thierry Reding , Alexandre Courbot , "moderated list:ARM/SAMSUNG EXYNOS ARM ARCHITECTURES" , "open list:WOLFSON MICROELECTRONICS DRIVERS" , Kukjin Kim , Tomas Winkler , "linux-watchdog@vger.kernel.org" , Stephen Warren , "moderated list:BROADCOM BCM2835 ARM ARCHITECTURE" , "open list:TEGRA ARCHITECTURE SUPPORT" , "moderated list:ARM/U300 MACHINE SUPPORT" , Maxime Coquelin , Barry Song , Johannes Thumshirn , Support Opensource , Andreas Werner , Srinivas Kandagatla , "open list:INTEL MANAGEMENT ENGINE mei" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-4.6 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On Tuesday, August 18, 2015 9:34 AM, Pratyush Anand wrote: > > /sys/class/watchdog/watchdogn/device/modalias can help to identify the > driver/module for a given watchdog node. However, many wdt devices does not set > its parent and so, we do not see an entry for device in sysfs for such devices. > > This patch fixes parent of watchdog_device so that > /sys/class/watchdog/watchdogn/device is populated. > > Exceptions: booke, diag288, mpc8xxx, octeon, softdog and w83627hf -- They do not > have any parent. Not sure, how we can we identify driver for these devices. > > Signed-off-by: Pratyush Anand > --- [snip] drivers/watchdog/ep93xx_wdt.c | 1 + [snip] For ep93xx_wdt.c, use whichever tag you prefer: Reviewed-by: H Hartley Sweeten Acked-by: H Hartley Sweeten Thanks, Hartley diff --git a/drivers/watchdog/ep93xx_wdt.c b/drivers/watchdog/ep93xx_wdt.c index 7a2cc7191c58..0a4d7cc05d54 100644 --- a/drivers/watchdog/ep93xx_wdt.c +++ b/drivers/watchdog/ep93xx_wdt.c @@ -132,6 +132,7 @@ static int ep93xx_wdt_probe(struct platform_device *pdev) val = readl(mmio_base + EP93XX_WATCHDOG); ep93xx_wdt_wdd.bootstatus = (val & 0x01) ? WDIOF_CARDRESET : 0; ep93xx_wdt_wdd.timeout = timeout; + ep93xx_wdt_wdd.parent = &pdev->dev; watchdog_set_nowayout(&ep93xx_wdt_wdd, nowayout);