From patchwork Wed May 6 16:03:29 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Brent Wang X-Patchwork-Id: 6351031 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 7694E9F32B for ; Wed, 6 May 2015 16:35:03 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 8D5BF20149 for ; Wed, 6 May 2015 16:35:02 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9D0DF2012B for ; Wed, 6 May 2015 16:35:01 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1Yq2EV-0007YH-KJ; Wed, 06 May 2015 16:31:40 +0000 Received: from mail-ie0-x22a.google.com ([2607:f8b0:4001:c03::22a]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1Yq2An-0004Di-TW for linux-arm-kernel@lists.infradead.org; Wed, 06 May 2015 16:27:50 +0000 Received: by iepj10 with SMTP id j10so15144006iep.0 for ; Wed, 06 May 2015 09:27:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=704ZTml+sGh7RhpbxfiZtiptTbgdFhqQO5cKJovJMwg=; b=wr7cuK/tmWwWoccBx3irVFFWI57PSAqzjYLh2BDLWAowCNB0bhPORK/K2gGRwEcU+D NicGHPKM11f10Em3fUdW3Ntevrccs6ujwr2bEyqnIRoQ9gmoMmBevr5G7GwGYk8GvDbs eeIGz5xegnZEwxwEt1xAs5/gzi0p2lwLc3gCZpFGHuCQSJNhqXtMcTb4pNpAXaKnBUe/ n55Gc9MAyybVDODiKDZvxCS8c1/gwO+0Z3sKDMv+NQB3jKHqz5p6fy/RcYY97ZuQ0MD8 T6aU7Q3QoIfjl+LNviBjl503x2AO6PcpE1PWamsjCFAeCzv5cow7ZGddP4Dr2oBV/UeQ 6aSw== MIME-Version: 1.0 X-Received: by 10.50.117.35 with SMTP id kb3mr3944682igb.13.1430928209973; Wed, 06 May 2015 09:03:29 -0700 (PDT) Received: by 10.36.103.216 with HTTP; Wed, 6 May 2015 09:03:29 -0700 (PDT) In-Reply-To: <20150506154406.GB2974@leverpostej> References: <1430827599-11560-1-git-send-email-bintian.wang@huawei.com> <1430827599-11560-6-git-send-email-bintian.wang@huawei.com> <20150505171349.GA30215@leverpostej> <5549877C.10408@huawei.com> <5549B9CC.1040709@huawei.com> <20150506093022.GB31001@leverpostej> <5549EE97.3020801@huawei.com> <20150506104856.GC707@leverpostej> <20150506154406.GB2974@leverpostej> Date: Thu, 7 May 2015 00:03:29 +0800 Message-ID: Subject: Re: [PATCH v4 5/5] arm64: dts: Add dts files for Hisilicon Hi6220 SoC From: Brent Wang To: Mark Rutland X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20150506_092750_050948_AE2E1FD2 X-CRM114-Status: GOOD ( 15.74 ) X-Spam-Score: -0.8 (/) Cc: "dan.zhao@hisilicon.com" , "btw@mail.itp.ac.cn" , Catalin Marinas , "wangbinghui@hisilicon.com" , Will Deacon , "huxinwei@huawei.com" , "khilman@linaro.org" , "haojian.zhuang@linaro.org" , "yanhaifeng@gmail.com" , "rob.herring@linaro.org" , "mturquette@linaro.org" , "arnd@arndb.de" , "khilman@kernel.org" , "xuwei5@hisilicon.com" , "jh80.chung@samsung.com" , "sledge.yanwei@huawei.com" , "kong.kongxinwei@hisilicon.com" , "heyunlei@huawei.com" , "w.f@huawei.com" , "zhangfei.gao@linaro.org" , "z.liuxinliang@huawei.com" , "devicetree@vger.kernel.org" , Bintian , Pawel Moll , "ijc+devicetree@hellion.org.uk" , Marc Zyngier , "puck.chen@hisilicon.com" , "leo.yan@linaro.org" , "olof@lixom.net" , "robh+dt@kernel.org" , "linux@arm.linux.org.uk" , "tyler.baker@linaro.org" , "zhenwei.wang@hisilicon.com" , "linux-arm-kernel@lists.infradead.org" , "pebolle@tiscali.nl" , "victor.lixin@hisilicon.com" , "guodong.xu@linaro.org" , "sboyd@codeaurora.org" , "linux-kernel@vger.kernel.org" , "tomeu.vizoso@collabora.com" , "galak@codeaurora.org" , "xuejiancheng@huawei.com" , "jorge.ramirez-ortiz@linaro.org" , "xuyiping@hisilicon.com" , "liguozhu@hisilicon.com" X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-4.1 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_MED, T_DKIM_INVALID, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Hi Mark, 2015-05-06 23:44 GMT+08:00, Mark Rutland : > Hi, > >> How about add the following binding rule to my 2/5 patch: >> --------------------------- >> *Hisilicon Enhanced ARM AMBA Primecell PL011 serial UART >> >> Required properties: >> - compatible: must be "hisilicon,hi6220-uart", "arm,primecell", >> "arm,pl011" > > "arm,primecell" should come last. > >> - reg: exactly one register range with length 0x1000 >> - interrupts: exactly one interrupt specifier >> >> See also bindings/serial/pl011.txt >> >> Example: >> >> uart0: uart@f8015000 { >> compatible = "hisilicon,hi6220-uart", "arm,pl011", >> "arm,primecell"; >> reg = <0x0 0xf8015000 0x0 0x1000>; >> interrupts = ; >> clocks = <&ao_ctrl HI6220_UART0_PCLK>, <&ao_ctrl >> HI6220_UART0_PCLK>; >> clock-names = "uartclk", "apb_pclk"; >> }; > > How about for the moment we just modify the existing pl011 binding > document to allow for the hi6220-specific string in addition to its > existing strings? We can always split it out later if the hi6220 UART > binding needs to be significantly divergent. How about adding the following rule to pl011.txt? ---------- >> > Is UART 0 different from UART1 and UART2? >> Yes, but my patch just includes UART0, we do some changements for >> UART1/2 >> to improve performance. > > Sure, but we need to make sure we can choose a sane compatible string > for them, that won't clash with whatever we choose for UART0. OK, do I also need to add compatible ""hisilicon,hi6220-uart"," to UART0 node? > > Are they the same IP as UART0, or fundamentally different? The same IP. > > Are they also PL011 derived? Yes, just do some enhancements to improve performance. Thanks, Bintian > > Thanks, > Mark. > diff --git a/Documentation/devicetree/bindings/serial/pl011.txt b/Documentation/devicetree/bindings/serial/pl011.txt index ba3ecb8..1221ccb 100644 --- a/Documentation/devicetree/bindings/serial/pl011.txt +++ b/Documentation/devicetree/bindings/serial/pl011.txt @@ -35,6 +35,10 @@ Optional properties: - poll-timeout-ms: Poll timeout when auto-poll is set, default 3000ms. +- compatible: "hisilicon,hi6220-uart": + Hisilicon does some enhancements (e.g. larger FIFO length) + based on PL011, so when using these UART hosts, this compatible + string should be added. See also bindings/arm/primecell.txt ------------ >