From patchwork Thu Apr 10 20:17:44 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Javier Martinez Canillas X-Patchwork-Id: 3964661 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id E8B07BFF02 for ; Thu, 10 Apr 2014 20:18:23 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 0BB3D20826 for ; Thu, 10 Apr 2014 20:18:23 +0000 (UTC) Received: from casper.infradead.org (casper.infradead.org [85.118.1.10]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 063682080F for ; Thu, 10 Apr 2014 20:18:22 +0000 (UTC) Received: from merlin.infradead.org ([2001:4978:20e::2]) by casper.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1WYLQO-0007Fm-Tl; Thu, 10 Apr 2014 20:18:17 +0000 Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1WYLQM-0005sB-JX; Thu, 10 Apr 2014 20:18:14 +0000 Received: from bombadil.infradead.org ([2001:1868:205::9]) by merlin.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1WYLQJ-0005s5-Dw for linux-arm-kernel@merlin.infradead.org; Thu, 10 Apr 2014 20:18:11 +0000 Received: from mail-wi0-f175.google.com ([209.85.212.175]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1WYLQH-0003JU-UQ for linux-arm-kernel@lists.infradead.org; Thu, 10 Apr 2014 20:18:10 +0000 Received: by mail-wi0-f175.google.com with SMTP id cc10so11369197wib.2 for ; Thu, 10 Apr 2014 13:17:47 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=cJ/dBokB81bsvQbjjYPzBdQnmRW9c2sN6kW7zhAeaTE=; b=i/rIWQbHvINWUz7J120Ce6BmcBCNdDsBWTbVXFilxD50tCNtcCmQSb+X4KdV2FuxBS VJJQoJwo0qjz7rfHtOcwTfCk98H222X4TBm2fxeNAne0RtsEL6vj7qxZA3JWkmGkubwS 2oz9dwVVIP1nUYBRa3FTWN+YzNDi2vKZXi1LYMnf8X7QAXwnGkACNLrjrKKQsu4ToI00 SCz1VMRI1+JP9nunSnSFWovJEIZseBpixw6tRpKCuGPKj0PDB1T0BiindIjlV+/T/HVn S7fl5mM8Z8j0CZ+YWFJ4zpGS+sirvtUuIa07VlMkefONvVOibRRnn7ZQ78CFiOK93VLV yNoA== X-Gm-Message-State: ALoCoQndEIEkknMnZpti1yx4aISjLCTWKnLVOrSW6equjULDSnIcTu1nev6OG71JbgQQ9uSV5A0d MIME-Version: 1.0 X-Received: by 10.194.191.133 with SMTP id gy5mr17122899wjc.34.1397161064703; Thu, 10 Apr 2014 13:17:44 -0700 (PDT) Received: by 10.180.87.36 with HTTP; Thu, 10 Apr 2014 13:17:44 -0700 (PDT) X-Originating-IP: [95.21.193.102] In-Reply-To: <20140410193048.GE15736@drone.musicnaut.iki.fi> References: <1396796297-13002-1-git-send-email-javier.martinez@collabora.co.uk> <20140410193048.GE15736@drone.musicnaut.iki.fi> Date: Thu, 10 Apr 2014 22:17:44 +0200 Message-ID: Subject: Re: [PATCH 0/5] GPIO OMAP driver changes for v3.16 From: Javier Martinez Canillas To: Aaro Koskinen X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20140410_131810_129468_610FFE28 X-CRM114-Status: GOOD ( 19.41 ) X-Spam-Score: -0.7 (/) Cc: Nishanth Menon , Paul Walmsley , Kevin Hilman , Tony Lindgren , Linus Walleij , "linux-gpio@vger.kernel.org" , Santosh Shilimkar , Linux-OMAP , Javier Martinez Canillas , "linux-arm-kernel@lists.infradead.org" X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-4.8 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Hello Aaro, Thanks a lot for testing the series! On Thu, Apr 10, 2014 at 9:30 PM, Aaro Koskinen wrote: > Hi, > > On Thu, Apr 10, 2014 at 07:29:26PM +0200, Linus Walleij wrote: >> On Sun, Apr 6, 2014 at 4:58 PM, Javier Martinez Canillas >> wrote: >> >> > Now that you have sent your changes for v3.15 to Torvalds, here are some >> > changes for the OMAP GPIO driver targeted to v3.16. Mostly improvements >> > so nothing here is -rc material. >> >> I like this series so I have applied them for v3.16, pending some ACK >> from Kevin &| Santosh. > > I tried these patches on OMAP1 on top of today's Torvalds git > (4ba85265790ba3681deeaf73f018c0eb829a7341). > > On Amstrad E3 I'm getting the following logs: > > [ 0.156491] omap_gpio omap_gpio.0: Runtime PM disabled, clock forced on. > [ 0.164604] genirq: Setting trigger mode 0 for irq 64 failed (gpio_irq_type+0x0/0x1f0) > [ 0.165418] genirq: Setting trigger mode 0 for irq 65 failed (gpio_irq_type+0x0/0x1f0) > [ 0.166133] genirq: Setting trigger mode 0 for irq 66 failed (gpio_irq_type+0x0/0x1f0) > [ 0.166838] genirq: Setting trigger mode 0 for irq 67 failed (gpio_irq_type+0x0/0x1f0) > [...] > [ 0.182856] genirq: Setting trigger mode 0 for irq 79 failed (gpio_irq_type+0x0/0x1f0) > [ 0.186887] omap_gpio omap_gpio.1: Could not get gpio dbck > [ 0.189308] genirq: Setting trigger mode 0 for irq 95 failed (gpio_irq_type+0x0/0x1f0) > [...] > [ 0.203121] genirq: Setting trigger mode 0 for irq 110 failed (gpio_irq_type+0x0/0x1f0) > > However it still seems to work. The serio is only GPIO IRQ and it > triggers when I press the external keyboard. > > The same happens also on Nokia 770: > > [ 0.118896] genirq: Setting trigger mode 0 for irq 128 failed (gpio_irq_type+0x0/0x220) > [ 0.119201] genirq: Setting trigger mode 0 for irq 129 failed (gpio_irq_type+0x0/0x220) > [...] > [ 0.124999] genirq: Setting trigger mode 0 for irq 143 failed (gpio_irq_type > +0x0/0x220) > [ 0.126831] omap_gpio omap_gpio.1: Could not get gpio dbck > [ 0.127258] OMAP GPIO hardware version 1.1 > [ 0.127624] omap_gpio omap_gpio.2: Could not get gpio dbck > [ 0.128204] omap_gpio omap_gpio.3: Could not get gpio dbck > [ 0.128753] omap_gpio omap_gpio.4: Could not get gpio dbck > > Here also GPIO IRQs (touchscreen, Retu) still work. > > A. I don't have those errors when booting on my DM3730 IGEPv2 board but it seems that for some reason on omap1 __irq_set_trigger() complains when IRQ_TYPE_NONE is used as a default flag when calling gpiochip_irqchip_add() Could you please test the following patch and tell me if your board still works and makes the errors go away? %d\n", ret); Best regards, Javier diff --git a/drivers/gpio/gpio-omap.c b/drivers/gpio/gpio-omap.c index 8cc9e91..5bc8aec 100644 --- a/drivers/gpio/gpio-omap.c +++ b/drivers/gpio/gpio-omap.c @@ -1122,7 +1122,7 @@ static int omap_gpio_chip_init(struct gpio_bank *bank) ret = gpiochip_irqchip_add(&bank->chip, &gpio_irq_chip, irq_base, gpio_irq_handler, - IRQ_TYPE_NONE); + IRQ_TYPE_LEVEL_LOW); if (ret) { dev_err(bank->dev, "Couldn't add irqchip to gpiochip