From patchwork Sat Aug 20 15:18:39 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Javier Martinez Canillas X-Patchwork-Id: 9291727 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 5B2B7600CB for ; Sat, 20 Aug 2016 15:22:25 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 4CD2928C34 for ; Sat, 20 Aug 2016 15:22:25 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 4158628C36; Sat, 20 Aug 2016 15:22:25 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_MED,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 8A13428C34 for ; Sat, 20 Aug 2016 15:22:24 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.85_2 #1 (Red Hat Linux)) id 1bb83D-00023N-1M; Sat, 20 Aug 2016 15:19:11 +0000 Received: from mail-it0-x242.google.com ([2607:f8b0:4001:c0b::242]) by bombadil.infradead.org with esmtps (Exim 4.85_2 #1 (Red Hat Linux)) id 1bb836-00021u-M0 for linux-arm-kernel@lists.infradead.org; Sat, 20 Aug 2016 15:19:05 +0000 Received: by mail-it0-x242.google.com with SMTP id j124so2768417ith.3 for ; Sat, 20 Aug 2016 08:18:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dowhile0-org.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=8bF4o0lbySNYgldJPZVfXcBG4ESeH6wHJn8CXjMg7qs=; b=ztu5sUB7hLfQXhJrIrZ9f8ny5STQ2rAfmrUjBiYRIaPq30DLYLjqKWJxCCSAJgdGIr yqta/x9rGfdyn5BLYjWh8rFHnOsJXoIEnqttzAKztM8lQ76eq3eXSsNE/4IoPm/3pLzL yLvdqxEaV2BpRVXf4wF3UIWCFm8R1Bf8+jth14+YGPT3K0LGxz3DR4vnL1u8uaf4OBFC NhCstmLcfTFMYliL57IweW52kF/O6/wpShYiZSRb0l6AbUOV0/nMt7RmgfZMlKCfB24g 62s6QP+Cr1HWJsGClb1Mv7qymAJTgKNd2E6JJmc1Bo24vqCYTf2QHA1ececP3TfFVHis ektQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=8bF4o0lbySNYgldJPZVfXcBG4ESeH6wHJn8CXjMg7qs=; b=mJawr8nYnpXh8ZuieiOkOXP758Gvddr16VrWspwyP67ku/rSj45lvkPmtg34Q6keeZ U7OXDb+i3p1fs+dkICEKPZN19PTuvFAa/e7nCrrggkKm+E+Yt+fOjvT0abnql1x7hgM/ Ns36tpCVcDEeZQADJoNsQds7QnbXe9K9yshL32lJooR+VDVtIKysDX//RC/H2EzEIkdt ymgwlmbdpvSvFS5nE2Vq9bR2EFVIQibZBVLlCTcfl2pr539IQZRV/W1WUD4PQwtkmwNY 3sCYGmvtA2i84x2XragYww6+u/LnUyF/z78yR9k+iNl/lMjGQZ9ttf0qRoOXr6FgVqvf //vg== X-Gm-Message-State: AEkoouvbRFyt1XAk0cGckx7O2uICaA2ZFssufgnpOP/ixOVQbXmS+qAgcqGoJk/5c3LK8d76eX9B6OSruobuSg== X-Received: by 10.36.233.196 with SMTP id f187mr12262565ith.19.1471706320189; Sat, 20 Aug 2016 08:18:40 -0700 (PDT) MIME-Version: 1.0 Received: by 10.79.27.68 with HTTP; Sat, 20 Aug 2016 08:18:39 -0700 (PDT) X-Originating-IP: [201.217.58.107] In-Reply-To: References: From: Javier Martinez Canillas Date: Sat, 20 Aug 2016 11:18:39 -0400 Message-ID: Subject: Re: [PATCH RFC] Revert "of/irq: Mark initialised interrupt controllers as populated" To: Rob Herring X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20160820_081904_888406_0CD1E1EF X-CRM114-Status: GOOD ( 17.29 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "devicetree@vger.kernel.org" , Ulf Hansson , Marc Zyngier , Shawn Guo , "Rafael J. Wysocki" , Jon Hunter , Russell King , Philipp Zabel , Frank Rowand , "linux-arm-kernel@lists.infradead.org" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP Hello Rob, On Sun, Aug 14, 2016 at 1:32 PM, Rob Herring wrote: > On Sat, Aug 13, 2016 at 4:45 AM, Russell King > wrote: >> This reverts commit 15cc2ed6dcf91a8658e084be4e140147161819d7, which >> causes a regression with iMX6 power domains. iMX6 GPC contains both an >> interrupt controller and power domains. The iMX6 GPC code is setup to >> register an interrupt controller using IRQCHIP_DECLARE(), but then to >> register the power domains using the platform device. >> >> This commit prevents the platform device being created, thereby breaking >> iMX6 power domain support. >> That commit also broke Exynos platforms since several devices are not created (GIC, Exynos combiner and PMU system controller for Exynos5420/5422/5800). >> Signed-off-by: Russell King >> --- >> Please argue amongst yourselves about how to fix this regression caused >> by this commit... > > There's already a fix for this in my tree and -next. I will be sending > to Linus soon. > I guess you mean patch "[1/2] of/irq: Mark interrupt controllers as populated before initialisation" [0] ? Even with that patch on top of v4.8-rc2, things don't work for me. I needed to revert setting the OF_POPULATED flag in of_irq_init for things to work: I noticed that Philipp also sent a patch to clear that flag in arch/arm/mach-imx/gpc.c [1]. I guess the same is needed in the drivers for the devices that are not created for Exynos? If that's the case, then I think that's more safe to revert Jon's commit for now since is too risky for the -rc cycle and more platforms may be affected. [0]: https://patchwork.kernel.org/patch/9271361/ [1]: https://patchwork.kernel.org/patch/9271345/ > Rob > Best regards, Javier diff --git a/drivers/of/irq.c b/drivers/of/irq.c index a2e68f740eda..5f9adc6c06e7 100644 --- a/drivers/of/irq.c +++ b/drivers/of/irq.c @@ -544,7 +544,7 @@ void __init of_irq_init(const struct of_device_id *matches) list_del(&desc->list); - of_node_set_flag(desc->dev, OF_POPULATED); + //of_node_set_flag(desc->dev, OF_POPULATED); pr_debug("of_irq_init: init %s (%p), parent %p\n", desc->dev->full_name,