From patchwork Tue Aug 14 07:24:14 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Genoud X-Patchwork-Id: 1318491 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork2.kernel.org Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) by patchwork2.kernel.org (Postfix) with ESMTP id F062FDF215 for ; Tue, 14 Aug 2012 07:27:14 +0000 (UTC) Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.76 #1 (Red Hat Linux)) id 1T1BUR-0007oA-IR; Tue, 14 Aug 2012 07:24:35 +0000 Received: from mail-lb0-f177.google.com ([209.85.217.177]) by merlin.infradead.org with esmtps (Exim 4.76 #1 (Red Hat Linux)) id 1T1BUO-0007nb-DF for linux-arm-kernel@lists.infradead.org; Tue, 14 Aug 2012 07:24:33 +0000 Received: by lbbgf7 with SMTP id gf7so71038lbb.36 for ; Tue, 14 Aug 2012 00:24:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; bh=H92xtOp9zqdwsINKqLG7pwVaQaUITSxGNEMG6CAzCCw=; b=DILJEElOz9sWZqh0PWPoAFP5SyQpXzbNw7YDj9NWNsVV+mb6euTBNrte3UiX3gsHq7 EQeTS7PuwiR4JQBtbEDw977sxnDCmgPKXwDMcYPr2BweLTz9W2rzdmkAVRzysTLJvU+e qGUUNGEqbXi9DYdbqM9tU3Nj3moVBoCVExJGQMiPxfLlrQTkyaLSb2cDKYhEzLhMZBWP APL7svvt8/80yYnjS8enxfbrzc9RnaT4q4HZQeEO+nefi9Fl1jLnUKdqbqR7ZJt2jnUl 2HjpRehDJ7NLzDfMl9EC92lvhCmiVuh/pPYEL1xuhydIJaX0/z8S8NP6jrFRNQvXVAZL h78g== Received: by 10.152.104.146 with SMTP id ge18mr11441435lab.7.1344929070153; Tue, 14 Aug 2012 00:24:30 -0700 (PDT) MIME-Version: 1.0 Received: by 10.112.29.1 with HTTP; Tue, 14 Aug 2012 00:24:14 -0700 (PDT) In-Reply-To: <20120814023758.GC8836@game.jcrosoft.org> References: <20120810124820.GA20557@game.jcrosoft.org> <1344603731-32667-1-git-send-email-plagnioj@jcrosoft.com> <1344603731-32667-5-git-send-email-plagnioj@jcrosoft.com> <20120814023758.GC8836@game.jcrosoft.org> From: Richard Genoud Date: Tue, 14 Aug 2012 09:24:14 +0200 Message-ID: Subject: Re: [PATCH 05/14] ARM: at91: add pinctrl support To: Jean-Christophe PLAGNIOL-VILLARD X-Spam-Note: CRM114 invocation failed X-Spam-Score: -2.7 (--) X-Spam-Report: SpamAssassin version 3.3.2 on merlin.infradead.org summary: Content analysis details: (-2.7 points) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (richard.genoud[at]gmail.com) -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low trust [209.85.217.177 listed in list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature Cc: Linus Walleij , Nicolas Ferre , linux-arm-kernel@lists.infradead.org X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-arm-kernel-bounces@lists.infradead.org Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org 2012/8/14 Jean-Christophe PLAGNIOL-VILLARD : > no pinctrl MUST be forced as we provide pinctrl dummies > which will provide dummy config so not break > > and if you want the gpio you need to enable the pinctrl on at91 otherwise you > not have it we can force PINCRTL_AT91 on DT but now the pinctrl need to always > be enabled ok, so I think it's better to force PINCTRL_AT91 : This way, older configurations will not break by selecting by default only PINCTRL and not PINCTRL_AT91. >> >> I tested it with a at91sam9g35-ek board, and it hangs before the dbgu >> line is configured. >> ( with at91_dt_defconfig and at91sam9g35ek.dts ) > did you update you dtb before booting? I used the one provided with your patch: git checkout linux-at91/j/pinctrl ARCH=arm make clean ARCH=arm make at91_dt_defconfig ARCH=arm make -k -j8 zImage ./scripts/dtc/dtc -I dts -O dtb arch/arm/boot/dts/at91sam9g35ek.dts -o at91sam9g35ek.dtb cat arch/arm/boot/zImage at91sam9g35ek.dtb > zImage.dtb ./scripts/mkuboot.sh -A arm -O linux -C none -T kernel -a 0x20008000 -e 0x20008000 -n 'Linux-3.6-rc1+pinctrl' -d zImage.dtb uImage.bin and I've got nothing from the kernel: Uncompressing Linux... done, booting the kernel. As the pinmux is still already done by the bootloader, I tried to suppress the lines: pinctrl-names = "default"; pinctrl-0 = <&pinctrl_dbgu>; in the DTS, but it's the same. But the config is ok with 3.6-rc1: git checkout v3.6-rc1 ARCH=arm make clean ARCH=arm make -k -j8 zImage cat arch/arm/boot/zImage at91sam9g35ek.dtb > zImage.dtb # it's the DTB build previously ./scripts/mkuboot.sh -A arm -O linux -C none -T kernel -a 0x20008000 -e 0x20008000 -n 'Linux-3.6-rc1' -d zImage.dtb uImage.bin Uncompressing Linux... done, booting the kernel. Booting Linux on physical CPU 0 Linux version 3.6.0-rc1 (rgenoud@lnx-rg) (gcc version 4.5.3 (Buildroot 2012.05) ) #525 Tue Aug 14 09:07:43 CEST 2012 CPU: ARM926EJ-S [41069265] revision 5 (ARMv5TEJ), cr=00053177 [...] > > Best Regards, > J. Best regads. Richard. diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig index e91c7cd..178a619 100644 --- a/arch/arm/Kconfig +++ b/arch/arm/Kconfig @@ -352,6 +352,7 @@ config ARCH_AT91 select CLKDEV_LOOKUP select IRQ_DOMAIN select NEED_MACH_IO_H if PCCARD + select PINCTRL + select PINCTRL_AT91 help This enables support for systems based on Atmel AT91RM9200 and AT91SAM9* processors.