From patchwork Wed Aug 24 11:59:40 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Linus Walleij X-Patchwork-Id: 1092152 Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) by demeter2.kernel.org (8.14.4/8.14.4) with ESMTP id p7OC04MV012577 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Wed, 24 Aug 2011 12:00:32 GMT Received: from canuck.infradead.org ([2001:4978:20e::1]) by merlin.infradead.org with esmtps (Exim 4.76 #1 (Red Hat Linux)) id 1QwC7X-0001Zl-1m; Wed, 24 Aug 2011 11:59:47 +0000 Received: from localhost ([127.0.0.1] helo=canuck.infradead.org) by canuck.infradead.org with esmtp (Exim 4.76 #1 (Red Hat Linux)) id 1QwC7W-0002ug-Jb; Wed, 24 Aug 2011 11:59:46 +0000 Received: from mail-qw0-f49.google.com ([209.85.216.49]) by canuck.infradead.org with esmtps (Exim 4.76 #1 (Red Hat Linux)) id 1QwC7T-0002uM-NL for linux-arm-kernel@lists.infradead.org; Wed, 24 Aug 2011 11:59:44 +0000 Received: by qwi2 with SMTP id 2so765903qwi.36 for ; Wed, 24 Aug 2011 04:59:41 -0700 (PDT) MIME-Version: 1.0 Received: by 10.224.189.15 with SMTP id dc15mr3147964qab.297.1314187180800; Wed, 24 Aug 2011 04:59:40 -0700 (PDT) Received: by 10.224.37.136 with HTTP; Wed, 24 Aug 2011 04:59:40 -0700 (PDT) In-Reply-To: References: <1314177826-19151-1-git-send-email-linus.walleij@stericsson.com> <4E54CAE8.1060702@ti.com> Date: Wed, 24 Aug 2011 13:59:40 +0200 Message-ID: Subject: Re: [PATCH 2/3] mach-ux500: initialize l2x0 at arch_init time From: Linus Walleij To: Kyungmin Park , Sascha Hauer X-CRM114-Version: 20090807-BlameThorstenAndJenny ( TRE 0.7.6 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20110824_075943_933535_8E021EA1 X-CRM114-Status: GOOD ( 15.84 ) X-Spam-Score: -0.7 (/) X-Spam-Report: SpamAssassin version 3.3.1 on canuck.infradead.org summary: Content analysis details: (-0.7 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low trust [209.85.216.49 listed in list.dnswl.org] Cc: Rabin Vincent , Linus Walleij , Srinidhi Kasagar , Santosh , Lee Jones , linux-arm-kernel@lists.infradead.org X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-arm-kernel-bounces@lists.infradead.org Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Greylist: IP, sender and recipient auto-whitelisted, not delayed by milter-greylist-4.2.6 (demeter2.kernel.org [140.211.167.43]); Wed, 24 Aug 2011 12:00:32 +0000 (UTC) On Wed, Aug 24, 2011 at 12:12 PM, Kyungmin Park wrote: > On Wed, Aug 24, 2011 at 6:56 PM, Santosh wrote: >> On Wednesday 24 August 2011 02:53 PM, Linus Walleij wrote: >> >> More and more you delay L2 cache enable in boot-process, >> your boot-up time is going to shoot-up. >> >> Have you thought about it. Cache's should be enabled as >> early as possible. > > Right, after change from early_init to arch_init. it takes more time. Hm no good. I'll drop this. We've seen that if we try to unlock the I&D l2x0 at the early_initcall() as in [3/3] it will sometimes fail, like it's still locked down afterwards. Calling it from .init_machine() appears to work. So in my dumbness I moved it to arch_initcall() which should be equivalent. Does anyone have some subtle hint or experience on how to get around that one issue, or should I just put in a second arch_initcall() for just the unlocking? Sascha, I guess Freescale should also move the l2x0 init to early_init() in mach-imx/cache-l2x0.c if possible. Can you try the below on your machine(s)? Yours, Linus Walleij diff --git a/arch/arm/mach-imx/cache-l2x0.c b/arch/arm/mach-imx/cache-l2x0.c index 69d1322..e5538a4 100644 --- a/arch/arm/mach-imx/cache-l2x0.c +++ b/arch/arm/mach-imx/cache-l2x0.c @@ -53,4 +53,4 @@ static int mxc_init_l2x0(void) return 0; } -arch_initcall(mxc_init_l2x0); +early_initcall(mxc_init_l2x0);