From patchwork Fri Jan 18 19:59:31 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Linus Walleij X-Patchwork-Id: 2004251 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork1.kernel.org Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) by patchwork1.kernel.org (Postfix) with ESMTP id 2D6713FD86 for ; Fri, 18 Jan 2013 20:02:22 +0000 (UTC) Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.76 #1 (Red Hat Linux)) id 1TwI6B-0005RN-Lq; Fri, 18 Jan 2013 19:59:35 +0000 Received: from mail-ia0-x22b.google.com ([2607:f8b0:4001:c02::22b]) by merlin.infradead.org with esmtps (Exim 4.76 #1 (Red Hat Linux)) id 1TwI68-0005QY-Ga for linux-arm-kernel@lists.infradead.org; Fri, 18 Jan 2013 19:59:33 +0000 Received: by mail-ia0-f171.google.com with SMTP id z13so611133iaz.2 for ; Fri, 18 Jan 2013 11:59:31 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:x-received:in-reply-to:references:date:message-id :subject:from:to:cc:content-type:x-gm-message-state; bh=ywX/hMwZcuxfoeeHV8Me5m9DfWuH8IQzMK7UqOttbbs=; b=fwrh5bQmGqhOAPz7tKiKpzHD7ithJWYMVHdyz1qXH1zSWQgN5aUeBT6x2T7iu2toAG +58cKB7/2Fn6F1sG1n0ryQBEWI83OX0nPvklDiMwTHnXFw5jGWdjhKFZk3vnCAg3KuqT O77iV+VgC4/lL/QSSGjZC/ETGz3vumXp30Cm+Ma0EBIMp9ysPEW3xscK6c4Hz/ovYkk5 u5Rahos/DgMpqSM0CgB93OMZ7DY8ocvGpV9SKDv5w9GQiyhLqxqjd8dwDTPpTlaWiiZV 2/+6gAkW6lwqFUGACOhEpYN/7m+hXzDiAKKXz7xzg6yriXC5aGkQMivZ/vPIESsYUvAf WiLQ== MIME-Version: 1.0 X-Received: by 10.50.149.131 with SMTP id ua3mr3191976igb.5.1358539171329; Fri, 18 Jan 2013 11:59:31 -0800 (PST) Received: by 10.43.81.130 with HTTP; Fri, 18 Jan 2013 11:59:31 -0800 (PST) In-Reply-To: <1357919129-1928-2-git-send-email-lee.jones@linaro.org> References: <1357919129-1928-1-git-send-email-lee.jones@linaro.org> <1357919129-1928-2-git-send-email-lee.jones@linaro.org> Date: Fri, 18 Jan 2013 20:59:31 +0100 Message-ID: Subject: Re: [PATCH 2/2] pinctrl: nomadik: Allow prcm_base to be extracted from Device Tree From: Linus Walleij To: Lee Jones X-Gm-Message-State: ALoCoQnl2zuIKm5E9bgL7oHjo5xlAVIz2/Jc5/rm8waCcKsrftNUmLrY+85wv5uJVtHd4hI7rLlN X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20130118_145932_589126_B6B6E0F1 X-CRM114-Status: GOOD ( 13.07 ) X-Spam-Score: -1.9 (-) X-Spam-Report: SpamAssassin version 3.3.2 on merlin.infradead.org summary: Content analysis details: (-1.9 points) pts rule name description ---- ---------------------- -------------------------------------------------- -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] Cc: arnd@arndb.de, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linus.walleij@stericsson.com X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-arm-kernel-bounces@lists.infradead.org Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org On Fri, Jan 11, 2013 at 4:45 PM, Lee Jones wrote: > The Nomadik Pinctrl driver requires access to some PRCMU registers > in order to run with full functionality. When Device Tree is > disabled the required PRCMU base address is passed in via platform > data, so in order for Device Tree booting to be as functional, we > need a similar mechanism to fetch it from Device Tree. > > The new semantics goes like this: Parse the Device Tree and look > for the PRCMU node using a provided Phandle. Obtain the ioremaped > address from that node. If one was supplied via platform data > over-write it with anything found in Device Tree. Fail if either > the prcm_base can't be found if we're running on anything other > than an STN8815 ASIC. > > Signed-off-by: Lee Jones Applied as well, notice I had to add this hunk to the first patch to have things working: Lest the code won't find the prcmu registers. Yours, Linus Walleij diff --git a/arch/arm/boot/dts/dbx5x0.dtsi b/arch/arm/boot/dts/dbx5x0.dtsi index 05d97f6..96f518b 100644 --- a/arch/arm/boot/dts/dbx5x0.dtsi +++ b/arch/arm/boot/dts/dbx5x0.dtsi @@ -192,6 +192,7 @@ prcmu: prcmu@80157000 { compatible = "stericsson,db8500-prcmu"; reg = <0x80157000 0x1000>; + reg-names = "prcmu"; interrupts = <0 47 0x4>; #address-cells = <1>; #size-cells = <1>;