From patchwork Fri Dec 2 06:42:25 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Duc Dang X-Patchwork-Id: 9457941 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 6FACF60515 for ; Fri, 2 Dec 2016 06:48:00 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 626AC2843A for ; Fri, 2 Dec 2016 06:48:00 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 5706A284F3; Fri, 2 Dec 2016 06:48:00 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_MED,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 935562843A for ; Fri, 2 Dec 2016 06:47:59 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.85_2 #1 (Red Hat Linux)) id 1cChba-0005gK-TZ; Fri, 02 Dec 2016 06:45:58 +0000 Received: from mail-vk0-x233.google.com ([2607:f8b0:400c:c05::233]) by bombadil.infradead.org with esmtps (Exim 4.85_2 #1 (Red Hat Linux)) id 1cChYz-0001wd-Cu for linux-arm-kernel@lists.infradead.org; Fri, 02 Dec 2016 06:43:28 +0000 Received: by mail-vk0-x233.google.com with SMTP id x186so141281042vkd.1 for ; Thu, 01 Dec 2016 22:42:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=apm.com; s=apm; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=b+XxJs7lBAGP/+MpSDL2dDmVJHL2TEav+lGb9RTFpIc=; b=IsmpCD3E7dReO8nOYdwN3MRh2hVQcuQIpAhg208SA/yLoadhCxHkctPguHC4oqiWvo NrlcC1b2p8ZIc/QGR92tlO0FhfArYbourSH4oGUjRBmm4uEk4/L/dATwN4Zsv9dq52X/ SP/7MxpVR8pIQc5XwoICFk/exfoEbQRV6eVY0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=b+XxJs7lBAGP/+MpSDL2dDmVJHL2TEav+lGb9RTFpIc=; b=ZtUHiBISx0dfc7WQkV7rz2rIZixrisHSYWKxcY7bJC4nnmBpjQAr/sBTb3S8VzLSwv zu3rUYl7VGvFrpK2kZllG8Frtp9Uk1hFanFLPBB4ljXvwCxxL5QxeSU6IoUB3amuAANT aPoD+psHPstrgo52OUm8zfjP4Hgi61TugslMX/2r6PsFCxrw/W00JVgvngoqEzOIFome rJaVlwMaEr3uCyNXfEo/9UUaN7nw34q2ZdNPjPP1dfRDab8ZtgzNob+ZwwREwCRfxf6q 4J1BGIZS4ngSVlQg/op+cEUln0eHGwQBzUDbAnU6Ae2HaTqBolawBqPW1yio6+IN+evB vFfA== X-Gm-Message-State: AKaTC00gSQH19qjcqvkz65oBug62x2Kah0Gg4odSlyiLSBo4im2gzTl5XLCNdXGGCoo1ntKvaM4H/gv//sz93kHr X-Received: by 10.31.115.205 with SMTP id o196mr7212722vkc.139.1480660975569; Thu, 01 Dec 2016 22:42:55 -0800 (PST) MIME-Version: 1.0 Received: by 10.176.67.195 with HTTP; Thu, 1 Dec 2016 22:42:25 -0800 (PST) In-Reply-To: References: <1479201298-25494-1-git-send-email-tn@semihalf.com> <1479201298-25494-2-git-send-email-tn@semihalf.com> <20161201002812.GB9409@bhelgaas-glaptop.roam.corp.google.com> From: Duc Dang Date: Thu, 1 Dec 2016 22:42:25 -0800 Message-ID: Subject: Re: [Linaro-acpi] [PATCH V1 1/2] PCI: thunder: Enable ACPI PCI controller for ThunderX pass2.x silicon version To: Jon Masters X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20161201_224318_115859_D620550F X-CRM114-Status: GOOD ( 13.29 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jayachandran C , Gabriele Paoloni , Arnd Bergmann , Rafael Wysocki , linux-pci@vger.kernel.org, Tomasz Nowicki , Ard Biesheuvel , Will Deacon , David Daney , Jeremy Linton , Linux Kernel Mailing List , Linaro ACPI Mailman List , linux-acpi@vger.kernel.org, Robert Richter , Bjorn Helgaas , Christopher Covington , Catalin Marinas , Marcin Wojtas , Andrea Gallo , linux-arm Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP On Thu, Dec 1, 2016 at 9:50 PM, Jon Masters wrote: > On 11/30/2016 07:28 PM, Bjorn Helgaas wrote: > >> I'm hoping to end up with something like this: >> https://git.kernel.org/cgit/linux/kernel/git/helgaas/pci.git/commit/?h=pci/ecam&id=51ad4df79a9b7f2a66b346a46b21a785a2937469 > > The following build warnings happen using your branch on RHELSA7.3: > > drivers/acpi/pci_mcfg.c:101:2: warning: left shift count >= width of type [enabled by default] > THUNDER_PEM_QUIRK(2, 0), /* off-chip devices */ > ^ > drivers/acpi/pci_mcfg.c:101:2: warning: initializer element is not a constant expression [enabled by default] > drivers/acpi/pci_mcfg.c:101:2: warning: (near initialization for ‘mcfg_quirks[44].cfgres.start’) [enabled by default] > drivers/acpi/pci_mcfg.c:101:2: warning: left shift count >= width of type [enabled by default] > drivers/acpi/pci_mcfg.c:101:2: warning: initializer element is not a constant expression [enabled by default] > drivers/acpi/pci_mcfg.c:101:2: warning: (near initialization for ‘mcfg_quirks[44].cfgres.end’) [enabled by default] > drivers/acpi/pci_mcfg.c:101:2: warning: left shift count >= width of type [enabled by default] > drivers/acpi/pci_mcfg.c:101:2: warning: initializer element is not a constant expression [enabled by default] > drivers/acpi/pci_mcfg.c:101:2: warning: (near initialization for ‘mcfg_quirks[45].cfgres.start’) [enabled by default] > drivers/acpi/pci_mcfg.c:101:2: warning: left shift count >= width of type [enabled by default] > drivers/acpi/pci_mcfg.c:101:2: warning: initializer element is not a constant expression [enabled by default] > drivers/acpi/pci_mcfg.c:101:2: warning: (near initialization for ‘mcfg_quirks[45].cfgres.end’) [enabled by default] > drivers/acpi/pci_mcfg.c:101:2: warning: left shift count >= width of type [enabled by default] > drivers/acpi/pci_mcfg.c:101:2: warning: initializer element is not a constant expression [enabled by default] > drivers/acpi/pci_mcfg.c:101:2: warning: (near initialization for ‘mcfg_quirks[46].cfgres.start’) [enabled by default] > drivers/acpi/pci_mcfg.c:101:2: warning: left shift count >= width of type [enabled by default] > drivers/acpi/pci_mcfg.c:101:2: warning: initializer element is not a constant expression [enabled by default] > drivers/acpi/pci_mcfg.c:101:2: warning: (near initialization for ‘mcfg_quirks[46].cfgres.end’) [enabled by default] > drivers/acpi/pci_mcfg.c:101:2: warning: left shift count >= width of type [enabled by default] > drivers/acpi/pci_mcfg.c:101:2: warning: initializer element is not a constant expression [enabled by default] > drivers/acpi/pci_mcfg.c:101:2: warning: (near initialization for ‘mcfg_quirks[47].cfgres.start’) [enabled by default] > drivers/acpi/pci_mcfg.c:101:2: warning: left shift count >= width of type [enabled by default] > drivers/acpi/pci_mcfg.c:101:2: warning: initializer element is not a constant expression [enabled by default] > drivers/acpi/pci_mcfg.c:101:2: warning: (near initialization for ‘mcfg_quirks[47].cfgres.end’) [enabled by default] > drivers/acpi/pci_mcfg.c:101:2: warning: left shift count >= width of type [enabled by default] > drivers/acpi/pci_mcfg.c:101:2: warning: initializer element is not a constant expression [enabled by default] > drivers/acpi/pci_mcfg.c:101:2: warning: (near initialization for ‘mcfg_quirks[48].cfgres.start’) [enabled by default] > drivers/acpi/pci_mcfg.c:101:2: warning: left shift count >= width of type [enabled by default] > drivers/acpi/pci_mcfg.c:101:2: warning: initializer element is not a constant expression [enabled by default] > drivers/acpi/pci_mcfg.c:101:2: warning: (near initialization for ‘mcfg_quirks[48].cfgres.end’) [enabled by default] > drivers/acpi/pci_mcfg.c:101:2: warning: left shift count >= width of type [enabled by default] > drivers/acpi/pci_mcfg.c:101:2: warning: initializer element is not a constant expression [enabled by default] > drivers/acpi/pci_mcfg.c:101:2: warning: (near initialization for ‘mcfg_quirks[49].cfgres.start’) [enabled by default] > drivers/acpi/pci_mcfg.c:101:2: warning: left shift count >= width of type [enabled by default] > drivers/acpi/pci_mcfg.c:101:2: warning: initializer element is not a constant expression [enabled by default] > drivers/acpi/pci_mcfg.c:101:2: warning: (near initialization for ‘mcfg_quirks[49].cfgres.end’) [enabled by default] > drivers/acpi/pci_mcfg.c:102:2: warning: left shift count >= width of type [enabled by default] > THUNDER_PEM_QUIRK(2, 1), /* off-chip devices */ > ^ > drivers/acpi/pci_mcfg.c:102:2: warning: initializer element is not a constant expression [enabled by default] > drivers/acpi/pci_mcfg.c:102:2: warning: (near initialization for ‘mcfg_quirks[50].cfgres.start’) [enabled by default] > drivers/acpi/pci_mcfg.c:102:2: warning: left shift count >= width of type [enabled by default] > drivers/acpi/pci_mcfg.c:102:2: warning: initializer element is not a constant expression [enabled by default] > drivers/acpi/pci_mcfg.c:102:2: warning: (near initialization for ‘mcfg_quirks[50].cfgres.end’) [enabled by default] > drivers/acpi/pci_mcfg.c:102:2: warning: left shift count >= width of type [enabled by default] > drivers/acpi/pci_mcfg.c:102:2: warning: initializer element is not a constant expression [enabled by default] > drivers/acpi/pci_mcfg.c:102:2: warning: (near initialization for ‘mcfg_quirks[51].cfgres.start’) [enabled by default] > drivers/acpi/pci_mcfg.c:102:2: warning: left shift count >= width of type [enabled by default] > drivers/acpi/pci_mcfg.c:102:2: warning: initializer element is not a constant expression [enabled by default] > drivers/acpi/pci_mcfg.c:102:2: warning: (near initialization for ‘mcfg_quirks[51].cfgres.end’) [enabled by default] > drivers/acpi/pci_mcfg.c:102:2: warning: left shift count >= width of type [enabled by default] > drivers/acpi/pci_mcfg.c:102:2: warning: initializer element is not a constant expression [enabled by default] > drivers/acpi/pci_mcfg.c:102:2: warning: (near initialization for ‘mcfg_quirks[52].cfgres.start’) [enabled by default] > drivers/acpi/pci_mcfg.c:102:2: warning: left shift count >= width of type [enabled by default] > drivers/acpi/pci_mcfg.c:102:2: warning: initializer element is not a constant expression [enabled by default] > drivers/acpi/pci_mcfg.c:102:2: warning: (near initialization for ‘mcfg_quirks[52].cfgres.end’) [enabled by default] > drivers/acpi/pci_mcfg.c:102:2: warning: left shift count >= width of type [enabled by default] > drivers/acpi/pci_mcfg.c:102:2: warning: initializer element is not a constant expression [enabled by default] > drivers/acpi/pci_mcfg.c:102:2: warning: (near initialization for ‘mcfg_quirks[53].cfgres.start’) [enabled by default] > drivers/acpi/pci_mcfg.c:102:2: warning: left shift count >= width of type [enabled by default] > drivers/acpi/pci_mcfg.c:102:2: warning: initializer element is not a constant expression [enabled by default] > drivers/acpi/pci_mcfg.c:102:2: warning: (near initialization for ‘mcfg_quirks[53].cfgres.end’) [enabled by default] > drivers/acpi/pci_mcfg.c:102:2: warning: left shift count >= width of type [enabled by default] > drivers/acpi/pci_mcfg.c:102:2: warning: initializer element is not a constant expression [enabled by default] > drivers/acpi/pci_mcfg.c:102:2: warning: (near initialization for ‘mcfg_quirks[54].cfgres.start’) [enabled by default] > drivers/acpi/pci_mcfg.c:102:2: warning: left shift count >= width of type [enabled by default] > drivers/acpi/pci_mcfg.c:102:2: warning: initializer element is not a constant expression [enabled by default] > drivers/acpi/pci_mcfg.c:102:2: warning: (near initialization for ‘mcfg_quirks[54].cfgres.end’) [enabled by default] > drivers/acpi/pci_mcfg.c:102:2: warning: left shift count >= width of type [enabled by default] > drivers/acpi/pci_mcfg.c:102:2: warning: initializer element is not a constant expression [enabled by default] > drivers/acpi/pci_mcfg.c:102:2: warning: (near initialization for ‘mcfg_quirks[55].cfgres.start’) [enabled by default] > drivers/acpi/pci_mcfg.c:102:2: warning: left shift count >= width of type [enabled by default] > drivers/acpi/pci_mcfg.c:102:2: warning: initializer element is not a constant expression [enabled by default] > drivers/acpi/pci_mcfg.c:102:2: warning: (near initialization for ‘mcfg_quirks[55].cfgres.end’) [enabled by default] I saw this too. It can be fixed by changes below: > > Jon. > > -- > Computer Architect | Sent from my Fedora powered laptop > _______________________________________________ > Linaro-acpi mailing list > Linaro-acpi@lists.linaro.org > https://lists.linaro.org/mailman/listinfo/linaro-acpi Regards, Duc Dang. diff --git a/drivers/acpi/pci_mcfg.c b/drivers/acpi/pci_mcfg.c index 7319188..3d7c5cc 100644 --- a/drivers/acpi/pci_mcfg.c +++ b/drivers/acpi/pci_mcfg.c @@ -98,16 +98,16 @@ struct mcfg_fixup { { "CAVIUM", "THUNDERX", rev, seg, MCFG_BUS_ANY, \ &pci_thunder_ecam_ops } /* SoC pass1.x */ - THUNDER_PEM_QUIRK(2, 0), /* off-chip devices */ - THUNDER_PEM_QUIRK(2, 1), /* off-chip devices */ - THUNDER_ECAM_QUIRK(2, 0), - THUNDER_ECAM_QUIRK(2, 1), - THUNDER_ECAM_QUIRK(2, 2), - THUNDER_ECAM_QUIRK(2, 3), - THUNDER_ECAM_QUIRK(2, 10), - THUNDER_ECAM_QUIRK(2, 11), - THUNDER_ECAM_QUIRK(2, 12), - THUNDER_ECAM_QUIRK(2, 13), + THUNDER_PEM_QUIRK(2, 0UL), /* off-chip devices */ + THUNDER_PEM_QUIRK(2, 1UL), /* off-chip devices */ + THUNDER_ECAM_QUIRK(2, 0UL), + THUNDER_ECAM_QUIRK(2, 1UL), + THUNDER_ECAM_QUIRK(2, 2UL), + THUNDER_ECAM_QUIRK(2, 3UL), + THUNDER_ECAM_QUIRK(2, 10UL), + THUNDER_ECAM_QUIRK(2, 11UL), + THUNDER_ECAM_QUIRK(2, 12UL), + THUNDER_ECAM_QUIRK(2, 13UL), #define XGENE_V1_ECAM_MCFG(rev, seg) \ {"APM ", "XGENE ", rev, seg, MCFG_BUS_ANY, \