From patchwork Tue Aug 9 04:13:32 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Alim Akhtar X-Patchwork-Id: 1047442 Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) by demeter2.kernel.org (8.14.4/8.14.4) with ESMTP id p794EZr4021505 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Tue, 9 Aug 2011 04:14:56 GMT Received: from canuck.infradead.org ([2001:4978:20e::1]) by merlin.infradead.org with esmtps (Exim 4.76 #1 (Red Hat Linux)) id 1Qqdhr-0001fc-8V; Tue, 09 Aug 2011 04:14:19 +0000 Received: from localhost ([127.0.0.1] helo=canuck.infradead.org) by canuck.infradead.org with esmtp (Exim 4.76 #1 (Red Hat Linux)) id 1Qqdhq-00059f-Pc; Tue, 09 Aug 2011 04:14:18 +0000 Received: from mail-vw0-f49.google.com ([209.85.212.49]) by canuck.infradead.org with esmtps (Exim 4.76 #1 (Red Hat Linux)) id 1Qqdhm-00059M-0S for linux-arm-kernel@lists.infradead.org; Tue, 09 Aug 2011 04:14:15 +0000 Received: by vws8 with SMTP id 8so2720599vws.36 for ; Mon, 08 Aug 2011 21:14:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type:content-transfer-encoding; bh=b1SbJGAcGM2eydHt3YxdFwODJFBhVkHr9vHWgzY+SDI=; b=eIHCuJ5qGGTdgpRomKruCNkOthoUUFUEB0iTF1ThnsxZTV9vhfqBXq4QqA+W3K+Rkr ucPiIbS1LRro+4UKAbx+d1QKU2KMNrvUesStCrZNPbUjpxHlQ60f2MAEuApeY+D8pRo5 dpimAInZIx52/483vpeA+Q8pZB9TVWy7Z2tfA= Received: by 10.52.25.42 with SMTP id z10mr506429vdf.503.1312863252069; Mon, 08 Aug 2011 21:14:12 -0700 (PDT) MIME-Version: 1.0 Received: by 10.52.107.194 with HTTP; Mon, 8 Aug 2011 21:13:32 -0700 (PDT) In-Reply-To: References: <1311744697-10264-1-git-send-email-boojin.kim@samsung.com> <1311744697-10264-13-git-send-email-boojin.kim@samsung.com> From: Alim Akhtar Date: Tue, 9 Aug 2011 09:43:32 +0530 Message-ID: Subject: Re: [PATCH 12/15] spi/s3c64xx: Add support DMA engine API To: Jassi Brar , Boojin Kim X-CRM114-Version: 20090807-BlameThorstenAndJenny ( TRE 0.7.6 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20110809_001414_355447_1A15A89D X-CRM114-Status: GOOD ( 26.50 ) X-Spam-Score: -0.8 (/) X-Spam-Report: SpamAssassin version 3.3.1 on canuck.infradead.org summary: Content analysis details: (-0.8 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low trust [209.85.212.49 listed in list.dnswl.org] 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (alim.akhtar[at]gmail.com) -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature Cc: Kukjin Kim , Russell King , Vinod Koul , Linus Walleij , Mark Brown , Grant Likely , linux-samsung-soc@vger.kernel.org, banajit.g@samsung.com, Dan Williams , linux-arm-kernel@lists.infradead.org X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-arm-kernel-bounces@lists.infradead.org Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Greylist: IP, sender and recipient auto-whitelisted, not delayed by milter-greylist-4.2.6 (demeter2.kernel.org [140.211.167.43]); Tue, 09 Aug 2011 04:14:56 +0000 (UTC) X-MIME-Autoconverted: from quoted-printable to 8bit by demeter2.kernel.org id p794EZr4021505 On Mon, Aug 8, 2011 at 11:17 PM, Jassi Brar wrote: > On Wed, Jul 27, 2011 at 11:01 AM, Boojin Kim wrote: >> This patch adds to support DMA generic API to transfer raw >> SPI data. Basiclly the spi driver uses DMA generic API if >> architecture supports it. Otherwise, uses Samsung specific >> S3C-PL330 APIs. >> >> Signed-off-by: Boojin Kim >> Acked-by: Grant Likely >> Signed-off-by: Kukjin Kim >> --- >>  drivers/spi/spi_s3c64xx.c |  141 ++++++++++++++++++++++----------------------- >>  1 files changed, 69 insertions(+), 72 deletions(-) >> >> diff --git a/drivers/spi/spi_s3c64xx.c b/drivers/spi/spi_s3c64xx.c >> index 8945e20..a4cf76a 100644 >> --- a/drivers/spi/spi_s3c64xx.c >> +++ b/drivers/spi/spi_s3c64xx.c >> @@ -172,6 +172,9 @@ struct s3c64xx_spi_driver_data { >>        unsigned                        state; >>        unsigned                        cur_mode, cur_bpw; >>        unsigned                        cur_speed; >> +       unsigned                        rx_ch; >> +       unsigned                        tx_ch; >> +       struct samsung_dma_ops          *ops; >>  }; >> >>  static struct s3c2410_dma_client s3c64xx_spi_dma_client = { >> @@ -227,6 +230,38 @@ static void flush_fifo(struct s3c64xx_spi_driver_data *sdd) >>        writel(val, regs + S3C64XX_SPI_CH_CFG); >>  } >> >> +static void s3c64xx_spi_dma_rxcb(void *data) >> +{ >> +       struct s3c64xx_spi_driver_data *sdd >> +               = (struct s3c64xx_spi_driver_data *)data; > void* doesn't need typecasting (same for all such occurances) > IIRC someone already pointed it out? > > >> +       unsigned long flags; >> + >> +       spin_lock_irqsave(&sdd->lock, flags); >> + >> +       sdd->state &= ~RXBUSY; >> +       /* If the other done */ >> +       if (!(sdd->state & TXBUSY)) >> +               complete(&sdd->xfer_completion); >> + >> +       spin_unlock_irqrestore(&sdd->lock, flags); >> +} >> + >> +static void s3c64xx_spi_dma_txcb(void *data) >> +{ >> +       struct s3c64xx_spi_driver_data *sdd >> +               = (struct s3c64xx_spi_driver_data *)data; >> +       unsigned long flags; >> + >> +       spin_lock_irqsave(&sdd->lock, flags); >> + >> +       sdd->state &= ~TXBUSY; >> +       /* If the other done */ >> +       if (!(sdd->state & RXBUSY)) >> +               complete(&sdd->xfer_completion); >> + >> +       spin_unlock_irqrestore(&sdd->lock, flags); >> +} >> + >>  static void enable_datapath(struct s3c64xx_spi_driver_data *sdd, >>                                struct spi_device *spi, >>                                struct spi_transfer *xfer, int dma_mode) >> @@ -234,6 +269,7 @@ static void enable_datapath(struct s3c64xx_spi_driver_data *sdd, >>        struct s3c64xx_spi_info *sci = sdd->cntrlr_info; >>        void __iomem *regs = sdd->regs; >>        u32 modecfg, chcfg; >> +       struct samsung_dma_prep_info info; >> >>        modecfg = readl(regs + S3C64XX_SPI_MODE_CFG); >>        modecfg &= ~(S3C64XX_SPI_MODE_TXDMA_ON | S3C64XX_SPI_MODE_RXDMA_ON); >> @@ -259,10 +295,14 @@ static void enable_datapath(struct s3c64xx_spi_driver_data *sdd, >>                chcfg |= S3C64XX_SPI_CH_TXCH_ON; >>                if (dma_mode) { >>                        modecfg |= S3C64XX_SPI_MODE_TXDMA_ON; >> -                       s3c2410_dma_config(sdd->tx_dmach, sdd->cur_bpw / 8); >> -                       s3c2410_dma_enqueue(sdd->tx_dmach, (void *)sdd, >> -                                               xfer->tx_dma, xfer->len); >> -                       s3c2410_dma_ctrl(sdd->tx_dmach, S3C2410_DMAOP_START); >> +                       info.cap = DMA_SLAVE; >> +                       info.direction = DMA_TO_DEVICE; >> +                       info.buf = xfer->tx_dma; >> +                       info.len = xfer->len; >> +                       info.fp = s3c64xx_spi_dma_txcb; >> +                       info.fp_param = sdd; >> +                       sdd->ops->prepare(sdd->tx_ch, &info); >> +                       sdd->ops->trigger(sdd->tx_ch); >>                } else { >>                        switch (sdd->cur_bpw) { >>                        case 32: >> @@ -294,10 +334,14 @@ static void enable_datapath(struct s3c64xx_spi_driver_data *sdd, >>                        writel(((xfer->len * 8 / sdd->cur_bpw) & 0xffff) >>                                        | S3C64XX_SPI_PACKET_CNT_EN, >>                                        regs + S3C64XX_SPI_PACKET_CNT); >> -                       s3c2410_dma_config(sdd->rx_dmach, sdd->cur_bpw / 8); >> -                       s3c2410_dma_enqueue(sdd->rx_dmach, (void *)sdd, >> -                                               xfer->rx_dma, xfer->len); >> -                       s3c2410_dma_ctrl(sdd->rx_dmach, S3C2410_DMAOP_START); >> +                       info.cap = DMA_SLAVE; >> +                       info.direction = DMA_FROM_DEVICE; >> +                       info.buf = xfer->rx_dma; >> +                       info.len = xfer->len; >> +                       info.fp = s3c64xx_spi_dma_rxcb; >> +                       info.fp_param = sdd; >> +                       sdd->ops->prepare(sdd->rx_ch, &info); >> +                       sdd->ops->trigger(sdd->rx_ch); >>                } >>        } >> >> @@ -483,46 +527,6 @@ static void s3c64xx_spi_config(struct s3c64xx_spi_driver_data *sdd) >>        } >>  } >> >> -static void s3c64xx_spi_dma_rxcb(struct s3c2410_dma_chan *chan, void *buf_id, >> -                                int size, enum s3c2410_dma_buffresult res) >> -{ >> -       struct s3c64xx_spi_driver_data *sdd = buf_id; >> -       unsigned long flags; >> - >> -       spin_lock_irqsave(&sdd->lock, flags); >> - >> -       if (res == S3C2410_RES_OK) >> -               sdd->state &= ~RXBUSY; >> -       else >> -               dev_err(&sdd->pdev->dev, "DmaAbrtRx-%d\n", size); >> - >> -       /* If the other done */ >> -       if (!(sdd->state & TXBUSY)) >> -               complete(&sdd->xfer_completion); >> - >> -       spin_unlock_irqrestore(&sdd->lock, flags); >> -} >> - >> -static void s3c64xx_spi_dma_txcb(struct s3c2410_dma_chan *chan, void *buf_id, >> -                                int size, enum s3c2410_dma_buffresult res) >> -{ >> -       struct s3c64xx_spi_driver_data *sdd = buf_id; >> -       unsigned long flags; >> - >> -       spin_lock_irqsave(&sdd->lock, flags); >> - >> -       if (res == S3C2410_RES_OK) >> -               sdd->state &= ~TXBUSY; >> -       else >> -               dev_err(&sdd->pdev->dev, "DmaAbrtTx-%d \n", size); >> - >> -       /* If the other done */ >> -       if (!(sdd->state & RXBUSY)) >> -               complete(&sdd->xfer_completion); >> - >> -       spin_unlock_irqrestore(&sdd->lock, flags); >> -} >> - >>  #define XFER_DMAADDR_INVALID DMA_BIT_MASK(32) >> >>  static int s3c64xx_spi_map_mssg(struct s3c64xx_spi_driver_data *sdd, >> @@ -697,12 +701,10 @@ static void handle_msg(struct s3c64xx_spi_driver_data *sdd, >>                        if (use_dma) { >>                                if (xfer->tx_buf != NULL >>                                                && (sdd->state & TXBUSY)) >> -                                       s3c2410_dma_ctrl(sdd->tx_dmach, >> -                                                       S3C2410_DMAOP_FLUSH); >> +                                       sdd->ops->stop(sdd->tx_ch); >>                                if (xfer->rx_buf != NULL >>                                                && (sdd->state & RXBUSY)) >> -                                       s3c2410_dma_ctrl(sdd->rx_dmach, >> -                                                       S3C2410_DMAOP_FLUSH); >> +                                       sdd->ops->stop(sdd->rx_ch); >>                        } >> >>                        goto out; >> @@ -742,24 +744,19 @@ out: >> >>  static int acquire_dma(struct s3c64xx_spi_driver_data *sdd) >>  { >> -       if (s3c2410_dma_request(sdd->rx_dmach, >> -                                       &s3c64xx_spi_dma_client, NULL) < 0) { >> -               dev_err(&sdd->pdev->dev, "cannot get RxDMA\n"); >> -               return 0; >> -       } >> -       s3c2410_dma_set_buffdone_fn(sdd->rx_dmach, s3c64xx_spi_dma_rxcb); >> -       s3c2410_dma_devconfig(sdd->rx_dmach, S3C2410_DMASRC_HW, >> -                                       sdd->sfr_start + S3C64XX_SPI_RX_DATA); >> - >> -       if (s3c2410_dma_request(sdd->tx_dmach, >> -                                       &s3c64xx_spi_dma_client, NULL) < 0) { >> -               dev_err(&sdd->pdev->dev, "cannot get TxDMA\n"); >> -               s3c2410_dma_free(sdd->rx_dmach, &s3c64xx_spi_dma_client); >> -               return 0; >> -       } >> -       s3c2410_dma_set_buffdone_fn(sdd->tx_dmach, s3c64xx_spi_dma_txcb); >> -       s3c2410_dma_devconfig(sdd->tx_dmach, S3C2410_DMASRC_MEM, >> -                                       sdd->sfr_start + S3C64XX_SPI_TX_DATA); >> + >> +       struct samsung_dma_info info; >> +       sdd->ops = samsung_dma_get_ops(); >> + >> +       info.cap = DMA_SLAVE; >> +       info.client = &s3c64xx_spi_dma_client; >> +       info.direction = DMA_FROM_DEVICE; >> +       info.fifo = sdd->sfr_start + S3C64XX_SPI_RX_DATA; >> +       info.width = sdd->cur_bpw / 8; >> +       sdd->rx_ch = sdd->ops->request(sdd->rx_dmach, &info); >> +       info.direction = DMA_TO_DEVICE; >> +       info.fifo = sdd->sfr_start + S3C64XX_SPI_TX_DATA; >> +       sdd->tx_ch = sdd->ops->request(sdd->tx_dmach, &info); >> >>        return 1; >>  } >> @@ -800,8 +797,8 @@ static void s3c64xx_spi_work(struct work_struct *work) >>        spin_unlock_irqrestore(&sdd->lock, flags); >> >>        /* Free DMA channels */ >> -       s3c2410_dma_free(sdd->tx_dmach, &s3c64xx_spi_dma_client); >> -       s3c2410_dma_free(sdd->rx_dmach, &s3c64xx_spi_dma_client); >> +       sdd->ops->release(sdd->rx_ch, &s3c64xx_spi_dma_client); >> +       sdd->ops->release(sdd->tx_ch, &s3c64xx_spi_dma_client); >>  } > > Btw, this spi driver is for S3C64xx(with pl080) and S5P(with pl330) > series, both of which > have DMAENGINE drivers. May be it could be directly switched to using > those, rather than > via Samsung's wrapper driver. > Or am I overlooking something ? Exactly, spi_s3c64xx.c (including Sound driver) can not be used with pl080 and pl330 (DMAENGINE drivers) as it is. Recently I was trying to use PL080 DMAENGINE driver, and i was ended up using some #ifdef in the spi driver. something like #ifdef CONFIG_PL080 sdd->tx_dmac.bus_id = dmatx_res->name; sdd->rx_dmac.bus_id = dmarx_res->name; #else sdd->tx_dmac.bus_id = dmatx_res->start; sdd->tx_dmac.bus_id = dmatx_res->start; #endif This is because, Pl080 handle the channel as a char *(name) and pl330 expect the channel to be enum (a number). I think the solution could be changes in the either of these drivers to follow some symmetry or we will be ending up with two client driver for the same device or writing up some unnecessary warper code or finally using some #ifdef. Please suggest if you guys have any other idea/approach to handle such kind of situation. Below is the git diff of spi_s3c64xx driver using with PL080 DMAENGINE driver. This patch is against kgene's next-samsung-dma-v4 ------------------------------------------------------------------------------------------------------------------ } @@ -982,7 +996,6 @@ static int __init s3c64xx_spi_probe(struct platform_device *pdev) } /* Check for availability of necessary resource */ - dmatx_res = platform_get_resource(pdev, IORESOURCE_DMA, 0); if (dmatx_res == NULL) { dev_err(&pdev->dev, "Unable to get SPI-Tx dma resource\n"); @@ -1015,9 +1028,13 @@ static int __init s3c64xx_spi_probe(struct platform_device *pdev) sdd->cntrlr_info = sci; sdd->pdev = pdev; sdd->sfr_start = mem_res->start; +#ifdef CONFIG_DMADEV_PL080 + sdd->tx_dmach.bus_id = dmatx_res->name; + sdd->rx_dmach.bus_id = dmarx_res->name; +#else sdd->tx_dmach = dmatx_res->start; sdd->rx_dmach = dmarx_res->start; - +#endif sdd->cur_bpw = 8; master->bus_num = pdev->id; @@ -1105,7 +1122,6 @@ static int __init s3c64xx_spi_probe(struct platform_device *pdev) dev_dbg(&pdev->dev, "\tIOmem=[0x%x-0x%x]\tDMA=[Rx-%d, Tx-%d]\n", mem_res->end, mem_res->start, sdd->rx_dmach, sdd->tx_dmach); - return 0; err8: ---------------------------------------------------------------------------------------------------------------------- Regards, Alim > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel > diff --git a/drivers/spi/spi_s3c64xx.c b/drivers/spi/spi_s3c64xx.c index a4cf76a..f7b9c37 100644 --- a/drivers/spi/spi_s3c64xx.c +++ b/drivers/spi/spi_s3c64xx.c @@ -24,6 +24,7 @@ #include #include #include +#include #include #include @@ -165,8 +166,13 @@ struct s3c64xx_spi_driver_data { struct work_struct work; struct list_head queue; spinlock_t lock; +#ifdef CONFIG_DMADEV_PL080 + struct pl08x_channel_data rx_dmach; + struct pl08x_channel_data tx_dmach; +#else enum dma_ch rx_dmach; enum dma_ch tx_dmach; +#endif unsigned long sfr_start; struct completion xfer_completion; unsigned state; @@ -753,10 +759,18 @@ static int acquire_dma(struct s3c64xx_spi_driver_data *sdd) info.direction = DMA_FROM_DEVICE; info.fifo = sdd->sfr_start + S3C64XX_SPI_RX_DATA; info.width = sdd->cur_bpw / 8; +#ifdef CONFIG_DMADEV_PL080 + sdd->rx_ch = sdd->ops->request(sdd->rx_dmach.bus_id, &info); +#else sdd->rx_ch = sdd->ops->request(sdd->rx_dmach, &info); +#endif info.direction = DMA_TO_DEVICE; info.fifo = sdd->sfr_start + S3C64XX_SPI_TX_DATA; - sdd->tx_ch = sdd->ops->request(sdd->tx_dmach, &info); +#ifdef CONFIG_DMADEV_PL080 + sdd->tx_ch = sdd->ops->request(sdd->tx_dmach.bus_id, &info); +#else + sdd->tx_ch = sdd->ops->request(sdd->tx_dmach, &info); +#endif return 1;