From patchwork Fri Oct 18 17:04:11 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kevin Hilman X-Patchwork-Id: 3069061 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 6883A9F372 for ; Fri, 18 Oct 2013 17:04:44 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 565AC203B4 for ; Fri, 18 Oct 2013 17:04:43 +0000 (UTC) Received: from casper.infradead.org (casper.infradead.org [85.118.1.10]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 125C220398 for ; Fri, 18 Oct 2013 17:04:42 +0000 (UTC) Received: from merlin.infradead.org ([2001:4978:20e::2]) by casper.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1VXDTa-0003pJ-Bm; Fri, 18 Oct 2013 17:04:38 +0000 Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1VXDTY-00026r-0X; Fri, 18 Oct 2013 17:04:36 +0000 Received: from mail-wg0-f51.google.com ([74.125.82.51]) by merlin.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1VXDTV-00025R-5O for linux-arm-kernel@lists.infradead.org; Fri, 18 Oct 2013 17:04:33 +0000 Received: by mail-wg0-f51.google.com with SMTP id l18so4060545wgh.30 for ; Fri, 18 Oct 2013 10:04:11 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=aKPwsWBPMdDRKl6AHpWN04NzbO9wVE6VwtbNz/ejovU=; b=csXB/jFE5d54N48I7QPEFzwP3/ZEJe3Rd7e2psiyd5xDFiONsiuhtkWVIJtEvRXtgM g/BT1gly688N6K40qzauN4FpFF0+HsCwfh9qHszDOotmPrZAEI97WaYOVHTD8+zQO551 xH2CEUp5DiwWH2OIXdYJXeDh1vGshoZ+F96zaSavDqmoPQ7JtUGrdulH8fQtvT2FH+N4 t4rIC0F9av9uSMjaW6Z+eg1iST3HzGH7QO1YgZNQ9+Vt1cxCWgkde/SRjd5ZNlJOHrA4 8lZ8IXoFHVZmgD5e/3iOrDmxgKcZ9OvatwhTmobgl+TKGFDqarM4vy30UvMxboWc8X/J 3djQ== X-Gm-Message-State: ALoCoQlIKUb9DER8hJJBmmkgYuei8WdhRtRpGqLDDftCmw013vrJ+oZRjEvFhKvrJLuwJEVLV59F MIME-Version: 1.0 X-Received: by 10.194.175.66 with SMTP id by2mr2563135wjc.59.1382115851235; Fri, 18 Oct 2013 10:04:11 -0700 (PDT) Received: by 10.180.198.51 with HTTP; Fri, 18 Oct 2013 10:04:11 -0700 (PDT) In-Reply-To: References: <1381296747.2040.17.camel@joe-AO722> <20131011131138.3bc5b2acf60df3a5d79d0d24@linux-foundation.org> Date: Fri, 18 Oct 2013 10:04:11 -0700 Message-ID: Subject: Re: [RFC PATCH] device: Add kernel standard devm_k.alloc functions From: Kevin Hilman To: Andrew Morton X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20131018_130433_314887_234FB274 X-CRM114-Status: GOOD ( 18.31 ) X-Spam-Score: -2.6 (--) Cc: Sangjung Woo , Greg KH , Olof Johansson , LKML , Tejun Heo , Thierry Reding , linux-arm-kernel , Joe Perches , Guenter Roeck X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-4.6 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP > A handful of boot panics on ARM platforms were bisected to point at > the version of this commit that's in linux-next (commit > 64c862a839a8db2c02bbaa88b923d13e1208919d). Reverting this commit > makes things happy again. > > Upon further digging, it seems that users of devres_alloc() are > relying on the previous behavior of having the memory zero'd which is > no longer the case after $SUBJECT patch. The change below on top of > -next makes these ARM boards happy again. Oops, it should've fixed __devres_alloc() also. Updated patch below. Kevin From a1962ed4a999fb630a48f75a5ecaf84401d5dbfc Mon Sep 17 00:00:00 2001 From: Kevin Hilman Date: Fri, 18 Oct 2013 09:41:39 -0700 Subject: [PATCH] devres: restore zeroing behavior of devres_alloc() commit 64c862a8 (devres: add kernel standard devm_k.alloc functions) changed the default behavior of alloc_dr() to no longer zero the allocated memory. However, only the devm.k.alloc() function were modified to pass in __GFP_ZERO which leaves any users of devres_alloc() or __devres_alloc() with potentially wrong assumptions about memory being zero'd upon allocation. To fix, add __GFP_ZERO to devres_alloc() calls to preserve previous behavior of zero'ing memory upon allocation. Signed-off-by: Kevin Hilman --- drivers/base/devres.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) set_node_dbginfo(&dr->node, name, size); @@ -136,7 +136,7 @@ void * devres_alloc(dr_release_t release, size_t size, gfp_t gfp) { struct devres *dr; - dr = alloc_dr(release, size, gfp); + dr = alloc_dr(release, size, gfp | __GFP_ZERO); if (unlikely(!dr)) return NULL; return dr->data; diff --git a/drivers/base/devres.c b/drivers/base/devres.c index 37e67a2..545c4de 100644 --- a/drivers/base/devres.c +++ b/drivers/base/devres.c @@ -111,7 +111,7 @@ void * __devres_alloc(dr_release_t release, size_t size, gfp_t gfp, { struct devres *dr; - dr = alloc_dr(release, size, gfp); + dr = alloc_dr(release, size, gfp | __GFP_ZERO); if (unlikely(!dr)) return NULL;