From patchwork Wed Dec 12 03:00:35 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Viresh Kumar X-Patchwork-Id: 1864491 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork1.kernel.org Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) by patchwork1.kernel.org (Postfix) with ESMTP id 5C21E3FCA5 for ; Wed, 12 Dec 2012 03:03:31 +0000 (UTC) Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.76 #1 (Red Hat Linux)) id 1TicYr-0005IJ-Dg; Wed, 12 Dec 2012 03:00:41 +0000 Received: from mail-ie0-f176.google.com ([209.85.223.176]) by merlin.infradead.org with esmtps (Exim 4.76 #1 (Red Hat Linux)) id 1TicYn-0005Hu-Vv for linux-arm-kernel@lists.infradead.org; Wed, 12 Dec 2012 03:00:38 +0000 Received: by mail-ie0-f176.google.com with SMTP id 13so505063iea.7 for ; Tue, 11 Dec 2012 19:00:35 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:x-gm-message-state; bh=8QF+UaHwAOtYc01wdvZjjS8IN5tJtfdxMnhkD+MPSg4=; b=XJuOrLd32VC3HnCflaBGOybxlnW+TeEYHBQtJ+ejoV2K/ph1Sc8hqo1gWpzqUekWgK jUTqvR3DtRED3wfFCtIgoUsC7kJCMtJ5/6eeFfk2YDcitDxK3mpKBIFpt/SR8D5OMHEr ZuswtRF4+nSLSYEOMWl52yjF6h+dch5w+cr9rCymcAPbvEh1hvgoeRkHvxKfsnQtW91Q Kmq965fx58p0Y5zzvjiiRuT7GHOaFYEaB35i8p6NscdXyJyDr6UYlIS9FCqt6+9i7JtD oa2HN3Poa1o8ZZUy+SyGbx2tmCeKwYlQg15vKXhVKwtQePuTI/UjA874RInSWdH6bLdn xMug== MIME-Version: 1.0 Received: by 10.50.219.169 with SMTP id pp9mr12207434igc.46.1355281235408; Tue, 11 Dec 2012 19:00:35 -0800 (PST) Received: by 10.64.103.229 with HTTP; Tue, 11 Dec 2012 19:00:35 -0800 (PST) In-Reply-To: <201212102208.52347.arnd@arndb.de> References: <3100e691db3f94c22afd98b609a1568d7e70dfe7.1350360935.git.viresh.kumar@linaro.org> <169edae67b9a051ca7448e5b62c3cd2c5c1db470.1350360935.git.viresh.kumar@linaro.org> <201212102208.52347.arnd@arndb.de> Date: Wed, 12 Dec 2012 08:30:35 +0530 Message-ID: Subject: Re: [PATCH V3 2/3] dmaengine: dw_dmac: Enhance device tree support From: Viresh Kumar To: Arnd Bergmann , Vinod Koul X-Gm-Message-State: ALoCoQkj886teTh97mrVEGyi1ar62hVdwn7cJGbqDmtNc3K22t/UbFdyPjQuKQqcyAjLZFrAkXnz X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20121211_220038_087911_3B309B67 X-CRM114-Status: GOOD ( 21.14 ) X-Spam-Score: -2.6 (--) X-Spam-Report: SpamAssassin version 3.3.2 on merlin.infradead.org summary: Content analysis details: (-2.6 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low trust [209.85.223.176 listed in list.dnswl.org] -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] Cc: andriy.shevchenko@linux.intel.com, devicetree-discuss@lists.ozlabs.org, spear-devel@list.st.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-arm-kernel-bounces@lists.infradead.org Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org Sorry for replying late, was too busy with other work yesterday. On 11 December 2012 03:38, Arnd Bergmann wrote: > I'm deeply sorry for the very late complaint on this, but I only now Better late than never :) > noticed this patch as I was seeing build breakage in linux-next > because of it. Oops!! Here is a fix for that Author: Viresh Kumar Date: Wed Dec 12 08:28:07 2012 +0530 ARM: SPEAr1310: Fix CF DMA data We need to pass string with device-channel name to dma controller instead of dma controller specific dma struct. Fix CF dma data. Signed-off-by: Viresh Kumar --- arch/arm/mach-spear13xx/spear1310.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) > > * It does not follow the binding from > Documentation/devicetree/bindings/dma/dma.txt When i patched it, this patch wasn't there in linux-next/master. Probably was getting reviewed somewhere :) > * It requires slave drivers to know that they are using the dw_dmac > driver and pass a pointer to dw_generic_filter, which is not > generic at all > > * It requires the dmac node to have information about all slaves > > There are also some minor issues, such as the naming of DT > properties, but the above need to be resolved first. I saw the binding document and it looks it can be applied to dw_dmac too, as there is nothing special for it. The question is how? We are already late for merge window and this one is queued. Supplying a new patch, getting it reviewed/tested and being pulled by Linus is not so easy :) Two ways: - Keep it as is, and i will fix it separately and quickly - Drop it :( -- viresh diff --git a/arch/arm/mach-spear13xx/spear1310.c b/arch/arm/mach-spear13xx/spear1310.c index f65ad5b..54f0e2e 100644 --- a/arch/arm/mach-spear13xx/spear1310.c +++ b/arch/arm/mach-spear13xx/spear1310.c @@ -36,7 +36,7 @@ static struct arasan_cf_pdata cf_pdata = { .cf_if_clk = CF_IF_CLK_166M, .quirk = CF_BROKEN_UDMA, - .dma_priv = &cf_dma_priv, + .dma_priv = "cf", }; > Viresh, there are multiple problems with your approach unfortunately: