| Message ID | CAKohpo=JuyVmSRFs1wpqvvmouRpL+d8ms-o4UC74OJqAgFv7Vw@mail.gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 03/24/2013 11:19 PM, Viresh Kumar wrote: > On 24 March 2013 19:18, Viresh Kumar <viresh.kumar@linaro.org> wrote: >> policy->cpus contains all online cpus that have single shared clock line. And >> their frequencies are always updated together. >> >> Many SMP system's cpufreq drivers take care of this in individual drivers but >> the best place for this code is in cpufreq core. >> >> This patch modifies cpufreq_notify_transition() to notify frequency change for >> all cpus in policy->cpus and hence updates all users of this API. > > Another fixup for tegra: This series including this patch (although I had a devil of a time applying this fixup since all the TABs got converted to spaces when it was pasted into email) Acked-by: Stephen Warren <swarren@nvidia.com> Tested-by: Stephen Warren <swarren@nvidia.com>
On 25 March 2013 22:18, Stephen Warren <swarren@wwwdotorg.org> wrote: > On 03/24/2013 11:19 PM, Viresh Kumar wrote: >> On 24 March 2013 19:18, Viresh Kumar <viresh.kumar@linaro.org> wrote: >>> policy->cpus contains all online cpus that have single shared clock line. And >>> their frequencies are always updated together. >>> >>> Many SMP system's cpufreq drivers take care of this in individual drivers but >>> the best place for this code is in cpufreq core. >>> >>> This patch modifies cpufreq_notify_transition() to notify frequency change for >>> all cpus in policy->cpus and hence updates all users of this API. >> >> Another fixup for tegra: > > This series including this patch (although I had a devil of a time > applying this fixup since all the TABs got converted to spaces when it > was pasted into email) So sorry for that, I keep pushing them here: http://git.linaro.org/gitweb?p=people/vireshk/linux.git;a=shortlog;h=refs/heads/cpufreq-fix-notify
diff --git a/arch/arm/mach-tegra/cpu-tegra.c b/arch/arm/mach-tegra/cpu-tegra.c index 3b441d6..11ca730 100644 --- a/arch/arm/mach-tegra/cpu-tegra.c +++ b/arch/arm/mach-tegra/cpu-tegra.c @@ -106,7 +106,8 @@ out: return ret; } -static int tegra_update_cpu_speed(unsigned long rate) +static int tegra_update_cpu_speed(struct cpufreq_policy *policy, + unsigned long rate) { int ret = 0; struct cpufreq_freqs freqs; @@ -179,7 +180,7 @@ static int tegra_target(struct cpufreq_policy *policy, target_cpu_speed[policy->cpu] = freq; - ret = tegra_update_cpu_speed(tegra_cpu_highest_speed()); + ret = tegra_update_cpu_speed(policy, tegra_cpu_highest_speed()); out: mutex_unlock(&tegra_cpu_lock); @@ -191,10 +192,12 @@ static int tegra_pm_notify(struct notifier_block *nb, unsigned long event, { mutex_lock(&tegra_cpu_lock); if (event == PM_SUSPEND_PREPARE) { + struct cpufreq_policy *policy = cpufreq_cpu_get(0); is_suspended = true; pr_info("Tegra cpufreq suspend: setting frequency to %d kHz\n", freq_table[0].frequency); - tegra_update_cpu_speed(freq_table[0].frequency); + tegra_update_cpu_speed(policy, freq_table[0].frequency); + cpufreq_cpu_put(policy); } else if (event == PM_POST_SUSPEND) { is_suspended = false;