From patchwork Tue Sep 30 14:45:20 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: dann frazier X-Patchwork-Id: 5003761 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id D83559F2F0 for ; Tue, 30 Sep 2014 14:47:42 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 197E62018E for ; Tue, 30 Sep 2014 14:47:42 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2ABC620136 for ; Tue, 30 Sep 2014 14:47:41 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1XYygT-0005c0-BM; Tue, 30 Sep 2014 14:45:45 +0000 Received: from mail-wg0-f47.google.com ([74.125.82.47]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1XYygR-0005Ty-4W for linux-arm-kernel@lists.infradead.org; Tue, 30 Sep 2014 14:45:43 +0000 Received: by mail-wg0-f47.google.com with SMTP id x13so513717wgg.18 for ; Tue, 30 Sep 2014 07:45:20 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=uSEwqDngWfqir0Mx6HCO+wr9ENX440GRVPKIOlx40Ps=; b=KEMA0YUPykiU5rt2ms8+8n7dIiCBmmr2Nz3I2grbNwtSTlczlX6MwaFd6Tt5M82FvU o80WE7rlF50Ul1qs1/QxaoTX/di+FKuVHYlD/gEOo2nHE5+bn7vEchOvzNuDTrXoHnpU odEOhxRT6EXA3J90EIWLzZieHC4k8IXuJvOGle6xv5A6daEpe4PnHtjYFOObiK5XSvSk Tqgjnxr8fxIc2SMOT8kJWCaqJ/1Ogh0+nM4gqcxjpX8gaUro3gpThyMn90cRyFLJeAOO eWk4G0HH2yim52I8pGzjzVrsezUIKjYK2H/2wY09U9JVFeWs9Yk/3rDqZXg/VRYxfdV4 U1dg== X-Gm-Message-State: ALoCoQmuLnF4QSXenVNZ8Su1PiIxSjxAy2np0zVU2Hnew50fsW4+1Y+HXxZNcBsaIfzJOT/E+427 MIME-Version: 1.0 X-Received: by 10.194.236.35 with SMTP id ur3mr4256409wjc.127.1412088320374; Tue, 30 Sep 2014 07:45:20 -0700 (PDT) Received: by 10.217.139.135 with HTTP; Tue, 30 Sep 2014 07:45:20 -0700 (PDT) In-Reply-To: <1408778588-3215-4-git-send-email-lho@apm.com> References: <1408778588-3215-1-git-send-email-lho@apm.com> <1408778588-3215-2-git-send-email-lho@apm.com> <1408778588-3215-3-git-send-email-lho@apm.com> <1408778588-3215-4-git-send-email-lho@apm.com> Date: Tue, 30 Sep 2014 08:45:20 -0600 Message-ID: Subject: Re: [PATCH v5 3/4] edac: Add APM X-Gene SoC EDAC driver From: Dann Frazier To: Loc Ho X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20140930_074543_334993_8C46C420 X-CRM114-Status: GOOD ( 15.44 ) X-Spam-Score: -0.7 (/) Cc: Mark Rutland , "devicetree@vger.kernel.org" , Ian Campbell , Jon Masters , patches@apm.com, Feng Kan , Rob Herring , Borislav Petkov , dougthompson@xmission.com, Craig Magina , linux-edac@vger.kernel.org, linux-arm-kernel , m.chehab@samsung.com X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_NONE, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On Sat, Aug 23, 2014 at 1:23 AM, Loc Ho wrote: > This patch adds support for the APM X-Gene SoC EDAC driver. It > requires ARM64 EDAC support patch [1] to compile due to > dependence on MC module which calls an unused software memory > scrub function. > > [1] http://www.spinics.net/lists/arm-kernel/msg324093.html > > Signed-off-by: Feng Kan > Signed-off-by: Loc Ho > --- > drivers/edac/Kconfig | 9 +- > drivers/edac/Makefile | 3 + > drivers/edac/xgene_edac.c | 2132 +++++++++++++++++++++++++++++++++++++++++++++ > 3 files changed, 2143 insertions(+), 1 deletions(-) > create mode 100644 drivers/edac/xgene_edac.c > [...] > +#ifdef CONFIG_OF > +static struct of_device_id xgene_edac_mc_of_match[] = { > + { .compatible = "apm,xgene-edac-mc" }, > + {}, > +}; > +MODULE_DEVICE_TABLE(of, xgene_edac_of_match); > +#endif Something I apparently forgot to mention when I tested v3 was that I had to manually fix this up to get it to build: diff --git a/drivers/edac/xgene_edac.c b/drivers/edac/xgene_edac.c index d69c2e5..2f436d45 100644 --- a/drivers/edac/xgene_edac.c +++ b/drivers/edac/xgene_edac.c @@ -452,7 +452,7 @@ static struct of_device_id xgene_edac_mc_of_match[] = { { .compatible = "apm,xgene-edac-mc" }, {}, }; -MODULE_DEVICE_TABLE(of, xgene_edac_of_match); +MODULE_DEVICE_TABLE(of, xgene_edac_mc_of_match); #endif static struct platform_driver xgene_edac_mc_driver = {