From patchwork Fri May 22 15:29:20 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Maxime Coquelin X-Patchwork-Id: 6465531 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id AC4369F1C1 for ; Fri, 22 May 2015 15:31:56 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id CF48D204AD for ; Fri, 22 May 2015 15:31:55 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id F418B204AB for ; Fri, 22 May 2015 15:31:54 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1Yvota-0003jR-8I; Fri, 22 May 2015 15:29:58 +0000 Received: from mail-wg0-x230.google.com ([2a00:1450:400c:c00::230]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1YvotL-0003Xf-3B for linux-arm-kernel@lists.infradead.org; Fri, 22 May 2015 15:29:44 +0000 Received: by wgbgq6 with SMTP id gq6so21200915wgb.3 for ; Fri, 22 May 2015 08:29:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=448uA6g63ermnMnXlkfttTafD1WoTFniJ0ERqcFzGiE=; b=is593WIV8H20kiQFKXf5KXGm0JYcjipjW1LmPnLJmyYenFgdzqFieJnNDXhvIHJMk9 khkO4sqZikF5fCRdpfJ5EjrXTH2yKFY/ibIYjJfOJHCvWZFQepNx+fI1MNYCYbfdwqha etQeaR0HzMg61wk8HBNYR377RWLsL+Ctub4Q86U4NvVZDh2eLEublY3atswtxz5f2LTi XzDGzOukaOJ7Wk0R1k9xzJH/q0fAenETPY8EpL5n4gzhJ9UhiUaC4Rt3ChKtjvOghk4V crkdylYxvImr3KHByROLDx1fcWcBQKHxIGr9hT5FVNulI0mQKghRRopszJArGV8Bw2bs tyqw== MIME-Version: 1.0 X-Received: by 10.194.60.106 with SMTP id g10mr16508060wjr.121.1432308560954; Fri, 22 May 2015 08:29:20 -0700 (PDT) Received: by 10.27.63.3 with HTTP; Fri, 22 May 2015 08:29:20 -0700 (PDT) In-Reply-To: <15864413.ed8EFg1NLl@wuerfel> References: <1432161344-1930-1-git-send-email-stefan@agner.ch> <15864413.ed8EFg1NLl@wuerfel> Date: Fri, 22 May 2015 17:29:20 +0200 Message-ID: Subject: Re: [PATCH soc] ARM: use ARM_SINGLE_ARMV7M for ARMv7-M platforms From: Maxime Coquelin To: Arnd Bergmann X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20150522_082943_336000_3638B393 X-CRM114-Status: GOOD ( 11.39 ) X-Spam-Score: -0.6 (/) Cc: Russell King , manabian@gmail.com, "linux-kernel@vger.kernel.org" , Stefan Agner , =?UTF-8?Q?Uwe_Kleine=2DK=C3=B6nig?= , olof@lixom.net, "linux-arm-kernel@lists.infradead.org" X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-4.1 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_MED, T_DKIM_INVALID, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP 2015-05-22 16:50 GMT+02:00 Arnd Bergmann : > [one small request as I have four armv7-m folks on Cc already: > could one of you try to fix the warning that I get with every > single build: "/git/arm-soc/arch/arm/kernel/head-nommu.S: Assembler > messages: /git/arm-soc/arch/arm/kernel/head-nommu.S:167: Warning: > Use of r13 as a source register is deprecated when r15 is the > destination register."] Moving r13 to r12 and returning r12 seems to do the job (see below). But I don't know if there is a more elegant way, and if it is also valid for other architectures than armv7-m. I can propose a patch if someone can confirm it is valid. Regards, Maxime ------------------------------------------------------------------------------------------------------------- diff --git a/arch/arm/kernel/head-nommu.S b/arch/arm/kernel/head-nommu.S index aebfbf7..e84bdad 100644 --- a/arch/arm/kernel/head-nommu.S +++ b/arch/arm/kernel/head-nommu.S @@ -164,7 +164,8 @@ __after_proc_init: #endif mcr p15, 0, r0, c1, c0, 0 @ write control reg #endif /* CONFIG_CPU_CP15 */ - ret r13 + mov r12, r13 + ret r12 ENDPROC(__after_proc_init) .ltorg