From patchwork Thu Jul 6 20:45:32 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Cong Wang X-Patchwork-Id: 9828955 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 07434602CA for ; Thu, 6 Jul 2017 20:46:23 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id E94FA2856F for ; Thu, 6 Jul 2017 20:46:22 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id D982028585; Thu, 6 Jul 2017 20:46:22 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FROM autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [65.50.211.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 614FD2853D for ; Thu, 6 Jul 2017 20:46:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: References:In-Reply-To:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=fb+/yGFmdXATr2VLa1HWzb5gRU0ZwTbeHZHkBeTbxh4=; b=V3BmDZEB5UTb9N HGICJNc17K+yXnWMakQ89IKmYTeB4UBpd+Qh1Y5SV45HR1k58ctPtzXwaC1YepgXLTvY1QPrGLDWU XCwL4Pd2CGMaEn5mnvD6N7KFLYe0D33EngCcCL3zShLb1qx2o7Xg0b0cVKSNvnhY8Orhb+8u7Lin8 mmoEpbrX/WXto6aPK5nUchteWwHoWvZqR0aoo9ksz5P7XMZnxK8yfamfavb0gFyuOigSRBOlXuEDU XwVg1KL42PftYRamPfN+OuZ+ON6gybLiqzbeSuVTZxKwu4iRf09sa/aym9oo3PWZiuO80P9PIFyiq QhsHVQusEKXcIIRxOByA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux)) id 1dTDfH-0003Z3-D6; Thu, 06 Jul 2017 20:46:19 +0000 Received: from mail-wr0-x230.google.com ([2a00:1450:400c:c0c::230]) by bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux)) id 1dTDfD-0003XZ-J4 for linux-arm-kernel@lists.infradead.org; Thu, 06 Jul 2017 20:46:17 +0000 Received: by mail-wr0-x230.google.com with SMTP id r103so19132024wrb.0 for ; Thu, 06 Jul 2017 13:45:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=e5qhrVVP0FhkZOIDBB1khPyB7QlHcsTxg5bg6cVm9fQ=; b=Z0424iBV9RiOC8uWn3g7RyNIqLMibTqakaFHse7iI9oNQvTOWknpA78cDpxzrSOZpg cSp3N3v+YrX1hDfdsyFhKtIbDf+tklyoYyoni+cfQdSN8iBHT6ZA/hn+2zykiySB0a3u qoEIEVaQL+DcnZvpZSy+1h7bdjLruArziFjtzzYukHQH/4SUPgShwsw6Cz9rQhAm6bDj u1qMY3JJa8hRitu9nhxDkTvLHD2kWr515RKvftrFv+IGpkyQNxepahv8kV8XhmnHSca4 guorjK6nZ3OSSi499MkSTYhbOuOUWel3aKIZN2C66SUIGoa8DlBtww82ayOwNBdXqOFh QZwg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=e5qhrVVP0FhkZOIDBB1khPyB7QlHcsTxg5bg6cVm9fQ=; b=sHDCY5oQlnu6cwU+oxHfarN8a34UEovz7kuEsGE1UgZwD8cGGnwGfXKDDPwzhbKuxA /AG9Zr9TJzizMgCbCptd3t9O3BhADDrfgM7vMEIoysQRxeynoFz0jep3GzvW5utGxUfs YWWRDzg5DvBDJoBEL+EZjGIZqETa3U3KbsfVWF780om2j4jeAZw1AxzJb3rdvIJKMQrz egQE3yFTRaVdoWKDYnCNGB+NXY406+aQHyVswev/CHT/0V8J2lqd0/ko9pF2a2jDqp1t v25qtia1ajfXDLBTaSMzHenRiZLPp8FPCIAqJb5LiGsSNjgU7eEDkj89fXJt4VJlh5Up vgjg== X-Gm-Message-State: AIVw111+m3f41CfpZ9yB8nAw2Q/5BcodCnxjyGOdSoN/LAc6xRVs8Oof OGqkrFhYEEtDFyDZiYRVn49ycrv3Pw== X-Received: by 10.80.159.165 with SMTP id c34mr603211edf.11.1499373953101; Thu, 06 Jul 2017 13:45:53 -0700 (PDT) MIME-Version: 1.0 Received: by 10.80.169.80 with HTTP; Thu, 6 Jul 2017 13:45:32 -0700 (PDT) In-Reply-To: <20170706180337.GA26875@amd> References: <20170706180337.GA26875@amd> From: Cong Wang Date: Thu, 6 Jul 2017 13:45:32 -0700 Message-ID: Subject: Re: v4.13-rc0 on nokia n900: spinlock bad magic To: Pavel Machek X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20170706_134615_785207_21A1F286 X-CRM114-Status: GOOD ( 11.28 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: ivo.g.dimitrov.75@gmail.com, khilman@kernel.org, tony@atomide.com, aaro.koskinen@iki.fi, kernel list , sre@kernel.org, abcloriens@gmail.com, pali.rohar@gmail.com, linux-omap@vger.kernel.org, patrikbachan@gmail.com, linux-arm-kernel , serge@hallyn.com Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP On Thu, Jul 6, 2017 at 11:03 AM, Pavel Machek wrote: > Hi! > > I don't think this is new in v4.13, but perhaps someone knows how to > debug it? > > [ 5611.801147] g_ether gadget: packet filter 0e > [ 5611.801177] g_ether gadget: ecm req21.43 v000e i0000 l0 > [ 5668.771453] BUG: spinlock bad magic on CPU#0, kworker/u2:3/9745 > [ 5668.771850] lock: 0xce63ef20, .magic: 00000000, .owner: /-1, > .owner_cpu: 0 > [ 5668.772277] CPU: 0 PID: 9745 Comm: kworker/u2:3 Tainted: G W > 4.12.0-03002-gec979a4-dirty #40 > [ 5668.772796] Hardware name: Nokia RX-51 board > [ 5668.773071] Workqueue: phy1 wl1251_irq_work > [ 5668.773345] [] (unwind_backtrace) from [] > (show_stack+0x10/0x14) > [ 5668.773803] [] (show_stack) from [] > (do_raw_spin_lock+0x6c/0xa0) > [ 5668.774230] [] (do_raw_spin_lock) from [] > (_raw_spin_lock_irqsave+0x10/0x18) > [ 5668.774658] [] (_raw_spin_lock_irqsave) from [] > (wl1251_op_tx+0x38/0x5c) > [ 5668.775115] [] (wl1251_op_tx) from [] > (ieee80211_tx_frags+0x188/0x1c0) The following one-line fix should work. diff --git a/drivers/net/wireless/ti/wl1251/main.c b/drivers/net/wireless/ti/wl1251/main.c index bbf7604..1c539c8 100644 --- a/drivers/net/wireless/ti/wl1251/main.c +++ b/drivers/net/wireless/ti/wl1251/main.c @@ -1571,6 +1571,7 @@ struct ieee80211_hw *wl1251_alloc_hw(void) wl->state = WL1251_STATE_OFF; mutex_init(&wl->mutex); + spin_lock_init(&wl->wl_lock); wl->tx_mgmt_frm_rate = DEFAULT_HW_GEN_TX_RATE; wl->tx_mgmt_frm_mod = DEFAULT_HW_GEN_MODULATION_TYPE;