From patchwork Mon Jan 14 15:40:28 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Christoffer Dall X-Patchwork-Id: 1972601 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork1.kernel.org Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) by patchwork1.kernel.org (Postfix) with ESMTP id 7D5F73FE33 for ; Mon, 14 Jan 2013 15:43:52 +0000 (UTC) Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.76 #1 (Red Hat Linux)) id 1Tum9V-0008PO-Lt; Mon, 14 Jan 2013 15:40:46 +0000 Received: from mail-vb0-f43.google.com ([209.85.212.43]) by merlin.infradead.org with esmtps (Exim 4.76 #1 (Red Hat Linux)) id 1Tum9G-0008N0-N2 for linux-arm-kernel@lists.infradead.org; Mon, 14 Jan 2013 15:40:36 +0000 Received: by mail-vb0-f43.google.com with SMTP id fs19so3698554vbb.30 for ; Mon, 14 Jan 2013 07:40:29 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:x-originating-ip:in-reply-to:references:date :message-id:subject:from:to:cc:content-type:x-gm-message-state; bh=nknU6YLZ/5d3x3+s0mfblfsl5yPYTA1XR4c97iAx5jk=; b=bJjP8426d12FrsIO26xTzdbNadjvY0zXYlm4zD9KXYsjAZPZeyZCC0rmMSUL8QbeOA nxFAefjULHZ0bpQnIsbdMOSUUCIUNzj3sP1HqVl/yqtn337arpRI3WAywwk8oCRMl7jD OkRQeZd3oPRn9XSED60y2Eu6uvGZJO3BeurvbXpssaC0P/BOPzWrQUCo7JFBh2xUOeLu +FAKABNB40CVxQygehmgx1PJQyiT8vq81NNfyBktdaWY9OZWeZw25R1FoR3+i8QgRjEE gofXWeOczROkcMipxziLoUAivySlHAeTfRGJPvIc/5uOq0o3osqyJ6YB2aSCK1Lup7PZ 6+bg== MIME-Version: 1.0 Received: by 10.58.168.135 with SMTP id zw7mr103919339veb.4.1358178028858; Mon, 14 Jan 2013 07:40:28 -0800 (PST) Received: by 10.221.7.71 with HTTP; Mon, 14 Jan 2013 07:40:28 -0800 (PST) X-Originating-IP: [72.80.83.148] In-Reply-To: <20130114150917.GA18935@mudshark.cambridge.arm.com> References: <20130108183811.46302.58543.stgit@ubuntu> <20130108183855.46302.40539.stgit@ubuntu> <20130114150917.GA18935@mudshark.cambridge.arm.com> Date: Mon, 14 Jan 2013 10:40:28 -0500 Message-ID: Subject: Re: [PATCH v5 03/14] KVM: ARM: Initial skeleton to compile KVM support From: Christoffer Dall To: Will Deacon X-Gm-Message-State: ALoCoQmDyyGDz/H/Zxt4I6TkaZnG5pbWxdGtr2+nMT62Wfv4gvAIaqD/sPFzlOvVWztVzOPq64H1 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20130114_104035_081214_38BCDB21 X-CRM114-Status: GOOD ( 17.97 ) X-Spam-Score: -2.6 (--) X-Spam-Report: SpamAssassin version 3.3.2 on merlin.infradead.org summary: Content analysis details: (-2.6 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low trust [209.85.212.43 listed in list.dnswl.org] -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] Cc: "kvm@vger.kernel.org" , Marc Zyngier , Marcelo Tosatti , Rusty Russell , "kvmarm@lists.cs.columbia.edu" , "linux-arm-kernel@lists.infradead.org" X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-arm-kernel-bounces@lists.infradead.org Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org On Mon, Jan 14, 2013 at 10:09 AM, Will Deacon wrote: > On Tue, Jan 08, 2013 at 06:38:55PM +0000, Christoffer Dall wrote: >> Targets KVM support for Cortex A-15 processors. >> >> Contains all the framework components, make files, header files, some >> tracing functionality, and basic user space API. >> >> Only supported core is Cortex-A15 for now. >> >> Most functionality is in arch/arm/kvm/* or arch/arm/include/asm/kvm_*.h. >> >> Reviewed-by: Marcelo Tosatti >> Signed-off-by: Rusty Russell >> Signed-off-by: Marc Zyngier >> Signed-off-by: Christoffer Dall >> --- >> Documentation/virtual/kvm/api.txt | 57 +++++- >> arch/arm/Kconfig | 2 >> arch/arm/Makefile | 1 >> arch/arm/include/asm/kvm_arm.h | 24 ++ >> arch/arm/include/asm/kvm_asm.h | 58 ++++++ >> arch/arm/include/asm/kvm_coproc.h | 24 ++ >> arch/arm/include/asm/kvm_emulate.h | 50 +++++ >> arch/arm/include/asm/kvm_host.h | 114 ++++++++++++ >> arch/arm/include/uapi/asm/kvm.h | 106 +++++++++++ > > [...] > >> diff --git a/arch/arm/include/uapi/asm/kvm.h b/arch/arm/include/uapi/asm/kvm.h >> new file mode 100644 >> index 0000000..c6298b1 >> --- /dev/null >> +++ b/arch/arm/include/uapi/asm/kvm.h >> @@ -0,0 +1,106 @@ >> +/* >> + * Copyright (C) 2012 - Virtual Open Systems and Columbia University >> + * Author: Christoffer Dall >> + * >> + * This program is free software; you can redistribute it and/or modify >> + * it under the terms of the GNU General Public License, version 2, as >> + * published by the Free Software Foundation. >> + * >> + * This program is distributed in the hope that it will be useful, >> + * but WITHOUT ANY WARRANTY; without even the implied warranty of >> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the >> + * GNU General Public License for more details. >> + * >> + * You should have received a copy of the GNU General Public License >> + * along with this program; if not, write to the Free Software >> + * Foundation, 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA. >> + */ >> + >> +#ifndef __ARM_KVM_H__ >> +#define __ARM_KVM_H__ >> + >> +#include >> +#include > > I think you want linux/types.h, as asm/types.h isn't exported from what I > can tell. make headers_check screams about it too: > > /home/will/sources/linux/linux/usr/include/asm/kvm.h:22: include of is preferred over > /home/will/sources/linux/linux/usr/include/asm/kvm.h:57: found __[us]{8,16,32,64} type without #include > right, fixed: commit 4f880a3224b26a854736f19b21de9d457829940e Author: Christoffer Dall Date: Mon Jan 14 10:39:03 2013 -0500 KVM: ARM: Include linux/types.h instead of asm/types.h Include the right header file. Cc: Will Deacon Signed-off-by: Christoffer Dall --- Thanks, -Christoffer diff --git a/arch/arm/include/uapi/asm/kvm.h b/arch/arm/include/uapi/asm/kvm.h index 972b90d..236f528 100644 --- a/arch/arm/include/uapi/asm/kvm.h +++ b/arch/arm/include/uapi/asm/kvm.h @@ -19,7 +19,7 @@ #ifndef __ARM_KVM_H__ #define __ARM_KVM_H__ -#include +#include #include #define __KVM_HAVE_GUEST_DEBUG