From patchwork Wed Aug 8 06:52:12 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Magnus Damm X-Patchwork-Id: 1292841 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork1.kernel.org Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) by patchwork1.kernel.org (Postfix) with ESMTP id 2BCB43FC23 for ; Wed, 8 Aug 2012 06:54:54 +0000 (UTC) Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.76 #1 (Red Hat Linux)) id 1Sz07t-0007rx-IR; Wed, 08 Aug 2012 06:52:17 +0000 Received: from mail-pb0-f49.google.com ([209.85.160.49]) by merlin.infradead.org with esmtps (Exim 4.76 #1 (Red Hat Linux)) id 1Sz07q-0007rU-KK for linux-arm-kernel@lists.infradead.org; Wed, 08 Aug 2012 06:52:15 +0000 Received: by pbbrq13 with SMTP id rq13so1049549pbb.36 for ; Tue, 07 Aug 2012 23:52:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=QgieIonrCsc6pX0owwzFJ8Sdv7QK5gBs+s7MSYj1PuA=; b=uaeKzLm6H+BOXt97MB9whxQ+i3WlW7t7clJP6tfPFbQWQstwJpnpmJdH0AyTVB6UV1 Wv8K/QrKKsbsRnazgzvoLf9ULCjZts17hA8nfYlXwS4mPisEM6YMe7rex69AqQHu2dOp Hwm50GXvDgg2SHvRRfrPl6IQuxPPcYU6cgSQM/Ixihjfz1m56Cxse0iiZvKeaxen5UM6 qFI4mQeKrDiqY1MvZPXA0ggVnu2eIZS1eraU1EyPlrxrQ5BoctvzaWJNMK0iRyHd5Zz4 3Ark1KSxWw9+WlNZdo0xWRp9NcGaNssEpVsYIiWUKr4jDOcN1f5spCv9uepuNCx8CJoK XhKQ== MIME-Version: 1.0 Received: by 10.68.221.72 with SMTP id qc8mr33696320pbc.63.1344408732755; Tue, 07 Aug 2012 23:52:12 -0700 (PDT) Received: by 10.68.138.135 with HTTP; Tue, 7 Aug 2012 23:52:12 -0700 (PDT) In-Reply-To: <5016D03D.8010607@codeaurora.org> References: <20120611155716.GA18267@n2100.arm.linux.org.uk> <20120611165115.GB18267@n2100.arm.linux.org.uk> <4FD62DBB.8070407@codeaurora.org> <20120611192519.GF18267@n2100.arm.linux.org.uk> <4FE1FB15.3090305@codeaurora.org> <0e0201cd5f2f$2c2f6e60$848e4b20$%kim@samsung.com> <5016D03D.8010607@codeaurora.org> Date: Wed, 8 Aug 2012 15:52:12 +0900 Message-ID: Subject: Re: [PATCH] ARM: formalize an IPI for CPU wake-ups From: Magnus Damm To: Stephen Boyd X-Spam-Note: CRM114 invocation failed X-Spam-Score: -2.7 (--) X-Spam-Report: SpamAssassin version 3.3.2 on merlin.infradead.org summary: Content analysis details: (-2.7 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low trust [209.85.160.49 listed in list.dnswl.org] 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (magnus.damm[at]gmail.com) -0.0 SPF_PASS SPF: sender matches SPF record -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature Cc: Kukjin Kim , Russell King - ARM Linux , Nicolas Pitre , "Rafael J. Wysocki" , Magnus Damm , linux-arm-kernel@lists.infradead.org X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-arm-kernel-bounces@lists.infradead.org Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org On Tue, Jul 31, 2012 at 3:19 AM, Stephen Boyd wrote: > On 07/10/12 23:34, Kukjin Kim wrote: >> Stephen Boyd wrote: >>> Great. Kukjin Kim, can exynos use SGI0? It looks like exynos is the only >>> one left to move to SGI0. >>> >> Yeah, EXYNOS can use SGI0 instead of SGI1 :) >> >> > > Russell, can we apply something like this? > > diff --git a/arch/arm/mach-exynos/platsmp.c b/arch/arm/mach-exynos/platsmp.c > index 36c3984..090e32b 100644 > --- a/arch/arm/mach-exynos/platsmp.c > +++ b/arch/arm/mach-exynos/platsmp.c > @@ -139,7 +139,7 @@ int __cpuinit boot_secondary(unsigned int cpu, struct task_struct *idle) > > __raw_writel(virt_to_phys(exynos4_secondary_startup), > CPU1_BOOT_REG); > - gic_raise_softirq(cpumask_of(cpu), 1); > + gic_raise_softirq(cpumask_of(cpu), 0); > > if (pen_release == -1) > break; > > > I see we have another user of SGI1. Magnus/Rafael, can we move > smp-emev2.c to use SGI0 instead of SGI1? So I finally managed to try this out on my KZM9D board. The SMP bring up code continues to work as expected, so it seems that SGI0 can be used instead of SGI1 on EMEV2. Let's just say that the boot protocol implemented by the mask ROM is rather poorly documented. Anyway, to test I used the following patch on top of linux git 42a579a. So if/where needed, please add my: Acked-by: Magnus Damm Thanks, / magnus --- 0001/arch/arm/mach-shmobile/smp-emev2.c +++ work/arch/arm/mach-shmobile/smp-emev2.c 2012-08-08 15:42:54.000000000 +0900 @@ -82,7 +82,7 @@ int __cpuinit emev2_boot_secondary(unsig /* Tell ROM loader about our vector (in headsmp.S) */ emev2_set_boot_vector(__pa(shmobile_secondary_vector)); - gic_raise_softirq(cpumask_of(cpu), 1); + gic_raise_softirq(cpumask_of(cpu), 0); return 0; }