From patchwork Tue Aug 8 10:29:28 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Magnus Damm X-Patchwork-Id: 9887339 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 90A0F60384 for ; Tue, 8 Aug 2017 10:30:04 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 80EC5287C7 for ; Tue, 8 Aug 2017 10:30:04 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 75A67287C0; Tue, 8 Aug 2017 10:30:04 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, DKIM_VALID, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [65.50.211.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 173BD287C7 for ; Tue, 8 Aug 2017 10:30:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: References:In-Reply-To:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=7z1Tn+pZI+3kwrAt5B3uQD26JneKaNf06ZxxixQD1nk=; b=YEDbEr0wPWasYN 6h62xKPhDPOEV28I4rElpDNKnbQJAuEoHszRpaG8lLt5v2XpuHUaWaR1G8eKk53klR+dBAxi5kbWo AwcTzvdzUqySI1IP3uvCoMNQHsq7OPTt5QDzAbFLAaTBcvRKPx74JnijoF/L8gzr3K+yhPK29aSAV omp2DFfcwoIqY7yvNHUgDLSLVYnVVSj5O2ci9jd52Tsb+H/WqC7Bt+IA36RGC4QJivZMkfdHiyhkX rAR/PJoR8Qv5LhPoGlu/IZS/6HDZtGDkOCX4QPlMPCx16wrNpfyz/S8EBasDfzKOmxRQxb9pZBmIw X+ZEYfYvjLpq4NSyFYiA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux)) id 1df1lr-0006A3-Lz; Tue, 08 Aug 2017 10:29:55 +0000 Received: from mail-wm0-x241.google.com ([2a00:1450:400c:c09::241]) by bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux)) id 1df1lo-00068d-Ak for linux-arm-kernel@lists.infradead.org; Tue, 08 Aug 2017 10:29:54 +0000 Received: by mail-wm0-x241.google.com with SMTP id x64so3465893wmg.1 for ; Tue, 08 Aug 2017 03:29:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=ap0iTyB1JweCvRw5nc5fEIcahopYpgoZY3SVRhcp7oU=; b=F6vY7xnKjgLY4n846vc40ieY4DME7h4JFIqatDtWipnMZwBiGOxulRNi4W6Np/o0MT TLvCabdyHRmlP1GB6EhiGnQx7F/4AmgTYw6+K3O8APGDnlCD/w43phoGnFqQts5qqSc3 ITZlM64X2Syf9gKfUmgCd6Ogm6x3PNQ1H0dP4CX+UY0ja2Pi5fOuvSTmZPug4D629KVi 71bzDL3VyuUELX8svVXE/Zfo6xlynTNySoeCRjN54RzBMVekWqVozKNTjqz4oTKwcqFy OmZd9RHShbxZx1+BqRX/G295erhhamh7x4BHyoMQ9zg+rFo83pDbey3YtIyFK/ic21RG P1hw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=ap0iTyB1JweCvRw5nc5fEIcahopYpgoZY3SVRhcp7oU=; b=RtEPrrKs7bA7Gw71czrL1dx41fexIqFm6xVktmwH1VozqZMeuuZ3FEsCnTwx+laJut Wr6XBketQ+hmFFj6dmFj+F2GLfNLnnt1lM2mP67hcOAcEF1njzp0ZZYJhEnzYGtHEStr CrXNTqBkRAuwW1n7dI10WJA2ecuh8kMSI4uOFLFziEqJucKR1Xe+iJ16y/yUWR7nUOrs WqNCWkFJskWdME0n1m+68MAxiI9AT13ff0uDPV0aqsqxkXeQwKed0j30vDZAo9Ys0Thq M1qesasX8k4ceOBNkoj37275b55b0N72Xfoz/lhHyj8epe+JAOzriVhK1abF56A9JOcg nONA== X-Gm-Message-State: AHYfb5hDxcnJoZby6H4J94jvSdNwChBdwTlfadb8v+2FSVUqdhRGOIKc 9LnD9Odu6XI4qqAh8S+QyeEEYyVQIQwvRi0= X-Received: by 10.28.166.81 with SMTP id p78mr2299387wme.147.1502188169048; Tue, 08 Aug 2017 03:29:29 -0700 (PDT) MIME-Version: 1.0 Received: by 10.223.134.149 with HTTP; Tue, 8 Aug 2017 03:29:28 -0700 (PDT) In-Reply-To: <1502181568-12299-1-git-send-email-horms+renesas@verge.net.au> References: <1502181568-12299-1-git-send-email-horms+renesas@verge.net.au> From: Magnus Damm Date: Tue, 8 Aug 2017 19:29:28 +0900 Message-ID: Subject: Re: [PATCH 00/10] ARM, arm64: dts: renesas: Use R-Car GPIO Gen[123] fallback compat strings To: Simon Horman X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20170808_032952_597294_49A17752 X-CRM114-Status: GOOD ( 11.26 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Linux-Renesas , "linux-arm-kernel@lists.infradead.org" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP Hi Simon, On Tue, Aug 8, 2017 at 5:39 PM, Simon Horman wrote: > Use newly added R-Car GPIO Gen 1, 2 and 3 fallback compat strings in place > of now deprecated non-generation specific R-Car GPIO fallback compat string > in the DT of Renesas ARM and arm64 based SoCs. > > This should have no run-time effect as the driver matches against the > per-SoC compat string before considering the fallback compat string. Thanks for your efforts.I have no issue with your series (apart from the GPIO and SATA mistake), but at the same time I believe the GPIO hardware itself is backwards compatible between various generations. In the nitpick department I would like to point out that the level of hardware difference between say R-Car Gen1 GPIO and R-Car Gen2 GPIO is similar to say good old uarts like 8250 and 16450 hardware. Basically a couple of registers were added to the hardware in a backwards-compatible way if I recall correctly. So if we are going to use "compatible" to point out if hardware is compatible or not then I would do this instead: At the same time I'm not sure if I care _that_ much. =) Thanks, / magnus --- a/arch/arm64/boot/dts/renesas/r8a7796.dtsi +++ b/arch/arm64/boot/dts/renesas/r8a7796.dtsi @@ -214,7 +214,7 @@ gpio0: gpio@e6050000 { compatible = "renesas,gpio-r8a7796", + "renesas,rcar-gen3-gpio"; "renesas,gpio-rcar"; reg = <0 0xe6050000 0 0x50>; interrupts = ; #gpio-cells = <2>;