From patchwork Sat Oct 27 09:33:46 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Viresh Kumar X-Patchwork-Id: 1654741 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork2.kernel.org Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) by patchwork2.kernel.org (Postfix) with ESMTP id A249ADFAC4 for ; Sat, 27 Oct 2012 09:35:46 +0000 (UTC) Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.76 #1 (Red Hat Linux)) id 1TS2m9-0003FU-Pn; Sat, 27 Oct 2012 09:33:53 +0000 Received: from mail-vc0-f177.google.com ([209.85.220.177]) by merlin.infradead.org with esmtps (Exim 4.76 #1 (Red Hat Linux)) id 1TS2m4-0003FG-RP for linux-arm-kernel@lists.infradead.org; Sat, 27 Oct 2012 09:33:50 +0000 Received: by mail-vc0-f177.google.com with SMTP id p16so3771008vcq.36 for ; Sat, 27 Oct 2012 02:33:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type; bh=DCjcejgrGnXgF31YdsE0/VTbcuNZ6Pifz7ZzO+6YXDE=; b=YuXgjQODwFi/Pxwtjp3eA+bSbR7LMoP53QCPLcia+A9Y9EWdEL3r1hqP0XDiAu8VLB zMumXzVyBKKe6744cBoDYxN6Qh1AxFMyjBGE9fi57WeG+Ps8Vke9yfGqqOmIHijOLmCB dszsw05vVMxg5jcLbNIeXoNYIgGSYlNcT0MHDf4qoXNHClM5m23dgfWZFFRpGuhhbpoM 3LixNLobsWJJBYOO1966RdMBOYTjAJBIY6JiaE9BXjSnIZjAu5LcMgIMp+6GiQi6zPQ2 6sQoaDN+Rqp2TUdLiHRb0HsxUTaASBCuTwBa1hf1RHuYP601LOjPEhM3HeUbb8YNfHuF q55Q== MIME-Version: 1.0 Received: by 10.52.29.148 with SMTP id k20mr32597597vdh.37.1351330426288; Sat, 27 Oct 2012 02:33:46 -0700 (PDT) Received: by 10.220.190.132 with HTTP; Sat, 27 Oct 2012 02:33:46 -0700 (PDT) In-Reply-To: References: <1336562136-24498-1-git-send-email-viresh.kumar@st.com> <201205122142.02318.arnd@arndb.de> <4FB47DE2.4070704@st.com> Date: Sat, 27 Oct 2012 15:03:46 +0530 X-Google-Sender-Auth: biJzBSYbqZjgZbKjOsT8m_cw97Q Message-ID: Subject: Re: [GIT PULL] SPEAr pinctrl updates for v-3.5 From: viresh kumar To: Linus Walleij X-Spam-Note: CRM114 invocation failed X-Spam-Score: -2.6 (--) X-Spam-Report: SpamAssassin version 3.3.2 on merlin.infradead.org summary: Content analysis details: (-2.6 points) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (viresh.linux[at]gmail.com) -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low trust [209.85.220.177 listed in list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature Cc: Arnd Bergmann , spear-devel , Grant Likely , "arm@kernel.org" , Dong Aisheng , shiraz hashim , "linux-arm-kernel@lists.infradead.org" X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-arm-kernel-bounces@lists.infradead.org Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org Hi Linus, Sorry for replying on very old thread. Actually i wanted to give answer to some of your review comments you already gave. On Mon, Sep 3, 2012 at 5:18 PM, Linus Walleij wrote: > On Sat, Sep 1, 2012 at 1:22 PM, shiraz hashim > wrote: >> +2.1) gpio-controller and pinctrl subsystem >> +------------------------------------------ >> <...> >> + &pinctrl1 and &pinctrl2 is the phandle to the pinctrl DT node. >> + >> + Next values specify the base pin and number of pins for the range >> + handled by 'qe_pio_e' gpio. In the given example from base pin 20 to >> + pin 29 under pinctrl1 and pin 50 to pin 69 under pinctrl2 is handled >> + by this gpio controller. > Also, you should put a big "DEPRECATED" mark on the old gpio > range concept, and refer to the new way of doing things. I have added following on reply to this request: >> diff --git a/include/asm-generic/gpio.h b/include/asm-generic/gpio.h >> +#ifdef CONFIG_PINCTRL > > There's no need to #ifdef this I think. Actually there is, as definition of struct pinctrl_gpio_range is enclosed in this config option. >> +/** >> + * struct gpio_pin_range - pin range controlled by a gpio chip >> + * @head: list for maintaining set of pin ranges, used internally >> + * @pctldev: pinctrl device which handles corresponding pins >> + * @range: actual range of pins controlled by a gpio controller >> + */ >> + >> +struct gpio_pin_range { >> + struct list_head node; >> + struct pinctrl_dev *pctldev; >> + struct pinctrl_gpio_range range; >> +}; >> +#endif --- viresh diff --git a/Documentation/pinctrl.txt b/Documentation/pinctrl.txt index a1cd2f9..da40efb 100644 --- a/Documentation/pinctrl.txt +++ b/Documentation/pinctrl.txt @@ -364,6 +364,9 @@ will get an pin number into its handled number range. Further it is also passed the range ID value, so that the pin controller knows which range it should deal with. +Calling pinctrl_add_gpio_range from pinctrl driver is DEPRECATED. Please see +section 2.1 of Documentation/devicetree/bindings/gpio/gpio.txt on how to bind +pinctrl and gpio drivers.