From patchwork Wed Jun 1 19:57:52 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kevin Hilman X-Patchwork-Id: 9148091 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 6A49B60467 for ; Wed, 1 Jun 2016 19:59:42 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 57D8620410 for ; Wed, 1 Jun 2016 19:59:42 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 4C44526C9B; Wed, 1 Jun 2016 19:59:42 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAYES_00, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id C213C20410 for ; Wed, 1 Jun 2016 19:59:41 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1b8CHS-0000gm-VT; Wed, 01 Jun 2016 19:58:18 +0000 Received: from mail.kernel.org ([198.145.29.136]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1b8CHQ-0000f8-A5 for linux-arm-kernel@lists.infradead.org; Wed, 01 Jun 2016 19:58:16 +0000 Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 2CE0120303 for ; Wed, 1 Jun 2016 19:57:55 +0000 (UTC) Received: from mail-oi0-f46.google.com (mail-oi0-f46.google.com [209.85.218.46]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 5543320398 for ; Wed, 1 Jun 2016 19:57:53 +0000 (UTC) Received: by mail-oi0-f46.google.com with SMTP id k23so45074774oih.0 for ; Wed, 01 Jun 2016 12:57:53 -0700 (PDT) X-Gm-Message-State: ALyK8tJe2KHS+TpFLiJBHnp6Y7vaQnSL8eTS0vpv5vSjW18gOiIMuotVs7tQyfHfcHTNSW8v9Vhe6F9tTbWdsSjM MIME-Version: 1.0 X-Received: by 10.157.63.33 with SMTP id m30mr4334359otc.170.1464811072525; Wed, 01 Jun 2016 12:57:52 -0700 (PDT) Received: by 10.182.48.166 with HTTP; Wed, 1 Jun 2016 12:57:52 -0700 (PDT) In-Reply-To: <1464429273-23457-14-git-send-email-krzk@kernel.org> References: <1464429273-23457-1-git-send-email-krzk@kernel.org> <1464429273-23457-14-git-send-email-krzk@kernel.org> Date: Wed, 1 Jun 2016 12:57:52 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v5 13/22] ARM: dts: exynos: Enable UART3 on Exynos5410 From: Kevin Hilman To: Krzysztof Kozlowski X-Virus-Scanned: ClamAV using ClamSMTP X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20160601_125816_383413_F80A7B5D X-CRM114-Status: GOOD ( 15.49 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree , Krzysztof Kozlowski , linux-samsung-soc@vger.kernel.org, Michael Turquette , Stephen Boyd , Tomasz Figa , Rob Herring , lkml , Javier Martinez Canillas , Kukjin Kim , Sylwester Nawrocki , linux-clk@vger.kernel.org, linux-arm-kernel Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP Hi Krzysztof, On Sat, May 28, 2016 at 2:54 AM, Krzysztof Kozlowski wrote: > Just like other Exynos5 family SoCs, this one has four UARTs. Configure > clocks for UART3 and enable it. > > Signed-off-by: Krzysztof Kozlowski > Reviewed-by: Javier Martinez Canillas This patch landed in linux-next[1] and kernelci.org found a boot regression on the exynos5410-odroidxu[2], where it looks like it's faulting in clk_prepare(). Bisecting pointed to this patch. I added "status = disabled" back into the DTS on top of next-20160601[3] and verified my odroid-XU to be booting fine again. Kevin [1] 594127ada6df ARM: dts: exynos: Enable UART3 on Exynos5410 [2] https://kernelci.org/boot/exynos5410-odroidxu/job/next/kernel/next-20160601/defconfig/multi_v7_defconfig/lab/lab-baylibre-seattle/?_id=574e97c759b5140f4141c8ef [3] diff --git a/arch/arm/boot/dts/exynos5410.dtsi b/arch/arm/boot/dts/exynos5410.dtsi index a937d9bdad90..f4baf1d1e864 100644 --- a/arch/arm/boot/dts/exynos5410.dtsi +++ b/arch/arm/boot/dts/exynos5410.dtsi @@ -238,6 +238,7 @@ }; &serial_3 { + status = "disabled"; clocks = <&clock CLK_UART3>, <&clock CLK_SCLK_UART3>; clock-names = "uart", "clk_uart_baud0"; };