From patchwork Fri Sep 21 06:28:23 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wei Yongjun X-Patchwork-Id: 1489711 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork2.kernel.org Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) by patchwork2.kernel.org (Postfix) with ESMTP id D1574DF28C for ; Fri, 21 Sep 2012 06:30:43 +0000 (UTC) Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.76 #1 (Red Hat Linux)) id 1TEwjS-00029I-1O; Fri, 21 Sep 2012 06:28:58 +0000 Received: from mail-vb0-f49.google.com ([209.85.212.49]) by merlin.infradead.org with esmtps (Exim 4.76 #1 (Red Hat Linux)) id 1TEwjP-000289-AY for linux-arm-kernel@lists.infradead.org; Fri, 21 Sep 2012 06:28:55 +0000 Received: by vbbfo1 with SMTP id fo1so3543205vbb.36 for ; Thu, 20 Sep 2012 23:28:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:date:message-id:subject:from:to:cc:content-type; bh=iZxG/oKpFBedEVhswG9rcvyhq6ZHv0qjO1BvMSKfdiI=; b=j12PXU0Z1GF0WJ+7TPrrR/E56dt5ejukGD1tx1Rq6egFlwuNLZS/u+U+AU2sOAsFh7 pGK/wu5Z93+B5hE0GLO6tRrKDdXg23iZaUqVJSbbfA5AJftI3W8KE1a83lWKnMPrwljQ Plqmj5j0nUuLlbFrPkhgcq/6hfKuVX61rS7JeDYviNQls94cOMLjwiSu1MBs1DBRydRf QTOZC0H26ubw3NgMma9CY/vjKqeZumqTYN4ImOLoHmypMpnjrTyEkPXXGjPg59/FLg/6 pfMszAntgoz5wCuL6UkuwKdPGwrAKwldogBxxnsn4ljhpb0Qtmib2lmAI7YLURb0MQKd 6Q7g== MIME-Version: 1.0 Received: by 10.52.26.228 with SMTP id o4mr1302733vdg.72.1348208933563; Thu, 20 Sep 2012 23:28:53 -0700 (PDT) Received: by 10.229.146.194 with HTTP; Thu, 20 Sep 2012 23:28:23 -0700 (PDT) Date: Fri, 21 Sep 2012 14:28:23 +0800 Message-ID: Subject: [PATCH] OMAPDSS: fix return value check in create_dss_pdev() From: Wei Yongjun To: tony@atomide.com, linux@arm.linux.org.uk X-Spam-Note: CRM114 invocation failed X-Spam-Score: -2.7 (--) X-Spam-Report: SpamAssassin version 3.3.2 on merlin.infradead.org summary: Content analysis details: (-2.7 points) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (weiyj.lk[at]gmail.com) -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low trust [209.85.212.49 listed in list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature Cc: yongjun_wei@trendmicro.com.cn, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-arm-kernel-bounces@lists.infradead.org Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org From: Wei Yongjun In case of error, the function omap_device_alloc() returns ERR_PTR() not NULL pointer. The NULL test in the return value check should be replaced with IS_ERR(). dpatch engine is used to auto generated this patch. (https://github.com/weiyj/dpatch) Signed-off-by: Wei Yongjun --- arch/arm/mach-omap2/display.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/mach-omap2/display.c b/arch/arm/mach-omap2/display.c index af1ed7d..eb1bd01 100644 --- a/arch/arm/mach-omap2/display.c +++ b/arch/arm/mach-omap2/display.c @@ -221,7 +221,7 @@ static struct platform_device *create_dss_pdev(const char *pdev_name, ohs[0] = oh; od = omap_device_alloc(pdev, ohs, 1, NULL, 0); - if (!od) { + if (IS_ERR(od)) { pr_err("Could not alloc omap_device for %s\n", pdev_name); r = -ENOMEM; goto err;