From patchwork Fri Sep 21 07:19:09 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wei Yongjun X-Patchwork-Id: 1490171 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork2.kernel.org Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) by patchwork2.kernel.org (Postfix) with ESMTP id E1790DF28C for ; Fri, 21 Sep 2012 07:21:13 +0000 (UTC) Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.76 #1 (Red Hat Linux)) id 1TExW9-0002As-Tz; Fri, 21 Sep 2012 07:19:17 +0000 Received: from mail-qc0-f177.google.com ([209.85.216.177]) by merlin.infradead.org with esmtps (Exim 4.76 #1 (Red Hat Linux)) id 1TExW2-0002AS-SW; Fri, 21 Sep 2012 07:19:11 +0000 Received: by qcsu28 with SMTP id u28so2549730qcs.36 for ; Fri, 21 Sep 2012 00:19:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:date:message-id:subject:from:to:cc:content-type; bh=EafOZXMCiRWb+RBPycpL+ZyVuaRiwQ3H3KxrkprBnQk=; b=z8iIp9FfqefQSOuEfdgjv43JRoaCueNGkoUBQH+0rFX57uv/MziZ2390vJaf8wAiRW eFRwa+monPNlkxbAzoEJGBj527ymuFsTh8r/turWLCz1KKQsadeBIgcapcbOq589uoHX AiItYvi7FAn7+UqvUUqUIFjYMPhvfwghYLSBPRZY6c0lM56ltKIDNsJ6iM7oXzywGfLb fk5s6qhKqKLNCqFIZx45y1mh2znYRZXJ4rH19cyHf+iVMmndbQc6MGFhE9RD9ZorqFAW utAP9DWxouKw9UwjtfAzGEwhA542SBmmvrynKjLp3qCuQ5hPYJZTSTZu5XcAUpIuFIg5 /mag== MIME-Version: 1.0 Received: by 10.224.178.4 with SMTP id bk4mr10411363qab.38.1348211949593; Fri, 21 Sep 2012 00:19:09 -0700 (PDT) Received: by 10.229.146.194 with HTTP; Fri, 21 Sep 2012 00:19:09 -0700 (PDT) Date: Fri, 21 Sep 2012 15:19:09 +0800 Message-ID: Subject: [PATCH] ARM: pxa: fix return value check in pxa2xx_drv_pcmcia_probe() From: Wei Yongjun To: eric.y.miao@gmail.com, linux@arm.linux.org.uk, haojian.zhuang@gmail.com X-Spam-Note: CRM114 invocation failed X-Spam-Score: -2.7 (--) X-Spam-Report: SpamAssassin version 3.3.2 on merlin.infradead.org summary: Content analysis details: (-2.7 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low trust [209.85.216.177 listed in list.dnswl.org] 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (weiyj.lk[at]gmail.com) -0.0 SPF_PASS SPF: sender matches SPF record -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature Cc: yongjun_wei@trendmicro.com.cn, linux-pcmcia@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-arm-kernel-bounces@lists.infradead.org Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org From: Wei Yongjun In case of error, the function clk_get() returns ERR_PTR() and never returns NULL pointer. The NULL test in the error handling should be replaced with IS_ERR(). dpatch engine is used to auto generated this patch. (https://github.com/weiyj/dpatch) Signed-off-by: Wei Yongjun --- drivers/pcmcia/pxa2xx_base.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/pcmcia/pxa2xx_base.c b/drivers/pcmcia/pxa2xx_base.c index 490bb82..cfec9dd 100644 --- a/drivers/pcmcia/pxa2xx_base.c +++ b/drivers/pcmcia/pxa2xx_base.c @@ -297,7 +297,7 @@ static int pxa2xx_drv_pcmcia_probe(struct platform_device *dev) } clk = clk_get(&dev->dev, NULL); - if (!clk) + if (IS_ERR(clk)) return -ENODEV; pxa2xx_drv_pcmcia_ops(ops);