From patchwork Fri Sep 21 06:23:13 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wei Yongjun X-Patchwork-Id: 1489671 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork1.kernel.org Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) by patchwork1.kernel.org (Postfix) with ESMTP id AE1543FCFC for ; Fri, 21 Sep 2012 06:25:00 +0000 (UTC) Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.76 #1 (Red Hat Linux)) id 1TEwe1-0008LB-M9; Fri, 21 Sep 2012 06:23:21 +0000 Received: from mail-qa0-f42.google.com ([209.85.216.42]) by merlin.infradead.org with esmtps (Exim 4.76 #1 (Red Hat Linux)) id 1TEwdu-0008Iq-Hg for linux-arm-kernel@lists.infradead.org; Fri, 21 Sep 2012 06:23:15 +0000 Received: by qaeb19 with SMTP id b19so992133qae.15 for ; Thu, 20 Sep 2012 23:23:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:date:message-id:subject:from:to:cc:content-type; bh=R7Rz9q+Ep/+1yfElZgRdhH8js4r12tKrFdc4JqBx/y0=; b=heQtzI0r1WOgQhBtd82UYiUPx9RRjmgi4mtWcvLYNo4YJSq9KGDtJ3FoJmFWaMAt9n JnwjavMMFVDjyd4yEeJswtgcr0IwwWhIn+P52YGnOpG0tYJhbrfZsaiSfY2xJW6ya0yW lr7fSZRPN4UBqNB5D3Eb+Tjom8TT7DZF7a4fnSEksR9YACiSuBTbhFqJ7xNW14gwJXUW DEDpGELQfzV/FYKUECRwPXdw03iBiTYLiu2NoncSA+0HZMzKq0MDSN7ZqKbwFh/kECF5 RPojizxaTo+5tYVjiQDsNC+WEHsjzaRjiW1A/hW5p8AOuoyoh9s5hQFl+/uWWZkSkr5a QjTA== MIME-Version: 1.0 Received: by 10.224.189.20 with SMTP id dc20mr10053982qab.91.1348208593316; Thu, 20 Sep 2012 23:23:13 -0700 (PDT) Received: by 10.229.146.194 with HTTP; Thu, 20 Sep 2012 23:23:13 -0700 (PDT) Date: Fri, 21 Sep 2012 14:23:13 +0800 Message-ID: Subject: [PATCH] msm: clock: fix return value check in msm_clock_init() From: Wei Yongjun To: davidb@codeaurora.org, dwalker@fifo99.com, bryanh@codeaurora.org, linux@arm.linux.org.uk X-Spam-Note: CRM114 invocation failed X-Spam-Score: -2.7 (--) X-Spam-Report: SpamAssassin version 3.3.2 on merlin.infradead.org summary: Content analysis details: (-2.7 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low trust [209.85.216.42 listed in list.dnswl.org] 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (weiyj.lk[at]gmail.com) -0.0 SPF_PASS SPF: sender matches SPF record -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature Cc: linux-arm-msm@vger.kernel.org, yongjun_wei@trendmicro.com.cn, linux-arm-kernel@lists.infradead.org X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-arm-kernel-bounces@lists.infradead.org Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org From: Wei Yongjun In case of error, the function clk_get() returns ERR_PTR() not NULL pointer. The NULL test in return value check should be replaced with IS_ERR(). dpatch engine is used to auto generated this patch. (https://github.com/weiyj/dpatch) Signed-off-by: Wei Yongjun --- arch/arm/mach-msm/clock.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/mach-msm/clock.c b/arch/arm/mach-msm/clock.c index d9145df..fd52891 100644 --- a/arch/arm/mach-msm/clock.c +++ b/arch/arm/mach-msm/clock.c @@ -148,7 +148,7 @@ void __init msm_clock_init(struct clk_lookup *clock_tbl, unsigned num_clocks) mutex_unlock(&clocks_mutex); ebi1_clk = clk_get(NULL, "ebi1_clk"); - BUG_ON(ebi1_clk == NULL); + BUG_ON(IS_ERR(ebi1_clk)); }