From patchwork Mon Mar 11 14:23:45 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wei Yongjun X-Patchwork-Id: 2249071 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork1.kernel.org Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) by patchwork1.kernel.org (Postfix) with ESMTP id 93EDA3FCF6 for ; Mon, 11 Mar 2013 14:27:06 +0000 (UTC) Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1UF3dp-0006yS-HA; Mon, 11 Mar 2013 14:23:53 +0000 Received: from mail-bk0-x22b.google.com ([2a00:1450:4008:c01::22b]) by merlin.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1UF3dk-0006y7-8e for linux-arm-kernel@lists.infradead.org; Mon, 11 Mar 2013 14:23:49 +0000 Received: by mail-bk0-f43.google.com with SMTP id jm19so1715539bkc.2 for ; Mon, 11 Mar 2013 07:23:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:x-received:date:message-id:subject:from:to:cc :content-type; bh=147yEvgNjT0JlihenOk8WmKmrLB12bsxnxVM2TMZnUk=; b=oPp+Fv3ubgZ3Kh1Sxxc4oyaaBCkA8aWn4HpvIcQl0Rcl4fED7STW498zlkfBhWnpR9 lJM52mY/ZMCOdVKebwvuNvO9DRw1DrVgL2Ow9q24/yQIbgaLD3BjYaCuJFXyzCJ0scVi bvOwFOZvr3DJdsr5k1BssKJQZsrrQMQ6pHKAMPOa+Rdt/iAAKtgJ4O/8LPN2KTzeobIm OUxcOnOVjg9OpIliH2CqiBWnY8Fya04jxbe84GVEn152ndCi5EvDzNQEMuRl/kUcggBv FOVtOTWfqptoc5RSmnf3TFJlfDApUEMgMblZ2JUmTYTDxMFUN29gdftKOIRJx4gNiry6 zMmA== MIME-Version: 1.0 X-Received: by 10.205.133.1 with SMTP id hw1mr4698306bkc.58.1363011825114; Mon, 11 Mar 2013 07:23:45 -0700 (PDT) Received: by 10.204.30.210 with HTTP; Mon, 11 Mar 2013 07:23:45 -0700 (PDT) Date: Mon, 11 Mar 2013 22:23:45 +0800 Message-ID: Subject: [PATCH -next] pinctrl: sirf: using for_each_set_bit to simplify the code From: Wei Yongjun To: baohua.song@csr.com, linus.walleij@linaro.org, grant.likely@secretlab.ca, rob.herring@calxeda.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20130311_102348_571996_59C4826F X-CRM114-Status: UNSURE ( 9.76 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -2.0 (--) X-Spam-Report: SpamAssassin version 3.3.2 on merlin.infradead.org summary: Content analysis details: (-2.0 points) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (weiyj.lk[at]gmail.com) -0.0 SPF_PASS SPF: sender matches SPF record -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature Cc: yongjun_wei@trendmicro.com.cn, devicetree-discuss@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org From: Wei Yongjun Using for_each_set_bit() to simplify the code. Signed-off-by: Wei Yongjun --- drivers/pinctrl/pinctrl-sirf.c | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/drivers/pinctrl/pinctrl-sirf.c b/drivers/pinctrl/pinctrl-sirf.c index 498b2ba..d6cf500 100644 --- a/drivers/pinctrl/pinctrl-sirf.c +++ b/drivers/pinctrl/pinctrl-sirf.c @@ -1669,15 +1669,12 @@ static void sirfsoc_gpio_set_pullup(const u32 *pullups) const unsigned long *p = (const unsigned long *)pullups; for (i = 0; i < SIRFSOC_GPIO_NO_OF_BANKS; i++) { - n = find_first_bit(p + i, BITS_PER_LONG); - while (n < BITS_PER_LONG) { + for_each_set_bit(n, p + i, BITS_PER_LONG) { u32 offset = SIRFSOC_GPIO_CTRL(i, n); u32 val = readl(sgpio_bank[i].chip.regs + offset); val |= SIRFSOC_GPIO_CTL_PULL_MASK; val |= SIRFSOC_GPIO_CTL_PULL_HIGH; writel(val, sgpio_bank[i].chip.regs + offset); - - n = find_next_bit(p + i, BITS_PER_LONG, n + 1); } } } @@ -1688,15 +1685,12 @@ static void sirfsoc_gpio_set_pulldown(const u32 *pulldowns) const unsigned long *p = (const unsigned long *)pulldowns; for (i = 0; i < SIRFSOC_GPIO_NO_OF_BANKS; i++) { - n = find_first_bit(p + i, BITS_PER_LONG); - while (n < BITS_PER_LONG) { + for_each_set_bit(n, p + i, BITS_PER_LONG) { u32 offset = SIRFSOC_GPIO_CTRL(i, n); u32 val = readl(sgpio_bank[i].chip.regs + offset); val |= SIRFSOC_GPIO_CTL_PULL_MASK; val &= ~SIRFSOC_GPIO_CTL_PULL_HIGH; writel(val, sgpio_bank[i].chip.regs + offset); - - n = find_next_bit(p + i, BITS_PER_LONG, n + 1); } } }