From patchwork Sun Dec 2 10:10:44 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wei Yongjun X-Patchwork-Id: 1830221 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork1.kernel.org Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) by patchwork1.kernel.org (Postfix) with ESMTP id 525403FCA5 for ; Sun, 2 Dec 2012 10:15:02 +0000 (UTC) Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.76 #1 (Red Hat Linux)) id 1Tf6Vh-0007uJ-9J; Sun, 02 Dec 2012 10:10:53 +0000 Received: from mail-qa0-f42.google.com ([209.85.216.42]) by merlin.infradead.org with esmtps (Exim 4.76 #1 (Red Hat Linux)) id 1Tf6Vb-0007u0-OU for linux-arm-kernel@lists.infradead.org; Sun, 02 Dec 2012 10:10:50 +0000 Received: by mail-qa0-f42.google.com with SMTP id hg5so666747qab.15 for ; Sun, 02 Dec 2012 02:10:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:date:message-id:subject:from:to:cc:content-type; bh=uv/ggTVn12WJOnhZu2jV9DRD1cWEjpy4Gf7lLIp1TeM=; b=lzUCXMGxLPKv/cWaxQt+YUQUE7+mtTR39iPMAFr3kWRLgUeDD6elNeyBmuXYhrOudg h8jylE53JxqfLIL5D09Wh19J9c63ujEkDXnK7Se4f31nBI4eOu4XFxo7u6kmb6KdpPhJ b5BmoMuCRdOWTgZcWfStUS2WkM6dm2DbQI9049rtbdKoID/ZE9nTjW7qnd4QtEjh5su2 ciKXmlDoBo0oqdYjAhgYJ+AOogIL+UIFdk5L2N+ZCD06zoERygxlgquyp/o5lcODJVwZ gwd3IT21VMNlA/4YjKhm32QAV00b29OjHRHSSIRvnrp5QcE+oHc1YsR0r/j33kCr07xc KcYg== MIME-Version: 1.0 Received: by 10.49.3.227 with SMTP id f3mr12478085qef.60.1354443044817; Sun, 02 Dec 2012 02:10:44 -0800 (PST) Received: by 10.229.126.165 with HTTP; Sun, 2 Dec 2012 02:10:44 -0800 (PST) Date: Sun, 2 Dec 2012 05:10:44 -0500 Message-ID: Subject: [PATCH] tty: serial: vt8500: fix return value check in vt8500_serial_probe() From: Wei Yongjun To: linux@prisktech.co.nz, alan@linux.intel.com, gregkh@linuxfoundation.org, grant.likely@secretlab.ca, rob.herring@calxeda.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20121202_051047_892414_AFC68AF9 X-CRM114-Status: GOOD ( 11.03 ) X-Spam-Score: -2.7 (--) X-Spam-Report: SpamAssassin version 3.3.2 on merlin.infradead.org summary: Content analysis details: (-2.7 points) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (weiyj.lk[at]gmail.com) -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low trust [209.85.216.42 listed in list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature Cc: devicetree-discuss@lists.ozlabs.org, yongjun_wei@trendmicro.com.cn, linux-serial@vger.kernel.org, linux-arm-kernel@lists.infradead.org X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-arm-kernel-bounces@lists.infradead.org Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org From: Wei Yongjun In case of error, function of_clk_get() returns ERR_PTR() and never returns NULL. The NULL test in the return value check should be replaced with IS_ERR(). Signed-off-by: Wei Yongjun Acked-by: Tony Prisk --- drivers/tty/serial/vt8500_serial.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/tty/serial/vt8500_serial.c b/drivers/tty/serial/vt8500_serial.c index 205d4cf..f528cc2 100644 --- a/drivers/tty/serial/vt8500_serial.c +++ b/drivers/tty/serial/vt8500_serial.c @@ -604,7 +604,7 @@ static int __devinit vt8500_serial_probe(struct platform_device *pdev) vt8500_port->uart.flags = UPF_IOREMAP | UPF_BOOT_AUTOCONF; vt8500_port->clk = of_clk_get(pdev->dev.of_node, 0); - if (vt8500_port->clk) { + if (!IS_ERR(vt8500_port->clk)) { vt8500_port->uart.uartclk = clk_get_rate(vt8500_port->clk); } else { /* use the default of 24Mhz if not specified and warn */