From patchwork Mon Jun 10 14:40:54 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Russell King (Oracle)" X-Patchwork-Id: 13692147 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 96A98C27C55 for ; Mon, 10 Jun 2024 14:41:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Date:Message-Id:MIME-Version:Subject:Cc :To:From:References:In-Reply-To:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=fa+SOreIt3eUw2DPkDlh2ZKbChPbj7t4XWKFcvbvdI8=; b=hPRKdFKnwz5GjQ Hx6Jwu0cEhrM4cd4SC39TLzI8OIQfB3DhpGeed1Q4WrSLcUsOau6/9LW2J+NvaJjA/Xk9xw239T/K 8fUI8BuA1jerCe6WaXTzJluj3ym37cZvtI8ke/aJKmREY9Mujm3tnGqjgwu1Yi/IKatIm9HHwLec9 /aBGHZxNfEaiGmr2ixwLMQbzgSCwPj0qRWGOVkO93sR0b049PWs58VW1KtoDBuONQGuUL0YgJk5ui YPuEC9JDZRmMY2tOJTN1rsW4BRHbmqno3HW3i0E3FViOiPzopLclu/U4eDfxou5oKVW/QkztBESv/ J1UIz1wPzLT7tpC5Nqmw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sGgCr-00000005SYq-2NEE; Mon, 10 Jun 2024 14:41:09 +0000 Received: from pandora.armlinux.org.uk ([2001:4d48:ad52:32c8:5054:ff:fe00:142]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sGgCn-00000005SUy-16o7 for linux-arm-kernel@lists.infradead.org; Mon, 10 Jun 2024 14:41:07 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Date:Sender:Message-Id:Content-Type: Content-Transfer-Encoding:MIME-Version:Subject:Cc:To:From:References: In-Reply-To:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=BWNZHsS70/QjgSQEoGOeY4EqJuojEQ3o1GbogG6YuSM=; b=aFN9Dtt71SZcljf3N6tl77BQXr 5sRXskmGKkIPtETe02zygZfaCwL5RNVzhxIL/vnFm6JeKk9NaCe2f6NFLzJlH4qcuSJ0ha/xXccJz MyIEWYxSal5mus0jCNVUCd7dlCeb/Fspo3rgmm9yduKawktSUvILnN3f2Z4k/2IH0rWStU5XNf8dF OErEWPBE7IPY3eRaRARJT5MMC4Luxgvijyf1+6UCGMhiLa3L1teatgKng9f8jUhpHqZt0i6MxvIok yP81vLZ2DIDH2HqDIczo89TPQK+ALLHUqEv+jZIop+jOJkSDnVSEiV75jIS2iVGX51dP/KuEQRvUe 7I10C7BQ==; Received: from e0022681537dd.dyn.armlinux.org.uk ([fd8f:7570:feb6:1:222:68ff:fe15:37dd]:38386 helo=rmk-PC.armlinux.org.uk) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1sGgCZ-0001ft-2B; Mon, 10 Jun 2024 15:40:51 +0100 Received: from rmk by rmk-PC.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1sGgCc-00FadB-Ch; Mon, 10 Jun 2024 15:40:54 +0100 In-Reply-To: References: From: "Russell King (Oracle)" To: Serge Semin Cc: Alexandre Torgue , Andrew Halaney , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Jose Abreu , linux-arm-kernel@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, Maxime Coquelin , netdev@vger.kernel.org, Paolo Abeni , Romain Gantois Subject: [PATCH net-next 5/5] net: stmmac: clean up stmmac_mac_select_pcs() MIME-Version: 1.0 Content-Disposition: inline Message-Id: Date: Mon, 10 Jun 2024 15:40:54 +0100 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240610_074105_467518_B0E5FB35 X-CRM114-Status: GOOD ( 10.68 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Since all platform providers of PCS now populate the select_pcs() method, there is no need for the common code to look at priv->hw->phylink_pcs, so remove it. Signed-off-by: Russell King (Oracle) Reviewed-by: Romain Gantois --- drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c index e9e2a95c91a3..5ddbb0d44373 100644 --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c @@ -957,7 +957,7 @@ static struct phylink_pcs *stmmac_mac_select_pcs(struct phylink_config *config, return pcs; } - return priv->hw->phylink_pcs; + return NULL; } static void stmmac_mac_config(struct phylink_config *config, unsigned int mode,