From patchwork Mon Feb 8 15:55:35 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gabriele Paoloni X-Patchwork-Id: 8251591 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 4836ABEEE5 for ; Mon, 8 Feb 2016 15:57:57 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 6193C201EC for ; Mon, 8 Feb 2016 15:57:56 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6C06F200ED for ; Mon, 8 Feb 2016 15:57:55 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1aSoAr-0005K3-Ud; Mon, 08 Feb 2016 15:56:25 +0000 Received: from lhrrgout.huawei.com ([194.213.3.17]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1aSoAm-0004zg-IE for linux-arm-kernel@lists.infradead.org; Mon, 08 Feb 2016 15:56:22 +0000 Received: from 172.18.7.190 (EHLO lhreml405-hub.china.huawei.com) ([172.18.7.190]) by lhrrg01-dlp.huawei.com (MOS 4.3.7-GA FastPath queued) with ESMTP id CIF71835; Mon, 08 Feb 2016 15:55:45 +0000 (GMT) Received: from LHREML701-CAH.china.huawei.com (10.201.5.93) by lhreml405-hub.china.huawei.com (10.201.5.242) with Microsoft SMTP Server (TLS) id 14.3.235.1; Mon, 8 Feb 2016 15:55:43 +0000 Received: from LHREML503-MBS.china.huawei.com ([10.125.30.104]) by lhreml701-cah.china.huawei.com ([10.201.5.93]) with mapi id 14.03.0235.001; Mon, 8 Feb 2016 15:55:35 +0000 From: Gabriele Paoloni To: Arnd Bergmann , "linux-arm-kernel@lists.infradead.org" Subject: RE: [RFC PATCH v2 2/3] PCI: hisi: Make the HiSilicon PCIe host controller ECAM compliant Thread-Topic: [RFC PATCH v2 2/3] PCI: hisi: Make the HiSilicon PCIe host controller ECAM compliant Thread-Index: AQHRYm40nte+rVZ6C0Oa+U3K6CZh2J8iKd4AgAAgzXA= Date: Mon, 8 Feb 2016 15:55:35 +0000 Message-ID: References: <1454935264-6076-1-git-send-email-gabriele.paoloni@huawei.com> <1454935264-6076-3-git-send-email-gabriele.paoloni@huawei.com> <3532826.pJr5R5Xa4c@wuerfel> In-Reply-To: <3532826.pJr5R5Xa4c@wuerfel> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.203.181.156] MIME-Version: 1.0 X-CFilter-Loop: Reflected X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A020203.56B8BA84.01A3, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0, ip=0.0.0.0, so=2013-06-18 04:22:30, dmn=2013-03-21 17:37:32 X-Mirapoint-Loop-Id: 024bedb167fdc08bb3b2745e42850deb X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20160208_075620_945416_BFD32F57 X-CRM114-Status: GOOD ( 19.08 ) X-Spam-Score: -4.5 (----) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "Lorenzo.Pieralisi@arm.com" , "tn@semihalf.com" , "linux-pci@vger.kernel.org" , Linuxarm , "xuwei \(O\)" , "linux-kernel@vger.kernel.org" , "linux-acpi@vger.kernel.org" , "Wangzhou \(B\)" , "liudongdong \(C\)" , "Guohanjun \(Hanjun Guo\)" , "bhelgaas@google.com" , zhangjukuo , "Liguozhu \(Kenneth\)" , qiujiang , "jcm@redhat.com" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-4.5 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP > -----Original Message----- > From: Arnd Bergmann [mailto:arnd@arndb.de] > Sent: 08 February 2016 13:48 > To: linux-arm-kernel@lists.infradead.org > Cc: Gabriele Paoloni; Guohanjun (Hanjun Guo); Wangzhou (B); liudongdong > (C); Linuxarm; qiujiang; bhelgaas@google.com; > Lorenzo.Pieralisi@arm.com; tn@semihalf.com; linux-pci@vger.kernel.org; > linux-kernel@vger.kernel.org; xuwei (O); linux-acpi@vger.kernel.org; > jcm@redhat.com; zhangjukuo; Liguozhu (Kenneth) > Subject: Re: [RFC PATCH v2 2/3] PCI: hisi: Make the HiSilicon PCIe host > controller ECAM compliant > > On Monday 08 February 2016 12:41:03 Gabriele Paoloni wrote: > > From: gabriele paoloni > > > > This patch modifies the current Hip05/Hip06 PCIe host controller > > driver to make it ECAM compliant. This is needed in preparation > > for the ACPI based driver to allow both DT and ACPI drivers to > > use the same BIOS (that configure the Designware iATUs). > > > > Signed-off-by: Gabriele Paoloni > > Signed-off-by: Dongdong Liu > > > > Doesn't this break backwards compatibility? Well Hip05/Hip06 SoCs are used into evaluation boards For the Estuary project. https://github.com/hisilicon/estuary As this new driver gets upstream we'll merge this new driver into estuary and release a new version of the firmware to support it. > > I think you need to use a new compatible string in the firmware > if you change the register layout, and then change the driver > to support both the old and the new layout. You are right, for some reason in this patchset I missed the Documentation update that I posted in the previous one, i.e.: Thanks Gab > > Arnd --- a/Documentation/devicetree/bindings/pci/hisilicon-pcie.txt +++ b/Documentation/devicetree/bindings/pci/hisilicon-pcie.txt @@ -23,8 +23,8 @@ Optional properties: Hip05 Example (note that Hip06 is the same except compatible): pcie@0xb0080000 { compatible = "hisilicon,hip05-pcie", "snps,dw-pcie"; - reg = <0 0xb0080000 0 0x10000>, <0x220 0x00000000 0 0x2000>; - reg-names = "rc_dbi", "config"; + reg = <0 0xb0080000 0 0x10000>, <0x220 0x00100000 0 0x0f00000>; + reg-names = "rc_dbi", "ecam-cfg"; I will fix this in v3