From patchwork Fri May 17 12:26:48 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Guennadi Liakhovetski X-Patchwork-Id: 2582551 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork2.kernel.org Received: from casper.infradead.org (casper.infradead.org [85.118.1.10]) by patchwork2.kernel.org (Postfix) with ESMTP id 2A1FCDF215 for ; Fri, 17 May 2013 12:28:47 +0000 (UTC) Received: from merlin.infradead.org ([2001:4978:20e::2]) by casper.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1UdJlT-0000Hw-1C; Fri, 17 May 2013 12:28:04 +0000 Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1UdJkq-0004So-AZ; Fri, 17 May 2013 12:27:24 +0000 Received: from moutng.kundenserver.de ([212.227.126.171]) by merlin.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1UdJkn-0004SM-Je for linux-arm-kernel@lists.infradead.org; Fri, 17 May 2013 12:27:22 +0000 Received: from axis700.grange (dslb-088-076-018-110.pools.arcor-ip.net [88.76.18.110]) by mrelayeu.kundenserver.de (node=mreu0) with ESMTP (Nemesis) id 0MTc9s-1V3kb30Jfc-00QZun; Fri, 17 May 2013 14:26:49 +0200 Received: by axis700.grange (Postfix, from userid 1000) id B940440BB4; Fri, 17 May 2013 14:26:48 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by axis700.grange (Postfix) with ESMTP id B64B040BB3; Fri, 17 May 2013 14:26:48 +0200 (CEST) Date: Fri, 17 May 2013 14:26:48 +0200 (CEST) From: Guennadi Liakhovetski X-X-Sender: lyakh@axis700.grange To: Laurent Pinchart Subject: Re: [PATCH v3 09/20] ARM: shmobile: r8a7790: Add GPIO controller devices to device tree In-Reply-To: <1368577100-3530-10-git-send-email-laurent.pinchart+renesas@ideasonboard.com> Message-ID: References: <1368577100-3530-1-git-send-email-laurent.pinchart+renesas@ideasonboard.com> <1368577100-3530-10-git-send-email-laurent.pinchart+renesas@ideasonboard.com> MIME-Version: 1.0 X-Provags-ID: V02:K0:w9pMiHjb0FwobGK05b8ulHwI8X3KzAAmPNoi8QHtD3j aXw8yQknfiymrIMRRQGEa6Ra7t4ncVa5XdkRe+f5gX4vENCVMB SV6L3e8n6DneOM5lS+QWpMGiuHd+QKwz+R+TMSNxBTzMZHXxSa 9WCVGDE+ab+KCiAWpE40b7IlBvHqnWY1Pzgaonklcx+iNnoCzx EfBYqjkFuXnYW1ZTuk2m1n5x/vFHMna3DxcCXik0/BevPVI3Im xUH8RuV8G6GFQwC0pJJEWK4+co1Wc7uOck/1nxzGc7htj1Kvfk +YRUYyjmeCNtnMoOzJ9+Ny08vN7Jeuxo3vDyI5+iPy2G1bPAQH xM2Yzsufzv+bXllXxVMdiYciGZOjtX7Xyuh2fHvE/9GPhPwlUS gsf5B0BL9Fv5A== X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20130517_082721_875824_8EB9A409 X-CRM114-Status: UNSURE ( 9.27 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -2.5 (--) X-Spam-Report: SpamAssassin version 3.3.2 on merlin.infradead.org summary: Content analysis details: (-2.5 points) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (g.liakhovetski[at]gmx.de) -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no trust [212.227.126.171 listed in list.dnswl.org] -0.0 SPF_HELO_PASS SPF: HELO matches SPF record -0.0 SPF_PASS SPF: sender matches SPF record -0.6 RP_MATCHES_RCVD Envelope sender domain matches handover relay domain -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] Cc: devicetree-discuss@lists.ozlabs.org, Magnus Damm , Linus Walleij , linux-arm-kernel@lists.infradead.org, linux-sh@vger.kernel.org X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org Hi Laurent On Wed, 15 May 2013, Laurent Pinchart wrote: > Add GPIO controller nodes to the r8a7790 core device tree. > > Signed-off-by: Laurent Pinchart > --- > arch/arm/boot/dts/r8a7790.dtsi | 54 ++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 54 insertions(+) Also here a couple of things are missing (presumably, for other SoCs you need the same): Thanks Guennadi --- Guennadi Liakhovetski, Ph.D. Freelance Open-Source Software Developer http://www.open-technology.de/ diff --git a/arch/arm/boot/dts/r8a7790.dtsi b/arch/arm/boot/dts/r8a7790.dtsi index 674ee39..cd1a04f 100644 --- a/arch/arm/boot/dts/r8a7790.dtsi +++ b/arch/arm/boot/dts/r8a7790.dtsi @@ -51,6 +51,7 @@ interrupts = <0 4 0x4>; #gpio-cells = <2>; gpio-controller; + gpio-ranges = <&pfc 0 0 32>; }; gpio1: gpio@ffc41000 { @@ -60,6 +61,7 @@ interrupts = <0 5 0x4>; #gpio-cells = <2>; gpio-controller; + gpio-ranges = <&pfc 0 32 32>; }; gpio2: gpio@ffc42000 { @@ -69,6 +71,7 @@ interrupts = <0 6 0x4>; #gpio-cells = <2>; gpio-controller; + gpio-ranges = <&pfc 0 64 32>; }; gpio3: gpio@ffc43000 { @@ -78,6 +81,7 @@ interrupts = <0 7 0x4>; #gpio-cells = <2>; gpio-controller; + gpio-ranges = <&pfc 0 96 32>; }; gpio4: gpio@ffc44000 { @@ -87,6 +91,7 @@ interrupts = <0 8 0x4>; #gpio-cells = <2>; gpio-controller; + gpio-ranges = <&pfc 0 128 32>; }; gpio5: gpio@ffc45000 { @@ -96,6 +101,7 @@ interrupts = <0 9 0x4>; #gpio-cells = <2>; gpio-controller; + gpio-ranges = <&pfc 0 160 32>; }; timer { @@ -118,6 +124,7 @@ pfc: pfc@e6060000 { compatible = "renesas,pfc-r8a7790"; reg = <0 0xe6060000 0 0x250>; + #gpio-range-cells = <3>; }; /* No MMC_CAP_UHS_DDR50 (dual data rate) capability on r8a7790! */