From patchwork Fri May 17 13:00:23 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Guennadi Liakhovetski X-Patchwork-Id: 2582691 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork2.kernel.org Received: from casper.infradead.org (casper.infradead.org [85.118.1.10]) by patchwork2.kernel.org (Postfix) with ESMTP id 6F760DF215 for ; Fri, 17 May 2013 13:01:48 +0000 (UTC) Received: from merlin.infradead.org ([2001:4978:20e::2]) by casper.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1UdKI1-0000jg-U1; Fri, 17 May 2013 13:01:42 +0000 Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1UdKHy-000588-QI; Fri, 17 May 2013 13:01:38 +0000 Received: from moutng.kundenserver.de ([212.227.17.10]) by merlin.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1UdKHu-00057W-Nr for linux-arm-kernel@lists.infradead.org; Fri, 17 May 2013 13:01:35 +0000 Received: from axis700.grange (dslb-088-076-018-110.pools.arcor-ip.net [88.76.18.110]) by mrelayeu.kundenserver.de (node=mrbap0) with ESMTP (Nemesis) id 0LxMeg-1URxU53lko-016zyN; Fri, 17 May 2013 15:00:24 +0200 Received: by axis700.grange (Postfix, from userid 1000) id 6309C40BB4; Fri, 17 May 2013 15:00:23 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by axis700.grange (Postfix) with ESMTP id 566DA40BB3; Fri, 17 May 2013 15:00:23 +0200 (CEST) Date: Fri, 17 May 2013 15:00:23 +0200 (CEST) From: Guennadi Liakhovetski X-X-Sender: lyakh@axis700.grange To: Simon Horman Subject: Re: [PATCH 05/11] ARM: shmobile: APE6EVM LAN9220 support In-Reply-To: <1364954906-16014-6-git-send-email-horms+renesas@verge.net.au> Message-ID: References: <1364954906-16014-1-git-send-email-horms+renesas@verge.net.au> <1364954906-16014-6-git-send-email-horms+renesas@verge.net.au> MIME-Version: 1.0 X-Provags-ID: V02:K0:MCEQK/lu7jmClMRcXxp9kmyieOrOoaYjBQniTH7xv6N OtRbGidTNHJF+dDQENC13GiNgD7XKloWNK1lkV3911n22+t9/R Dxa4XamskeJNpDa1qem/sqDhJMa+RWQ1wZ4HTqS+cD5UwaKIj8 d0f9DQF8mhFuOisnY77YxBWSvRrCOEtzAriV9X+TQRVGs+BgwF gwhJRzYUF2zCytD/Zu21f4ibzpzRhev59XrekbCz7XF33f4an+ LcLx3btRHe6daJ1Ppdl2jBvionhu0K9IQsJLo3GgUqLHQXRrwV slvv31G7oT6qdkGIwgQgLq1SbtC5IlhDDNW95pQrWqTmW6ywQm XVgh0f+sFbdo61PuwSQEmZFGWxNHkRrOOITvIZzt7dzRQzYFKz uifqbzKzJdA3w== X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20130517_090135_037575_886D374D X-CRM114-Status: GOOD ( 15.20 ) X-Spam-Score: -2.5 (--) X-Spam-Report: SpamAssassin version 3.3.2 on merlin.infradead.org summary: Content analysis details: (-2.5 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no trust [212.227.17.10 listed in list.dnswl.org] 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (g.liakhovetski[at]gmx.de) -0.0 SPF_HELO_PASS SPF: HELO matches SPF record -0.0 SPF_PASS SPF: sender matches SPF record -0.6 RP_MATCHES_RCVD Envelope sender domain matches handover relay domain -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] Cc: arm@kernel.org, Arnd Bergmann , linux-sh@vger.kernel.org, Magnus Damm , Magnus Damm , Paul Mundt , Olof Johansson , linux-arm-kernel@lists.infradead.org X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org Hi Simon, Magnus On Wed, 3 Apr 2013, Simon Horman wrote: > From: Magnus Damm > > Add LAN9220 support to the APE6EVM board using C and DT. > At this point the PFC driver lacks DT bindings so to > configure the PFC we use PINCTRL in C board code. > > Signed-off-by: Magnus Damm > Signed-off-by: Simon Horman > --- > arch/arm/boot/dts/r8a73a4-ape6evm.dts | 23 ++++++++++++++++++- > arch/arm/mach-shmobile/board-ape6evm.c | 38 ++++++++++++++++++++++++++++++++ > 2 files changed, 60 insertions(+), 1 deletion(-) > > diff --git a/arch/arm/boot/dts/r8a73a4-ape6evm.dts b/arch/arm/boot/dts/r8a73a4-ape6evm.dts > index 833f703..f603c69 100644 > --- a/arch/arm/boot/dts/r8a73a4-ape6evm.dts > +++ b/arch/arm/boot/dts/r8a73a4-ape6evm.dts > @@ -16,7 +16,7 @@ > compatible = "renesas,ape6evm", "renesas,r8a73a4"; > > chosen { > - bootargs = "console=ttySC0,115200 ignore_loglevel"; > + bootargs = "console=ttySC0,115200 ignore_loglevel root=/dev/nfs ip=dhcp"; > }; > > memory@40000000 { > @@ -24,8 +24,29 @@ > reg = <0 0x40000000 0 0x40000000>; > }; > > + ape6evm_fixed_3v3: fixedregulator@0 { > + compatible = "regulator-fixed"; > + regulator-name = "3V3"; > + regulator-min-microvolt = <3300000>; > + regulator-max-microvolt = <3300000>; > + regulator-always-on; > + }; > + > lbsc { > #address-cells = <1>; > #size-cells = <1>; > + > + ethernet@8000000 { > + compatible = "smsc,lan9118", "smsc,lan9115"; > + reg = <0x08000000 0x1000>; > + interrupt-parent = <&irqc1>; > + interrupts = <8 0x4>; > + phy-mode = "mii"; > + reg-io-width = <4>; > + smsc,irq-active-high; > + smsc,irq-push-pull; > + vdd33a-supply = <&ape6evm_fixed_3v3>; > + vddvario-supply = <&ape6evm_fixed_3v3>; > + }; > }; > }; The above didn't work in my tests without this: Thanks Guennadi --- Guennadi Liakhovetski, Ph.D. Freelance Open-Source Software Developer http://www.open-technology.de/ diff --git a/arch/arm/boot/dts/r8a73a4-ape6evm.dts b/arch/arm/boot/dts/r8a73a4-ape6evm.dts index f603c69..4fb0102 100644 --- a/arch/arm/boot/dts/r8a73a4-ape6evm.dts +++ b/arch/arm/boot/dts/r8a73a4-ape6evm.dts @@ -33,8 +33,10 @@ }; lbsc { + compatible = "simple-bus"; #address-cells = <1>; #size-cells = <1>; + ranges = <0 0 0 0x80000000>; ethernet@8000000 { compatible = "smsc,lan9118", "smsc,lan9115";