From patchwork Tue Nov 2 01:03:11 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Ma=C3=ADra_Canal?= X-Patchwork-Id: 12597681 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 524F9C433EF for ; Tue, 2 Nov 2021 01:04:50 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1CBE960F5A for ; Tue, 2 Nov 2021 01:04:50 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 1CBE960F5A Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=usp.br Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Subject:Cc:To: From:Date:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=2l4GIUspNCiAeJKa75VkmbrOVT9q5UgNX8jrKPPUevs=; b=Er2FSQnMOq6IlT j2hYarWV0PfrZzFInczVX4HQFdDIahCguOVpYpREVcOb2zFlzXkIXhRFYeh0guNP839gSyx5tZqHN /qdXLzFDJJv0tyl3p66DdeFml/6QLtBE8DCFSoA8Ha4kolsPhreTjpt8zO0JSckJqz0YzJ2Tt/nK2 PgpZKNpjMqq6t+ZkkqjQnpzj7yj4c4cMSwy2zlHolZWSq0sbOTxTB7d3UdfpeImXJ9413dRLfD0Pb l/+9hfv2HS4NWrbp1D02ohcA1BBTS5Ug6Ofr5qfNuH7dKVxfs7OGyN/EPTmxJxqhgkXQxii9w11xr V6VHB+hWZxuYU24jMYpw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mhiCw-000BLQ-IM; Tue, 02 Nov 2021 01:03:22 +0000 Received: from mail-qk1-x733.google.com ([2607:f8b0:4864:20::733]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mhiCs-000BKo-LC for linux-arm-kernel@lists.infradead.org; Tue, 02 Nov 2021 01:03:20 +0000 Received: by mail-qk1-x733.google.com with SMTP id p4so49244qkk.0 for ; Mon, 01 Nov 2021 18:03:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=usp.br; s=usp-google; h=date:from:to:cc:subject:message-id:mime-version:content-disposition :content-transfer-encoding; bh=TGCcvZeZM6ScS8ns8C85ZEr+fwzxhkjRxhi7dzfBgNI=; b=DUEgIAioC6rdnfITi3YqrGdRixhkLtVH/opP9meQh/HhvUcr5e/czGWPXgXPT/al+t cQsfUiE1JmgB98HT7yDx9t7sXm4iXrnLYRCtVoVJtmnEvpQmFl3P9yYBTuEvXL2cLHHE XrGQ4rqN3fdrBJvQwt93OM6YJLqxN6EOUOWH5jJDeQyLg2Czc4y+CCXjoaHLTRGcvkgE GeSTl78AvyiMl5faZn6G+wL2LLATPF5zqfXDsVRhd+DE4gZCXCbDdoY5yJRgLyp66UMh f/qBUB6gkohISL/ycWZmr1KPGdW9JJC5qSgJi7IcCqdcjwr7HWTyVx3tgTX6WsYnwqIL /ndQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:mime-version :content-disposition:content-transfer-encoding; bh=TGCcvZeZM6ScS8ns8C85ZEr+fwzxhkjRxhi7dzfBgNI=; b=jRy2CcKTwhBf70wWbbCtYNrbMd9E/mpiVmjoa11YtlJ30tud9En7wtvrX95HlWLxA/ /BTcNL++++7lW1eNS3vBRrfVXRcBNYKOOfaXI0u2WLOJH6Wf+GfademnIx+jw4U46DdO ZheooIMDMfidWCunpHlOr4TSWtQaB4LRAVLP639rzdvyxaC0ef8IbHelowxXARGXZWJT csdFGRwojbIqOCq0Hz2CAPU52MTpN6F3mB16YfsxmwiP9qPoq9hNNwNrnYBSeVCeL7l9 PDImkqXOltaHlFXgoB0ANbDtSb5JGc1M94GcApnmS9bU6dhQExb9WgGEWuDv8FwYysF7 uAPg== X-Gm-Message-State: AOAM531gIGfSlG+L04McFGi1NIEjgI4MYsGSS03dMSRaBepm4KQYJ5kk stb0vApAhU5DR59rFcj4fdF7Iw== X-Google-Smtp-Source: ABdhPJyBWeb4i1602rivILHKkuCx1txr9ds80E6KKnxWtLgok2J3iYCE8XXBj4AsgX0jYlXreReCJQ== X-Received: by 2002:a05:620a:2950:: with SMTP id n16mr13331281qkp.405.1635814997042; Mon, 01 Nov 2021 18:03:17 -0700 (PDT) Received: from fedora ([187.64.134.142]) by smtp.gmail.com with ESMTPSA id m19sm6043282qkn.51.2021.11.01.18.03.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 Nov 2021 18:03:16 -0700 (PDT) Date: Mon, 1 Nov 2021 22:03:11 -0300 From: =?iso-8859-1?q?Ma=EDra?= Canal To: hongxing.zhu@nxp.com, l.stach@pengutronix.de, lorenzo.pieralisi@arm.com, robh@kernel.org, bhelgaas@google.com, helgaas@kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de Cc: kernel@pengutronix.de, linux-imx@nxp.com, linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH v3] PCI: imx6: Replace legacy gpio interface for gpiod interface Message-ID: MIME-Version: 1.0 Content-Disposition: inline X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211101_180318_749443_6EEEED0D X-CRM114-Status: GOOD ( 16.46 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Considering the current transition of the GPIO subsystem, remove all dependencies of the legacy GPIO interface (linux/gpio.h and linux /of_gpio.h) and replace it with the descriptor-based GPIO approach. Signed-off-by: Maíra Canal --- V1 -> V2: Rewrite commit log and subject line to match PCI subsystem standard V2 -> v3: Change gpiod_set_value_cansleep for gpiod_set_raw_value_cansleep --- drivers/pci/controller/dwc/pci-imx6.c | 30 +++++++++------------------ 1 file changed, 10 insertions(+), 20 deletions(-) diff --git a/drivers/pci/controller/dwc/pci-imx6.c b/drivers/pci/controller/dwc/pci-imx6.c index 80fc98acf097..f08865ac0b40 100644 --- a/drivers/pci/controller/dwc/pci-imx6.c +++ b/drivers/pci/controller/dwc/pci-imx6.c @@ -11,13 +11,12 @@ #include #include #include -#include +#include #include #include #include #include #include -#include #include #include #include @@ -63,7 +62,7 @@ struct imx6_pcie_drvdata { struct imx6_pcie { struct dw_pcie *pci; - int reset_gpio; + struct gpio_desc *reset_gpio; bool gpio_active_high; struct clk *pcie_bus; struct clk *pcie_phy; @@ -526,11 +525,11 @@ static void imx6_pcie_deassert_core_reset(struct imx6_pcie *imx6_pcie) usleep_range(200, 500); /* Some boards don't have PCIe reset GPIO. */ - if (gpio_is_valid(imx6_pcie->reset_gpio)) { - gpio_set_value_cansleep(imx6_pcie->reset_gpio, + if (imx6_pcie->reset_gpio) { + gpiod_set_raw_value_cansleep(imx6_pcie->reset_gpio, imx6_pcie->gpio_active_high); msleep(100); - gpio_set_value_cansleep(imx6_pcie->reset_gpio, + gpiod_set_raw_value_cansleep(imx6_pcie->reset_gpio, !imx6_pcie->gpio_active_high); } @@ -1025,22 +1024,13 @@ static int imx6_pcie_probe(struct platform_device *pdev) return PTR_ERR(pci->dbi_base); /* Fetch GPIOs */ - imx6_pcie->reset_gpio = of_get_named_gpio(node, "reset-gpio", 0); imx6_pcie->gpio_active_high = of_property_read_bool(node, "reset-gpio-active-high"); - if (gpio_is_valid(imx6_pcie->reset_gpio)) { - ret = devm_gpio_request_one(dev, imx6_pcie->reset_gpio, - imx6_pcie->gpio_active_high ? - GPIOF_OUT_INIT_HIGH : - GPIOF_OUT_INIT_LOW, - "PCIe reset"); - if (ret) { - dev_err(dev, "unable to get reset gpio\n"); - return ret; - } - } else if (imx6_pcie->reset_gpio == -EPROBE_DEFER) { - return imx6_pcie->reset_gpio; - } + imx6_pcie->reset_gpio = devm_gpiod_get_optional(dev, "reset", + imx6_pcie->gpio_active_high ? GPIOD_OUT_HIGH : GPIOD_OUT_LOW); + if (IS_ERR(imx6_pcie->reset_gpio)) + return dev_err_probe(dev, PTR_ERR(imx6_pcie->reset_gpio), + "unable to get reset gpio\n"); /* Fetch clocks */ imx6_pcie->pcie_phy = devm_clk_get(dev, "pcie_phy");