From patchwork Wed Mar 16 09:33:15 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Domenico Andreoli X-Patchwork-Id: 12782472 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 24602C433F5 for ; Wed, 16 Mar 2022 09:34:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Subject:Cc:To: From:Date:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=2l2s8eRdy54vzp4gSSLoA5dNid+v/g/r0LHIjWVXlio=; b=3jJ3V/6n2X/GbN 8DRsiFcx1Mx3rXpWoGVpWmHSLmZq5FACIYTMMeQmGOd42yni1SEaT0FYzWkEHH/6VhWyx+kZVCfZr hRyArlorc0vvOWlp0o/VyaaCwrLMtAnuc57MN4JExRxh0+7AVe+Pb1NRXTDR/oiuCFIro3mACqfor 5yLXMSGSg4smQ1ONtRnMnQ/KqDE+IEV27wlpN3Pxyw4vjdxNrzjnIRSTYJlFmiivuYWRqXQAkTQAU MUZo88CHXnwOEPBO8KLJ+JA4l/SxZkdbqffaB1C+1Gm/NY+7vNxIZNEvwcZRZPfpn9ggT3Kd6fXAy +yYqkksWYCnjIesexiZQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nUQ20-00CK19-Gs; Wed, 16 Mar 2022 09:33:24 +0000 Received: from mail-ej1-x634.google.com ([2a00:1450:4864:20::634]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nUQ1w-00CK0A-Un for linux-arm-kernel@lists.infradead.org; Wed, 16 Mar 2022 09:33:22 +0000 Received: by mail-ej1-x634.google.com with SMTP id p15so2863397ejc.7 for ; Wed, 16 Mar 2022 02:33:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:date:from:to:cc:subject:message-id:mime-version :content-disposition; bh=4X7GtChBlSGEc/+chTPC6vZjWEUtBpd2taB2nG3hM7M=; b=J+51HOdYVjpoNjnXGBT5SDcBDpsvBeO1K5w9lOUmZRpcBJ2PYUc6eIQpU/DA/iZ5Dn 4N/041ntgziLZwPUPmDhW9LD+b4E6MHOyJDnCSKrwgr3njH2ei+xBliVdnHmxyF22O3a t28Ob2aT4uIlsDOW3xIFiGn4Lmj//BDbTTVAG/tnxO221cSwUGcPXvuJWWpqaFwyUlRQ ycwGxb9JndjxgCbKa3m7rUmxY9Jw5PBCocrfBcz/cS/eUQ18+L3XuoYVJTQhAnObnLAS pQbmk1jCP8T4FxX3w7egibOGNUDkS56Tem/oyGSASoLGDpV7GgdSfBHjcYrEqiqxawb5 Hsbg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :mime-version:content-disposition; bh=4X7GtChBlSGEc/+chTPC6vZjWEUtBpd2taB2nG3hM7M=; b=c6orNMH+/jUR/PUPpHV/zgOEil14aioRAwQ0g9nTmNMlzNO21VFZROv1QpjfqvSjfA TcNhPYM0CgG7lURU7otRO8CvQ3e6lSG+KeGoXGs8MtafJufF1l0PBeEpnhKPyhIk7kXb MdGiO9Eh1bBa2f1Nwbh/mEnsJ3PPJOkIk8tAEZQf2heCHRSCsfRyvEfLCqgOWS7MU0UD 2I+ejM5OY2amg6/cjOsKU33HOdtqTUwuQUkWWRmALxyFVaEbcafKInerN3xrp5YDUKd4 dDqr8AlP/8TaYj5qjbBFA4BtgCjVoVZhT3JPWyJQHjdphCL5Hes2ZnAxI9ga216Csp5z vwmg== X-Gm-Message-State: AOAM532GMAzAc/MpdO3htBsRQSKX5keQbCQMBZZPgNMtxQr7+gEWCAmO gZYV+1w7crPWN3wJcCErjGE= X-Google-Smtp-Source: ABdhPJwnGNJHTYvY+J53BMO5j5yfpGBZQ8D3OmAbtK7vNANaGbl36vyBAXdhovnPkm8ARYSNFvPbFA== X-Received: by 2002:a17:906:402:b0:6d5:c6bc:3150 with SMTP id d2-20020a170906040200b006d5c6bc3150mr26470418eja.403.1647423198383; Wed, 16 Mar 2022 02:33:18 -0700 (PDT) Received: from m4.home (04.vie.exit.tor.loki.tel. [2a0a:4cc0:0:fd4::4]) by smtp.gmail.com with ESMTPSA id n27-20020a1709062bdb00b006da975173bfsm643160ejg.170.2022.03.16.02.33.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Mar 2022 02:33:17 -0700 (PDT) Received: from cavok by m4.home with local (Exim 4.94.2) (envelope-from ) id 1nUQ1r-000GSM-FW; Wed, 16 Mar 2022 10:33:15 +0100 Date: Wed, 16 Mar 2022 10:33:15 +0100 From: Domenico Andreoli To: Andrew Lunn , Gregory Clement , Sebastian Hesselbarth Cc: Thomas Gleixner , linux-arm-kernel@lists.infradead.org Subject: [PATCH] PCI/MSI: mvebu: Re-enable arch fallbacks Message-ID: MIME-Version: 1.0 Content-Disposition: inline X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220316_023321_020068_2C4F1B89 X-CRM114-Status: UNSURE ( 9.97 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Domenico Andreoli Since v5.10, my QNAP happily barks at boot as follows (5.17.0-rc8): [ 0.923811] ------------[ cut here ]------------ [ 0.928458] WARNING: CPU: 0 PID: 1 at drivers/pci/msi/msi.h:17 pci_msi_setup_msi_irqs+0x54/0x6c [ 0.937219] Modules linked in: [ 0.940290] CPU: 0 PID: 1 Comm: swapper Not tainted 5.17.0-rc8-marvell #6 [ 0.947117] Hardware name: Marvell Kirkwood (Flattened Device Tree) [ 0.953428] unwind_backtrace from show_stack+0x10/0x14 [ 0.958698] show_stack from __warn+0xac/0xe4 [ 0.963093] __warn from warn_slowpath_fmt+0x68/0x80 [ 0.968098] warn_slowpath_fmt from pci_msi_setup_msi_irqs+0x54/0x6c [ 0.974499] pci_msi_setup_msi_irqs from __pci_enable_msi_range+0x260/0x340 [ 0.981509] __pci_enable_msi_range from pci_alloc_irq_vectors_affinity+0xb8/0xf8 [ 0.989043] pci_alloc_irq_vectors_affinity from xhci_run+0x164/0x474 [ 0.995532] xhci_run from usb_add_hcd+0x444/0x6e0 [ 1.000362] usb_add_hcd from usb_hcd_pci_probe+0x30c/0x37c [ 1.005979] usb_hcd_pci_probe from xhci_pci_probe+0x10/0xec [ 1.011689] xhci_pci_probe from pci_device_probe+0x74/0xe8 [ 1.017305] pci_device_probe from really_probe+0x1c0/0x3f8 [ 1.022921] really_probe from driver_probe_device+0x30/0xb0 [ 1.028623] driver_probe_device from __driver_attach+0x11c/0x148 [ 1.034762] __driver_attach from bus_for_each_dev+0x54/0x78 [ 1.040466] bus_for_each_dev from bus_add_driver+0x170/0x1d8 [ 1.046256] bus_add_driver from driver_register+0xac/0xf0 [ 1.051783] driver_register from do_one_initcall+0x74/0x1b8 [ 1.057495] do_one_initcall from kernel_init_freeable+0x1a8/0x1ec [ 1.063723] kernel_init_freeable from kernel_init+0x10/0x108 [ 1.069514] kernel_init from ret_from_fork+0x14/0x3c [ 1.074604] Exception stack(0xc1835fb0 to 0xc1835ff8) [ 1.079691] 5fa0: 00000000 00000000 00000000 00000000 [ 1.087915] 5fc0: 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 [ 1.096136] 5fe0: 00000000 00000000 00000000 00000000 00000013 00000000 [ 1.102787] ---[ end trace 0000000000000000 ]--- [ 1.107435] ------------[ cut here ]------------ I bisected it down to commit 077ee78e392869e46ae (PCI/MSI: Make arch_.*_msi_irq[s] fallbacks selectable). Re-enabling PCI/MSI arch fallbacks restores a clean bootlog. Cc: Thomas Gleixner Cc: linux-arm-kernel@lists.infradead.org Signed-off-by: Domenico Andreoli --- arch/arm/mach-mvebu/Kconfig | 1 + 1 file changed, 1 insertion(+) Index: b/arch/arm/mach-mvebu/Kconfig =================================================================== --- a/arch/arm/mach-mvebu/Kconfig +++ b/arch/arm/mach-mvebu/Kconfig @@ -123,6 +123,7 @@ config MACH_KIRKWOOD select ORION_IRQCHIP select ORION_TIMER select FORCE_PCI + select PCI_MSI_ARCH_FALLBACKS if PCI_MSI select PCI_QUIRKS select PINCTRL_KIRKWOOD help