| Message ID | YzcSqZdpNbdINp4Q@google.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [v2] ARM: dts: stihxxx-b2120: fix polarity of reset line of tsin0 port | expand |
On Fri, Sep 30, 2022 at 09:00:41AM -0700, Dmitry Torokhov wrote: > According to c8sectpfe driver code we first drive reset line low and > then high to reset the port, therefore the reset line is supposed to > be annotated as "active low". This will be important when we convert > the driver to gpiod API. > > Reviewed-by: Patrice Chotard <patrice.chotard@foss.st.com> > Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com> > --- Gentle ping on this one... > > v2: fixed typo in the subject, added Patrice's reviewed-by > > arch/arm/boot/dts/stihxxx-b2120.dtsi | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm/boot/dts/stihxxx-b2120.dtsi b/arch/arm/boot/dts/stihxxx-b2120.dtsi > index 2aa94605d3d4..d52a7aaa1074 100644 > --- a/arch/arm/boot/dts/stihxxx-b2120.dtsi > +++ b/arch/arm/boot/dts/stihxxx-b2120.dtsi > @@ -178,7 +178,7 @@ tsin0: port { > tsin-num = <0>; > serial-not-parallel; > i2c-bus = <&ssc2>; > - reset-gpios = <&pio15 4 GPIO_ACTIVE_HIGH>; > + reset-gpios = <&pio15 4 GPIO_ACTIVE_LOW>; > dvb-card = <STV0367_TDA18212_NIMA_1>; > }; > }; > -- > 2.38.0.rc1.362.ged0d419d3c-goog > > > -- > Dmitry
On 2/2/23 19:51, Dmitry Torokhov wrote: > On Fri, Sep 30, 2022 at 09:00:41AM -0700, Dmitry Torokhov wrote: >> According to c8sectpfe driver code we first drive reset line low and >> then high to reset the port, therefore the reset line is supposed to >> be annotated as "active low". This will be important when we convert >> the driver to gpiod API. >> >> Reviewed-by: Patrice Chotard <patrice.chotard@foss.st.com> >> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com> >> --- > > Gentle ping on this one... Hi Dmitry Sorry for the delay, i will push a STi pull request including your patch. Patrice > >> >> v2: fixed typo in the subject, added Patrice's reviewed-by >> >> arch/arm/boot/dts/stihxxx-b2120.dtsi | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/arch/arm/boot/dts/stihxxx-b2120.dtsi b/arch/arm/boot/dts/stihxxx-b2120.dtsi >> index 2aa94605d3d4..d52a7aaa1074 100644 >> --- a/arch/arm/boot/dts/stihxxx-b2120.dtsi >> +++ b/arch/arm/boot/dts/stihxxx-b2120.dtsi >> @@ -178,7 +178,7 @@ tsin0: port { >> tsin-num = <0>; >> serial-not-parallel; >> i2c-bus = <&ssc2>; >> - reset-gpios = <&pio15 4 GPIO_ACTIVE_HIGH>; >> + reset-gpios = <&pio15 4 GPIO_ACTIVE_LOW>; >> dvb-card = <STV0367_TDA18212_NIMA_1>; >> }; >> }; >> -- >> 2.38.0.rc1.362.ged0d419d3c-goog >> >> >> -- >> Dmitry >
diff --git a/arch/arm/boot/dts/stihxxx-b2120.dtsi b/arch/arm/boot/dts/stihxxx-b2120.dtsi index 2aa94605d3d4..d52a7aaa1074 100644 --- a/arch/arm/boot/dts/stihxxx-b2120.dtsi +++ b/arch/arm/boot/dts/stihxxx-b2120.dtsi @@ -178,7 +178,7 @@ tsin0: port { tsin-num = <0>; serial-not-parallel; i2c-bus = <&ssc2>; - reset-gpios = <&pio15 4 GPIO_ACTIVE_HIGH>; + reset-gpios = <&pio15 4 GPIO_ACTIVE_LOW>; dvb-card = <STV0367_TDA18212_NIMA_1>; }; };