From patchwork Wed May 24 04:05:14 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Angus Ainslie X-Patchwork-Id: 9744927 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 78B5960210 for ; Wed, 24 May 2017 04:05:44 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 647EC2889C for ; Wed, 24 May 2017 04:05:44 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 593B4288A2; Wed, 24 May 2017 04:05:44 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [65.50.211.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id C57D72889C for ; Wed, 24 May 2017 04:05:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Message-ID:References:In-Reply-To:From:Date: MIME-Version:Subject:To:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=cyEd2HvwTblBT25z+pGMv4QuDQKF67B7+J8D2/D670s=; b=qod9gwVegT0T6CP+c7KrbkSJP btgi416b6xbsPJd3QlLEaOjvSQYxP4VtodByfeHkHdfjhGtJklmHc1aoeKz0RMR0kbMN1OophhV5t xgcr3SUcq7jTdvskPQZDSZxhUiCsEVB+/r1eVEKMDbm7DUmODu1vm8Rwijxjn5N5Dt26o5kgFg//e chgWEqBT8nfNirRABrMXgAFFOgUa1ClAghIpFPLGIrbRt+dnnnIdOutl2cI2s5gXjX6Njlfh+Xh6A +3npU64TvilGLgHpGX8dlzKGpSP+xKS+j/yiGdD4txSWwNcNHgfCQUQ8LsmAbntve4Onw7DQEZuNg jZflGGsCA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux)) id 1dDNYJ-0003cT-Ld; Wed, 24 May 2017 04:05:39 +0000 Received: from node.akkea.ca ([192.155.83.177]) by bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux)) id 1dDNYG-0003az-JZ; Wed, 24 May 2017 04:05:37 +0000 Received: by node.akkea.ca (Postfix, from userid 33) id 0DABB5420D0; Wed, 24 May 2017 04:05:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=akkea.ca; s=mail; t=1495598714; bh=76qqcMuY3d3uTDnd859KqaWxdo/ClPH1qQgqc1MkvEw=; h=To:Subject:Date:From:Cc:In-Reply-To:References; b=qGpuPYc+qEBU1GeOSdUZx4zrvB+7qihy15lplJD2wkej3eFy+mgfFRWDLPXkKe11W hTXtEWXdWuXLtoFx/IBKKBFRtv/N9FlZFwlGIppaJ8pb2uIv8Fa5rWfTQSzR7+3uxx hnLU6+YYXXhBFzZQbR7LMXqM3yytWOGT+VGT71Uc= To: Maxime Ripard Subject: Re: CHIPPro NAND issue with 4.12 rc1 X-PHP-Originating-Script: 1000:rcube.php MIME-Version: 1.0 Date: Tue, 23 May 2017 22:05:14 -0600 From: Angus Ainslie In-Reply-To: <20170523195239.6nsv4ydrt4u7q6ge@flea.home> References: <399ea126f3b18071fbe46bfc9787df6b@www.akkea.ca> <20170520171418.4e8a47e0@bbrezillon> <6f3cefa6c54776f82160ed8954f4d0d4@www.akkea.ca> <20170521074535.4a4ba6dd@bbrezillon> <20170522070117.mwk4gm34o7idedye@flea.home> <63aca137397dc3700a34993205c8cfba@www.akkea.ca> <20170523195239.6nsv4ydrt4u7q6ge@flea.home> Message-ID: X-Sender: angus@akkea.ca User-Agent: Roundcube Webmail/1.1.3 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20170523_210536_653645_42545372 X-CRM114-Status: UNSURE ( 7.62 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Boris Brezillon , Richard Weinberger , linux-kernel@vger.kernel.org, Marek Vasut , Chen-Yu Tsai , linux-mtd@lists.infradead.org, Cyrille Pitchen , Brian Norris , David Woodhouse , linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP On 2017-05-23 13:52, Maxime Ripard wrote: > > Ok, good. > > If you unrevert those patches, and add clk_ignore_unused to the kernel > command line, is it still broken? > > Maxime If I use the clk_ignore_unused flag with the patches below then the kernel can boot and mount the nand. diff --git a/drivers/clk/sunxi-ng/ccu-sun5i.c b/drivers/clk/sunxi-ng/ccu-sun5i.c index 5c476f9..700944c 100644 --- a/drivers/clk/sunxi-ng/ccu-sun5i.c +++ b/drivers/clk/sunxi-ng/ccu-sun5i.c @@ -251,7 +251,7 @@ static SUNXI_CCU_GATE(ahb_mmc1_clk, "ahb-mmc1", "ahb", static SUNXI_CCU_GATE(ahb_mmc2_clk, "ahb-mmc2", "ahb", 0x060, BIT(10), 0); static SUNXI_CCU_GATE(ahb_nand_clk, "ahb-nand", "ahb", - 0x060, BIT(13), 0); + 0x060, BIT(13), CLK_IS_CRITICAL); static SUNXI_CCU_GATE(ahb_sdram_clk, "ahb-sdram", "ahb", 0x060, BIT(14), CLK_IS_CRITICAL); static SUNXI_CCU_GATE(ahb_emac_clk, "ahb-emac", "ahb", diff --git a/arch/arm/boot/dts/sun5i-gr8-chip-pro.dts b/arch/arm/boot/dts/sun5i-gr8-chip-pro.dts index c55b11a..fa37cce 100644 --- a/arch/arm/boot/dts/sun5i-gr8-chip-pro.dts +++ b/arch/arm/boot/dts/sun5i-gr8-chip-pro.dts @@ -146,6 +149,32 @@ reg = <0>; allwinner,rb = <0>; nand-ecc-mode = "hw"; + nand-on-flash-bbt; + + spl@0 { + label = "SPL"; + reg = /bits/ 64 <0x0 0x400000>; + }; + + spl-backup@400000 { + label = "SPL.backup"; + reg = /bits/ 64 <0x400000 0x400000>; + }; + + u-boot@800000 { + label = "U-Boot"; + reg = /bits/ 64 <0x800000 0x400000>; + }; + + env@c00000 { + label = "env"; + reg = /bits/ 64 <0xc00000 0x400000>; + }; + + rootfs@1000000 { + label = "rootfs"; + reg = /bits/ 64 <0x1000000 0x1f000000>; + }; }; };