From patchwork Fri May 25 10:31:57 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Viresh Kumar X-Patchwork-Id: 10427061 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id E42C56025B for ; Fri, 25 May 2018 10:38:44 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 8D37529478 for ; Fri, 25 May 2018 10:38:43 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 811FE29496; Fri, 25 May 2018 10:38:43 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI autolearn=unavailable version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 0432A29478 for ; Fri, 25 May 2018 10:38:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:References: In-Reply-To:Message-Id:Date:Subject:To:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=8KM/YsD6h+zOviJn0YEtgVgPYlwf7zSPBF41gyk2S5M=; b=OFOiZQarQCMjgnfAQUtSMHtA7v UQa264pIa/8wPZDjiql3HXXcCKAXN/Hh7ntVE5i1nDMopGf+Xy0NUiXzF44A48TJZmzNOpg6sjqX+ sA6w9bPt6V/uArjkViTki1eGaqk59G5vRUsL1gM+WoGR04wGKOc/cfRb92uozsZGYDgxmKgDE8W6L N35hP1wqCMfHhyugQHOu9jDnbW06JoEut7uh/k0Mx+cdjZvzDbmGuufZxgICC+3DX2EweiOUg0HyK cKpyXNEVaGufyP5jCZzCQw3bUHIPhakSdbmmHO2VjBkXyTPq3Ui0nFsZ29FxFsuWLEyc7FXO5Zpah vN0ta2CA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1fMA7H-0006r7-Lb; Fri, 25 May 2018 10:38:35 +0000 Received: from mail-pg0-x242.google.com ([2607:f8b0:400e:c05::242]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1fMA1r-0002fo-Fp for linux-arm-kernel@lists.infradead.org; Fri, 25 May 2018 10:33:09 +0000 Received: by mail-pg0-x242.google.com with SMTP id a13-v6so2126626pgu.4 for ; Fri, 25 May 2018 03:32:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :in-reply-to:references; bh=oI2cROa+PxL2Hh479zrubLMWd0VS3zfe+ruyZ1msXaY=; b=b9F9FOacHQ112XFsBoUG9iw0JX93Pfsn1kp1pm3OipwS/pMcZKKPnhYfXL9yLE2lLC 2pga+BOZnCHBf9ssymqiu6Gvj98ZNpqB5Uk5NbR+nrWv2PI/CNXfDWQ/lGtnno+Kj7lv fh4OOCJDt4qfRkCc2b31DMGulkxzbK6Sr3dnQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:in-reply-to:references; bh=oI2cROa+PxL2Hh479zrubLMWd0VS3zfe+ruyZ1msXaY=; b=Z+BEYOt0Jd19JjWSN1Lh6ofkOkLo8iuOVdJl/VmsbFE3N5D5g5QtQArQtSQntyvXMj /Pmy/GtWGpSfRseOwfU4Y47+y7aA3g+K0K1paMrnQia0afybAXlHd6Yj9Acb0BOPFepB 3Jy7sxlolhrLWdv1WOdCNNc3ddc2yjzHc8NWhmm9YPZoNhtdxjybiYekjckpE85Zx1c8 1SYDJKSFKKTIJ7AYYE47hLFg5IFYG/8gKM4Fjdi5TqXCA6D8xEsYE63xh3bFAGon2aOa 78z5v+IJMG/Vktk4nOBwVH0NCBO7tktzJqpH90N1rY5xf2/qQ/dCvXWmzyp3nodg1mSn AMxQ== X-Gm-Message-State: ALKqPweaQb5jITv8kiF+QRxeYTqfRcrCxEYvYmgp4CtQmSo+u5lskNoY IxcHAWVQZzwjF01U25+Q4xh4trVUPhg= X-Google-Smtp-Source: AB8JxZqPQjiIgey85nHBx0iB1Y5297z+yZptyfU5v6Y707LdpOfDqb8V/QH4LmRXIRqAA/8QiSZ9hA== X-Received: by 2002:a62:6883:: with SMTP id d125-v6mr2001382pfc.26.1527244371016; Fri, 25 May 2018 03:32:51 -0700 (PDT) Received: from localhost ([122.172.112.176]) by smtp.gmail.com with ESMTPSA id p71-v6sm58522698pfl.170.2018.05.25.03.32.49 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 25 May 2018 03:32:50 -0700 (PDT) From: Viresh Kumar To: arm@kernel.org, Jisheng Zhang , Sebastian Hesselbarth , Rob Herring , Mark Rutland Subject: [PATCH 11/15] arm: dts: berlin: Add missing OPP properties for CPUs Date: Fri, 25 May 2018 16:01:57 +0530 Message-Id: X-Mailer: git-send-email 2.15.0.194.g9af6a3dea062 In-Reply-To: References: In-Reply-To: References: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20180525_033259_591928_A5EFAB08 X-CRM114-Status: GOOD ( 13.53 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Vincent Guittot , Viresh Kumar , Daniel Lezcano , linux-kernel@vger.kernel.org, chris.redpath@arm.com, ionela.voinescu@arm.com, linux-arm-kernel@lists.infradead.org MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP The OPP properties, like "operating-points", should either be present for all the CPUs of a cluster or none. If these are present only for a subset of CPUs of a cluster then things will start falling apart as soon as the CPUs are brought online in a different order. For example, this will happen because the operating system looks for such properties in the CPU node it is trying to bring up, so that it can create an OPP table. Add such missing properties. Fix other missing properties (clocks, clock latency) as well to make it all work. Signed-off-by: Viresh Kumar --- arch/arm/boot/dts/berlin2.dtsi | 10 ++++++++++ arch/arm/boot/dts/berlin2q.dtsi | 33 +++++++++++++++++++++++++++++++++ 2 files changed, 43 insertions(+) diff --git a/arch/arm/boot/dts/berlin2.dtsi b/arch/arm/boot/dts/berlin2.dtsi index d575823c5750..487e9de53244 100644 --- a/arch/arm/boot/dts/berlin2.dtsi +++ b/arch/arm/boot/dts/berlin2.dtsi @@ -81,6 +81,16 @@ device_type = "cpu"; next-level-cache = <&l2>; reg = <1>; + + clocks = <&chip_clk CLKID_CPU>; + clock-latency = <100000>; + operating-points = < + /* kHz uV */ + 1200000 1200000 + 1000000 1200000 + 800000 1200000 + 600000 1200000 + >; }; }; diff --git a/arch/arm/boot/dts/berlin2q.dtsi b/arch/arm/boot/dts/berlin2q.dtsi index bf3a6c9a1d34..9cd00ab53f2d 100644 --- a/arch/arm/boot/dts/berlin2q.dtsi +++ b/arch/arm/boot/dts/berlin2q.dtsi @@ -76,6 +76,17 @@ device_type = "cpu"; next-level-cache = <&l2>; reg = <1>; + + clocks = <&chip_clk CLKID_CPU>; + clock-latency = <100000>; + /* Can be modified by the bootloader */ + operating-points = < + /* kHz uV */ + 1200000 1200000 + 1000000 1200000 + 800000 1200000 + 600000 1200000 + >; }; cpu@2 { @@ -83,6 +94,17 @@ device_type = "cpu"; next-level-cache = <&l2>; reg = <2>; + + clocks = <&chip_clk CLKID_CPU>; + clock-latency = <100000>; + /* Can be modified by the bootloader */ + operating-points = < + /* kHz uV */ + 1200000 1200000 + 1000000 1200000 + 800000 1200000 + 600000 1200000 + >; }; cpu@3 { @@ -90,6 +112,17 @@ device_type = "cpu"; next-level-cache = <&l2>; reg = <3>; + + clocks = <&chip_clk CLKID_CPU>; + clock-latency = <100000>; + /* Can be modified by the bootloader */ + operating-points = < + /* kHz uV */ + 1200000 1200000 + 1000000 1200000 + 800000 1200000 + 600000 1200000 + >; }; };