From patchwork Thu Jan 11 20:04:43 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Lechner X-Patchwork-Id: 10158467 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 1C44560170 for ; Thu, 11 Jan 2018 20:05:03 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 0BC3228802 for ; Thu, 11 Jan 2018 20:05:03 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id F261D28844; Thu, 11 Jan 2018 20:05:02 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_MED autolearn=unavailable version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [65.50.211.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 8156028802 for ; Thu, 11 Jan 2018 20:05:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=D7HA80eqVS2NcnYS4fDGkXG210DXsvV/Aoart0zrZ9M=; b=sfJbtGnh8esxi9dlKgpISzG4n q51d7N+tRzMzv5aFJDITFR90cvnvm85imIqRIMmTIOHG7hoRtFjitil2o/TMX1JZf2U5ajvq8rFbM vqNYYdUIvHVuauF9OGhS9SL16XagWvmCJaL/1ITPyn0y0Upfoka73sLC/JAFvAsVYVHWDWmL9nsw7 4MCfYmvHcdwMhjygpcJJdIqR+4lhK3FDhnifVy6RkHH0HQu7+GK0BCN4+WZcE284038YNKgFtGXLW mUcUG6HmkXoRBvHdKmvRaaCgwEyLDR2yWaX3b4vMqgr9sk0nNg+ZlbrQ+O+14Ftlcpx7UQmeFGWMS ebaI4j+6A==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.89 #1 (Red Hat Linux)) id 1eZj5v-0006BC-UB; Thu, 11 Jan 2018 20:04:59 +0000 Received: from vern.gendns.com ([206.190.152.46]) by bombadil.infradead.org with esmtps (Exim 4.89 #1 (Red Hat Linux)) id 1eZj5s-000698-Kd for linux-arm-kernel@lists.infradead.org; Thu, 11 Jan 2018 20:04:58 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lechnology.com; s=default; h=Content-Transfer-Encoding:Content-Type: In-Reply-To:MIME-Version:Date:Message-ID:From:References:Cc:To:Subject:Sender :Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=pWjsYs2C1frwXSyIFTgYXbbHIWPDMtf2f+7t7s0KcVY=; b=pxyyGOwWnSf8RZ52TpMXkhXsc7 oUXbeZqOzGkvv02QSM5Zs9HPKeHbJQ9Rk7haOMEItcrlRRqkGgXMdBCsvjakB1i7s71PWcP270L5W S3Ywm7gKq5OroraN+LATDGWdoNc/2JiyQ9W8HceFu7QXI+o+oIkNIeAjPa/FOTWrObcdlza43fGaO 9K5Y8O8jTBYxeY9vooqekgDrBCFm2ohvFT/CmGNqgcdemgwi3TyWeFCjh8n9lTpHJnFD3U45jW+U7 b4rk0ea4IASzV3Ci/SyaEDAVJHQkcGaWnl15tagoNVo/fRMqK8YzzP8sVgv4wvAz2sgM5WZ0heIO0 TwnuOMxA==; Received: from 108-198-5-147.lightspeed.okcbok.sbcglobal.net ([108.198.5.147]:36146 helo=[192.168.0.134]) by vern.gendns.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.89_1) (envelope-from ) id 1eZj5Q-003BHI-Kh; Thu, 11 Jan 2018 15:04:28 -0500 Subject: Re: [PATCH v5 01/44] dt-bindings: clock: Add new bindings for TI Davinci PLL clocks To: Adam Ford References: <1515377863-20358-1-git-send-email-david@lechnology.com> <1515377863-20358-2-git-send-email-david@lechnology.com> <22409e49-5c14-4068-b137-7535afaf90d7@lechnology.com> <0f90b5f7-f21e-5f81-1154-9a815bbb786d@ti.com> <5aacc350-6236-2e4f-35bb-a681fc9d47e7@ti.com> <40501635-6f5b-20c9-f8bc-d17e26b58426@lechnology.com> From: David Lechner Message-ID: Date: Thu, 11 Jan 2018 14:04:43 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - vern.gendns.com X-AntiAbuse: Original Domain - lists.infradead.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - lechnology.com X-Get-Message-Sender-Via: vern.gendns.com: authenticated_id: davidmain+lechnology.com/only user confirmed/virtual account not confirmed X-Authenticated-Sender: vern.gendns.com: davidmain@lechnology.com X-Source: X-Source-Args: X-Source-Dir: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20180111_120456_705658_254AD7C7 X-CRM114-Status: GOOD ( 13.97 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree@vger.kernel.org, Kevin Hilman , Sekhar Nori , Michael Turquette , Stephen Boyd , linux-kernel@vger.kernel.org, Rob Herring , linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP On 01/11/2018 12:50 PM, Adam Ford wrote: > On Thu, Jan 11, 2018 at 12:29 PM, David Lechner wrote: >> If removing the "clk_ignore_unused" option causes the board to not boot, >> then we still have problems that need to be fixed, so please also test >> without this option. > > Without this option, it still does not boot. Without device tree it > hangs after: > > [snip] > > NET: Registered protocol family 17 > Loading compiled-in X.509 certificates > console [netcon0] enabled > netconsole: network logging started > davinci_emac davinci_emac.1: using random MAC addr: 5e:38:1a:1f:4f:77 > mmc0: host does not support reading read-only switch, assuming write-enable > hctosys: unable to open rtc device (rtc0) > mmc0: new high speed SDHC card at address b368 > > > With device tree it hangs after: > > [snip] > mmc0: host does not support reading read-only switch, assuming write-enable > mmc0: new high speed SDHC card at address b368 > mmcblk0: mmc0:b368 00000 3.75 GiB > mmcblk0: p1 p2 > pca953x 0-0020: 0-0020 supply vcc not found, using dummy regulator > pca953x 0-0020: failed reading register > pca953x: probe of 0-0020 failed with error -121 > console [netcon0] enabled > netconsole: network logging started > davinci_emac 1e20000.ethernet: incompatible machine/device type for > reading mac address > hctosys: unable to open rtc device (rtc0) > > Please try this change: If that does not work, try adding LPSC_ALWAYS_ENABLED to all of the clocks in this file and then eliminate them one by one until you find which one is preventing boot. If it still does not boot, there is a similar DIVCLK_ALWAYS_ENABLED flag in drivers/clk/davinci/pll-da850.c that you can repeat the exercise with. Add DIVCLK_ALWAYS_ENABLED to all of the clocks there and then eliminate it one by one until you find the clock that is causing the problem. diff --git a/drivers/clk/davinci/psc-da850.c b/drivers/clk/davinci/psc-da850.c index 3fd6b49..a526cc2 100644 --- a/drivers/clk/davinci/psc-da850.c +++ b/drivers/clk/davinci/psc-da850.c @@ -17,7 +17,7 @@ static const struct davinci_psc_clk_info da850_psc0_info[] __initconst = { LPSC(0, 0, tpcc0, pll0_sysclk2, LPSC_ALWAYS_ENABLED), LPSC(1, 0, tptc0, pll0_sysclk2, LPSC_ALWAYS_ENABLED), LPSC(2, 0, tptc1, pll0_sysclk2, LPSC_ALWAYS_ENABLED), - LPSC(3, 0, aemif, pll0_sysclk3, 0), + LPSC(3, 0, aemif, pll0_sysclk3, LPSC_ALWAYS_ENABLED), LPSC(4, 0, spi0, pll0_sysclk2, 0), LPSC(5, 0, mmcsd0, pll0_sysclk2, 0), LPSC(6, 0, aintc, pll0_sysclk4, LPSC_ALWAYS_ENABLED),