| Message ID | ab5bad0258e455ef84059b749ca9e79f311b5e3c.1557486950.git.amit.kucheria@linaro.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | qcom: Add cpuidle to some platforms | expand |
On Fri, May 10, 2019 at 04:59:39PM +0530, Amit Kucheria wrote: > The idle-states binding documentation[1] mentions that the > 'entry-method' property is required on 64-bit platforms and must be set > to "psci". > > We fixed up all uses of the entry-method property in > commit e9880240e4f4 ("arm64: dts: Fix various entry-method properties to > reflect documentation"). But a new one has appeared. Fix it up. > > Cc: Sudeep Holla <sudeep.holla@arm.com> Ah right, new ones always appear for short period. Anyways, Acked-by: Sudeep Holla <sudeep.holla@arm.com> > Signed-off-by: Amit Kucheria <amit.kucheria@linaro.org> > --- > arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi > index 2896bbcfa3bb..42e7822a0227 100644 > --- a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi > +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi > @@ -51,7 +51,7 @@ > * PSCI node is not added default, U-boot will add missing > * parts if it determines to use PSCI. > */ > - entry-method = "arm,psci"; > + entry-method = "psci"; > > CPU_PH20: cpu-ph20 { > compatible = "arm,idle-state"; > -- > 2.17.1 >
On Fri 10 May 04:29 PDT 2019, Amit Kucheria wrote: Subject indicates pluralism, but this fixes a specific platform (board?). I think you should update that. > The idle-states binding documentation[1] mentions that the > 'entry-method' property is required on 64-bit platforms and must be set > to "psci". > > We fixed up all uses of the entry-method property in > commit e9880240e4f4 ("arm64: dts: Fix various entry-method properties to > reflect documentation"). But a new one has appeared. Fix it up. > > Cc: Sudeep Holla <sudeep.holla@arm.com> The message looks good though, so with a new subject you have my: Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org> Regards, Bjorn > Signed-off-by: Amit Kucheria <amit.kucheria@linaro.org> > --- > arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi > index 2896bbcfa3bb..42e7822a0227 100644 > --- a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi > +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi > @@ -51,7 +51,7 @@ > * PSCI node is not added default, U-boot will add missing > * parts if it determines to use PSCI. > */ > - entry-method = "arm,psci"; > + entry-method = "psci"; > > CPU_PH20: cpu-ph20 { > compatible = "arm,idle-state"; > -- > 2.17.1 >
On Tue, May 14, 2019 at 12:09 AM Bjorn Andersson <bjorn.andersson@linaro.org> wrote: > > On Fri 10 May 04:29 PDT 2019, Amit Kucheria wrote: > > Subject indicates pluralism, but this fixes a specific platform > (board?). I think you should update that. Copy paste from the previous cleanup commit :-) Will fix. > > The idle-states binding documentation[1] mentions that the > > 'entry-method' property is required on 64-bit platforms and must be set > > to "psci". > > > > We fixed up all uses of the entry-method property in > > commit e9880240e4f4 ("arm64: dts: Fix various entry-method properties to > > reflect documentation"). But a new one has appeared. Fix it up. > > > > Cc: Sudeep Holla <sudeep.holla@arm.com> > > The message looks good though, so with a new subject you have my: > > Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org> Thanks > > > Signed-off-by: Amit Kucheria <amit.kucheria@linaro.org> > > --- > > arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi > > index 2896bbcfa3bb..42e7822a0227 100644 > > --- a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi > > +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi > > @@ -51,7 +51,7 @@ > > * PSCI node is not added default, U-boot will add missing > > * parts if it determines to use PSCI. > > */ > > - entry-method = "arm,psci"; > > + entry-method = "psci"; > > > > CPU_PH20: cpu-ph20 { > > compatible = "arm,idle-state"; > > -- > > 2.17.1 > >
On Fri, May 10, 2019 at 04:59:39PM +0530, Amit Kucheria wrote: > The idle-states binding documentation[1] mentions that the This [1] reference is a null pointer ;) Other than that: Reviewed-by: Niklas Cassel <niklas.cassel@linaro.org> > 'entry-method' property is required on 64-bit platforms and must be set > to "psci". > > We fixed up all uses of the entry-method property in > commit e9880240e4f4 ("arm64: dts: Fix various entry-method properties to > reflect documentation"). But a new one has appeared. Fix it up. > > Cc: Sudeep Holla <sudeep.holla@arm.com> > Signed-off-by: Amit Kucheria <amit.kucheria@linaro.org> > --- > arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi > index 2896bbcfa3bb..42e7822a0227 100644 > --- a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi > +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi > @@ -51,7 +51,7 @@ > * PSCI node is not added default, U-boot will add missing > * parts if it determines to use PSCI. > */ > - entry-method = "arm,psci"; > + entry-method = "psci"; > > CPU_PH20: cpu-ph20 { > compatible = "arm,idle-state"; > -- > 2.17.1 >
diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi index 2896bbcfa3bb..42e7822a0227 100644 --- a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi @@ -51,7 +51,7 @@ * PSCI node is not added default, U-boot will add missing * parts if it determines to use PSCI. */ - entry-method = "arm,psci"; + entry-method = "psci"; CPU_PH20: cpu-ph20 { compatible = "arm,idle-state";
The idle-states binding documentation[1] mentions that the 'entry-method' property is required on 64-bit platforms and must be set to "psci". We fixed up all uses of the entry-method property in commit e9880240e4f4 ("arm64: dts: Fix various entry-method properties to reflect documentation"). But a new one has appeared. Fix it up. Cc: Sudeep Holla <sudeep.holla@arm.com> Signed-off-by: Amit Kucheria <amit.kucheria@linaro.org> --- arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)